Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d688043a52 | ||
|
|
d1e78f7e1c |
@@ -18,6 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/), and this
|
||||
### Fixed
|
||||
|
||||
- **The visible Android Sphere keeps its smooth procedural motion across startup and chat.** Backgrounded and motion-disabled surfaces remain still without reducing foreground animation to a stepped ambient pulse.
|
||||
- **Android New Chat keeps the current profile and stays fresh across profile switches.** Starting from All Profiles no longer forces the literal default profile, choosing another profile from an empty draft no longer reopens that profile's previous session after route settlement or restart, and leaving a provisional phone Thread cannot route the next turn to its old chat under the new profile.
|
||||
|
||||
### Removed
|
||||
|
||||
|
||||
@@ -196,6 +196,7 @@ internal class HermesRuntimeBinder(
|
||||
chat.profileSessionPinner = connection::setSessionPinned
|
||||
chat.profileSessionArchiver = connection::setSessionArchived
|
||||
chat.onSessionChanged = connection::saveLastSessionId
|
||||
chat.onFreshDraftSelected = connection::saveFreshDraft
|
||||
chat.setDemoModeWiring(
|
||||
isDemo = { connection.isDemoMode.value },
|
||||
handler = { connection.chatHandler },
|
||||
|
||||
@@ -215,7 +215,6 @@ fun SessionDrawerContent(
|
||||
/** Opens the separate Bot Mode messenger workspace; never changes drawer filters. */
|
||||
onOpenBotMode: (() -> Unit)? = null,
|
||||
onNewChat: () -> Unit,
|
||||
onNewDefaultChat: (() -> Unit)? = null,
|
||||
onSelectSession: (String) -> Unit,
|
||||
onDeleteSession: (String) -> Unit,
|
||||
onRenameSession: (String, String) -> Unit,
|
||||
@@ -535,13 +534,7 @@ fun SessionDrawerContent(
|
||||
|
||||
// New Chat button
|
||||
Button(
|
||||
onClick = {
|
||||
if (showAllProfiles) {
|
||||
onNewDefaultChat?.invoke() ?: onNewChat()
|
||||
} else {
|
||||
onNewChat()
|
||||
}
|
||||
},
|
||||
onClick = onNewChat,
|
||||
modifier = Modifier.fillMaxWidth(),
|
||||
enabled = newChatEnabled,
|
||||
) {
|
||||
|
||||
@@ -2385,8 +2385,15 @@ fun ChatScreen(
|
||||
}
|
||||
val selectProfileFromShelf: (com.hermesandroid.relay.data.Profile?) -> Unit = { profile ->
|
||||
if (AgentDisplay.profileSessionKey(profile?.name) != selectedProfileKey) {
|
||||
connectionViewModel.selectProfile(profile)
|
||||
chatViewModel.activateGatewayProfile(profile)
|
||||
val profileName = profile?.name
|
||||
chatViewModel.selectProfileFromHeader(
|
||||
profileName = profileName,
|
||||
profile = profile,
|
||||
contextKey = AgentDisplay.profileContextKey(
|
||||
connectionId = activeConnection?.id,
|
||||
profileName = profileName,
|
||||
),
|
||||
)
|
||||
}
|
||||
}
|
||||
val hasLiveConversationSurface = messages.isNotEmpty() || isStreaming
|
||||
@@ -2469,25 +2476,6 @@ fun ChatScreen(
|
||||
scope.launch { drawerState.close() }
|
||||
}
|
||||
},
|
||||
onNewDefaultChat = {
|
||||
if (isProfileLocked) return@SessionDrawerContent
|
||||
val defaultProfile = agentProfiles.firstOrNull {
|
||||
it.name.equals("default", ignoreCase = true)
|
||||
} ?: com.hermesandroid.relay.data.Profile(
|
||||
name = "default",
|
||||
model = "",
|
||||
description = "Default",
|
||||
)
|
||||
val opened = chatViewModel.createProfileChat(
|
||||
profileName = "default",
|
||||
profile = defaultProfile,
|
||||
contextKey = AgentDisplay.profileContextKey(
|
||||
connectionId = activeConnection?.id,
|
||||
profileName = "default",
|
||||
),
|
||||
)
|
||||
if (opened) scope.launch { drawerState.close() }
|
||||
},
|
||||
onSelectSession = { sessionId ->
|
||||
chatViewModel.switchSession(sessionId)
|
||||
scope.launch { drawerState.close() }
|
||||
|
||||
@@ -37,6 +37,7 @@ import com.hermesandroid.relay.data.applyMessageReaction
|
||||
import com.hermesandroid.relay.data.parseChatQuotedPrompt
|
||||
import com.hermesandroid.relay.data.prepareTextTransportAttachments
|
||||
import com.hermesandroid.relay.data.Profile
|
||||
import com.hermesandroid.relay.data.SessionTransport
|
||||
import com.hermesandroid.relay.data.ProactiveInboxEntry
|
||||
import com.hermesandroid.relay.data.RealtimeConversationContextMessage
|
||||
import com.hermesandroid.relay.data.RealtimeTurnTrace
|
||||
@@ -660,6 +661,7 @@ class ChatViewModel : ViewModel() {
|
||||
|
||||
/** Callback to persist session ID — set by RelayApp */
|
||||
var onSessionChanged: ((String?) -> Unit)? = null
|
||||
var onFreshDraftSelected: ((String?, SessionTransport) -> Unit)? = null
|
||||
|
||||
/**
|
||||
* Send a user message into an agent **Thread** (a `source=phone` session)
|
||||
@@ -678,6 +680,7 @@ class ChatViewModel : ViewModel() {
|
||||
*/
|
||||
private data class PendingThread(val chatId: String, val name: String)
|
||||
private var pendingThread: PendingThread? = null
|
||||
private val threadNavigationGeneration = AtomicLong(0L)
|
||||
|
||||
/**
|
||||
* A "+ New Thread" whose first message has been sent — we're now polling for
|
||||
@@ -693,6 +696,17 @@ class ChatViewModel : ViewModel() {
|
||||
)
|
||||
private var creatingThread: CreatingThread? = null
|
||||
|
||||
/**
|
||||
* Provisional phone Threads are route-owned drafts, not transferable chat
|
||||
* drafts. Leaving that surface retires only the pending local route; durable
|
||||
* inbox/session rows and learned session-to-chat-id mappings stay intact.
|
||||
*/
|
||||
private fun exitProvisionalThread() {
|
||||
threadNavigationGeneration.incrementAndGet()
|
||||
pendingThread = null
|
||||
creatingThread = null
|
||||
}
|
||||
|
||||
/**
|
||||
* `sessionId` → phone-platform `chat_id`, learned for threads this app
|
||||
* created ([switchToCreatedThread]) or received a message in
|
||||
@@ -4208,6 +4222,7 @@ class ChatViewModel : ViewModel() {
|
||||
sessionRefreshJob?.cancel()
|
||||
_isLoadingSessions.value = false
|
||||
conversationBindingController.reset()
|
||||
exitProvisionalThread()
|
||||
relayCapabilityGeneration.incrementAndGet()
|
||||
relayReasoningCapabilities.value = emptyMap()
|
||||
_reasoningCapabilityRevision.value += 1L
|
||||
@@ -4255,6 +4270,7 @@ class ChatViewModel : ViewModel() {
|
||||
sessionId: String,
|
||||
): Boolean {
|
||||
if (!selectConversationProfile(profileName, profile)) return false
|
||||
exitProvisionalThread()
|
||||
// Detach the old live gateway session without reading launch/global
|
||||
// model options: session.info for the resumed owner is authoritative.
|
||||
activateGatewayProfile(profile, refreshModelOptions = false)
|
||||
@@ -4264,6 +4280,7 @@ class ChatViewModel : ViewModel() {
|
||||
sessionId = sessionId,
|
||||
explicitProfileName = profileName,
|
||||
explicitDisplayProfile = profile,
|
||||
explicitBinding = true,
|
||||
)
|
||||
return true
|
||||
}
|
||||
@@ -4274,11 +4291,15 @@ class ChatViewModel : ViewModel() {
|
||||
* `default` profile wins over the server's sticky active profile everywhere.
|
||||
*/
|
||||
fun createProfileChat(
|
||||
profileName: String,
|
||||
profileName: String?,
|
||||
profile: Profile?,
|
||||
contextKey: String,
|
||||
): Boolean {
|
||||
if (!selectConversationProfile(profileName, profile)) return false
|
||||
// A provisional phone Thread belongs to its original connection/chat_id
|
||||
// and cannot transfer to another profile. Exit it before binding or
|
||||
// persisting the destination draft so the next send uses session.create.
|
||||
exitProvisionalThread()
|
||||
activateGatewayProfile(profile, refreshModelOptions = false)
|
||||
refreshActiveAgentName(profile, relabelGenericMessages = true)
|
||||
switchProfileContextInternal(
|
||||
@@ -4286,11 +4307,49 @@ class ChatViewModel : ViewModel() {
|
||||
sessionId = null,
|
||||
explicitProfileName = profileName,
|
||||
explicitDisplayProfile = profile,
|
||||
explicitBinding = true,
|
||||
)
|
||||
// Selection has already moved persistence to the target profile, so
|
||||
// clear that profile/transport's stored last-session slot as part of
|
||||
// the same draft transfer. A restart must reopen the draft, not the
|
||||
// target profile's previous conversation.
|
||||
persistFreshDraft(profileName)
|
||||
AppAnalytics.onSessionCreated()
|
||||
return true
|
||||
}
|
||||
|
||||
/**
|
||||
* Atomic owner switch for the Chat header.
|
||||
*
|
||||
* Empty ordinary drafts and provisional phone Threads both become a fresh
|
||||
* destination-profile draft, but only after provisional routing is retired.
|
||||
* Durable sessions keep the established profile-selection lifecycle, whose
|
||||
* binder may restore the destination profile's compatible last session.
|
||||
*/
|
||||
fun selectProfileFromHeader(
|
||||
profileName: String?,
|
||||
profile: Profile?,
|
||||
contextKey: String,
|
||||
): Boolean {
|
||||
val handler = chatHandler ?: return false
|
||||
val currentSessionId = handler.currentSessionId.value
|
||||
val activeSession = handler.sessions.value.firstOrNull {
|
||||
it.sessionId == currentSessionId
|
||||
}
|
||||
if (currentSessionId == null || activeSession?.source == "phone") {
|
||||
return createProfileChat(profileName, profile, contextKey)
|
||||
}
|
||||
if (!selectConversationProfile(profileName, profile)) return false
|
||||
exitProvisionalThread()
|
||||
activateGatewayProfile(profile)
|
||||
return true
|
||||
}
|
||||
|
||||
private fun persistFreshDraft(profileName: String?) {
|
||||
val transport = SessionTransport.forEndpoint(streamingEndpoint)
|
||||
onFreshDraftSelected?.invoke(profileName, transport) ?: onSessionChanged?.invoke(null)
|
||||
}
|
||||
|
||||
fun switchProfileContext(contextKey: String, sessionId: String?) {
|
||||
clearOpenedSessionOwner()
|
||||
switchProfileContextInternal(contextKey, sessionId)
|
||||
@@ -4313,14 +4372,19 @@ class ChatViewModel : ViewModel() {
|
||||
sessionId: String?,
|
||||
explicitProfileName: String? = null,
|
||||
explicitDisplayProfile: Profile? = null,
|
||||
explicitBinding: Boolean = false,
|
||||
reconciliation: Boolean = false,
|
||||
) {
|
||||
val handler = chatHandler ?: return
|
||||
dismissChatFailure()
|
||||
val previousBinding = conversationBinding.value
|
||||
val isInitialContextBinding = !previousBinding.isBound
|
||||
val targetProfileName = explicitProfileName ?: sessionProfileNameProvider()
|
||||
if (explicitProfileName != null) {
|
||||
val targetProfileName = if (explicitBinding) {
|
||||
explicitProfileName
|
||||
} else {
|
||||
sessionProfileNameProvider()
|
||||
}
|
||||
if (explicitBinding) {
|
||||
val accepted = conversationBindingController.openExplicit(
|
||||
contextKey = contextKey,
|
||||
profileName = explicitProfileName,
|
||||
@@ -4678,9 +4742,12 @@ class ChatViewModel : ViewModel() {
|
||||
if (supervisedModePolicy.enabled && !supervisedModePolicy.capabilities.newChat) return
|
||||
val handler = chatHandler ?: return
|
||||
recordPreResetEvidence(handler, "new_chat")
|
||||
clearOpenedSessionOwner()
|
||||
pendingThread = null
|
||||
creatingThread = null
|
||||
// A new chat clears only the durable session identity. Keep the bound
|
||||
// profile/context so an All Profiles conversation becomes a fresh
|
||||
// draft for that same owner instead of falling back to the globally
|
||||
// restored default profile.
|
||||
conversationBindingController.startFreshDraft()
|
||||
exitProvisionalThread()
|
||||
|
||||
// Gateway turns continue as detached siblings; SSE remains exclusive.
|
||||
releaseTurnForNavigation(handler)
|
||||
@@ -4710,7 +4777,7 @@ class ChatViewModel : ViewModel() {
|
||||
_fastEnabled.value = null
|
||||
approvalModeRevision.incrementAndGet()
|
||||
pendingYolo = null
|
||||
onSessionChanged?.invoke(null)
|
||||
persistFreshDraft(currentSessionProfileName())
|
||||
AppAnalytics.onSessionCreated()
|
||||
onReady?.invoke(null)
|
||||
return
|
||||
@@ -4780,6 +4847,7 @@ class ChatViewModel : ViewModel() {
|
||||
*/
|
||||
fun startNewThread(name: String) {
|
||||
val handler = chatHandler ?: return
|
||||
exitProvisionalThread()
|
||||
recordPreResetEvidence(handler, "new_thread")
|
||||
releaseTurnForNavigation(handler)
|
||||
cancelAnswerRecovery(settleUi = false)
|
||||
@@ -4816,6 +4884,7 @@ class ChatViewModel : ViewModel() {
|
||||
.sortedBy { it.receivedAt }
|
||||
if (ordered.isEmpty()) return
|
||||
|
||||
exitProvisionalThread()
|
||||
recordPreResetEvidence(handler, "open_proactive_thread")
|
||||
|
||||
releaseTurnForNavigation(handler)
|
||||
@@ -4825,7 +4894,6 @@ class ChatViewModel : ViewModel() {
|
||||
chatId = normalizedChatId,
|
||||
name = ordered.last().title.ifBlank { "Hermes" },
|
||||
)
|
||||
creatingThread = null
|
||||
gatewayClient?.clearSession()
|
||||
handler.setSessionId(null)
|
||||
selectBackgroundProcessSession(null)
|
||||
@@ -4878,11 +4946,20 @@ class ChatViewModel : ViewModel() {
|
||||
*/
|
||||
private fun switchToCreatedThread() {
|
||||
val creating = creatingThread ?: return
|
||||
val generation = threadNavigationGeneration.get()
|
||||
viewModelScope.launch {
|
||||
for (delayMs in longArrayOf(900L, 1300L, 1800L, 2500L, 3500L, 4500L)) {
|
||||
delay(delayMs)
|
||||
if (
|
||||
threadNavigationGeneration.get() != generation ||
|
||||
creatingThread != creating
|
||||
) return@launch
|
||||
refreshSessions()
|
||||
delay(400L) // let the refresh job land in the sessions flow
|
||||
if (
|
||||
threadNavigationGeneration.get() != generation ||
|
||||
creatingThread != creating
|
||||
) return@launch
|
||||
val match = chatHandler?.sessions?.value?.firstOrNull {
|
||||
it.source == "phone" && it.sessionId !in creating.knownIds
|
||||
}
|
||||
@@ -4912,8 +4989,7 @@ class ChatViewModel : ViewModel() {
|
||||
val handler = chatHandler ?: return
|
||||
dismissChatFailure()
|
||||
if (streamingEndpoint != "gateway" && apiClient == null) return
|
||||
pendingThread = null
|
||||
creatingThread = null
|
||||
exitProvisionalThread()
|
||||
|
||||
// Keep a Gateway sibling alive and detach its callbacks. SSE remains a
|
||||
// single exclusive stream and is interrupted on navigation.
|
||||
|
||||
@@ -6884,6 +6884,7 @@ class ConnectionViewModel(application: Application) : AndroidViewModel(applicati
|
||||
// ground truth about which transport can resume it, robust to a
|
||||
// turn that fell back from gateway to SSE.
|
||||
val transport = SessionTransport.forSessionId(sessionId)
|
||||
profileController.markSessionPersisted(connectionId, profileName, transport)
|
||||
profileController.profileSessionStore.setSessionId(
|
||||
connectionId,
|
||||
profileName,
|
||||
@@ -6920,6 +6921,20 @@ class ConnectionViewModel(application: Application) : AndroidViewModel(applicati
|
||||
}
|
||||
}
|
||||
|
||||
/** Persist an intentional empty draft without conflating it with transient null state. */
|
||||
fun saveFreshDraft(profileName: String?, transport: SessionTransport) {
|
||||
_lastSessionId.value = null
|
||||
val connectionId = activeConnectionId.value ?: return
|
||||
profileController.markFreshDraft(connectionId, profileName, transport)
|
||||
if (profileName == null) {
|
||||
viewModelScope.launch {
|
||||
getApplication<Application>().relayDataStore.edit { preferences ->
|
||||
preferences.remove(KEY_LAST_SESSION_ID)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// --- Shared methods ---
|
||||
|
||||
fun setTheme(theme: String) {
|
||||
|
||||
+12
@@ -102,6 +102,18 @@ internal class ConversationBindingController {
|
||||
)
|
||||
}
|
||||
|
||||
/** A user-requested draft keeps its owner and fences persisted-session reconciliation. */
|
||||
fun startFreshDraft() {
|
||||
val current = _state.value
|
||||
if (!current.isBound) return
|
||||
if (current.sessionId == null && current.hasExplicitOwner) return
|
||||
_state.value = current.copy(
|
||||
sessionId = null,
|
||||
origin = ConversationBindingOrigin.ExplicitSession,
|
||||
revision = current.revision + 1,
|
||||
)
|
||||
}
|
||||
|
||||
fun releaseExplicitOwner() {
|
||||
if (!_state.value.hasExplicitOwner) return
|
||||
reset()
|
||||
|
||||
@@ -155,6 +155,14 @@ class ProfileController(
|
||||
private val avatarRefreshGeneration = AtomicLong(0L)
|
||||
private val petRefreshGeneration = AtomicLong(0L)
|
||||
private val petGalleryGeneration = AtomicLong(0L)
|
||||
private val sessionRestoreGeneration = AtomicLong(0L)
|
||||
private val freshDraftScopes = ConcurrentHashMap.newKeySet<SessionScopeKey>()
|
||||
|
||||
private data class SessionScopeKey(
|
||||
val connectionId: String,
|
||||
val profileName: String?,
|
||||
val transport: SessionTransport,
|
||||
)
|
||||
private val petThumbnailRequests = ConcurrentHashMap.newKeySet<String>()
|
||||
|
||||
val agentProfiles: StateFlow<List<Profile>> = combine(
|
||||
@@ -1463,10 +1471,48 @@ class ProfileController(
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Persist a user-requested empty draft for one exact conversation scope.
|
||||
*
|
||||
* The in-memory marker fences any stored-session read that was already in
|
||||
* flight, while clearing the exact transport slot makes the draft survive a
|
||||
* process restart. Other profiles, connections, transports, and the server's
|
||||
* actual session/history rows are untouched.
|
||||
*/
|
||||
fun markFreshDraft(
|
||||
connectionId: String,
|
||||
profileName: String?,
|
||||
transport: SessionTransport,
|
||||
) {
|
||||
val scopeKey = SessionScopeKey(connectionId, profileName, transport)
|
||||
freshDraftScopes += scopeKey
|
||||
sessionRestoreGeneration.incrementAndGet()
|
||||
if (
|
||||
activeConnectionId.value == connectionId &&
|
||||
_selectedProfile.value?.name == profileName
|
||||
) {
|
||||
setLastSessionId(null)
|
||||
}
|
||||
scope.launch {
|
||||
profileSessionStore.setSessionId(connectionId, profileName, transport, null)
|
||||
}
|
||||
}
|
||||
|
||||
/** A real session supersedes the fresh-draft marker for its exact scope. */
|
||||
fun markSessionPersisted(
|
||||
connectionId: String,
|
||||
profileName: String?,
|
||||
transport: SessionTransport,
|
||||
) {
|
||||
freshDraftScopes -= SessionScopeKey(connectionId, profileName, transport)
|
||||
sessionRestoreGeneration.incrementAndGet()
|
||||
}
|
||||
|
||||
fun refreshLastSessionForProfile(
|
||||
connectionId: String?,
|
||||
profileName: String?,
|
||||
) {
|
||||
val generation = sessionRestoreGeneration.incrementAndGet()
|
||||
setLastSessionId(null)
|
||||
if (connectionId == null) return
|
||||
// Defer until the active transport is known — restoring an id the
|
||||
@@ -1478,6 +1524,8 @@ class ProfileController(
|
||||
// `default` (or any other name), but its last-session slot must remain
|
||||
// distinct from explicitly selecting that named profile.
|
||||
val sessionProfileName = profileName
|
||||
val scopeKey = SessionScopeKey(connectionId, sessionProfileName, transport)
|
||||
if (scopeKey in freshDraftScopes) return
|
||||
scope.launch {
|
||||
val profileScoped = profileSessionStore
|
||||
.sessionIdFlow(connectionId, sessionProfileName, transport)
|
||||
@@ -1493,6 +1541,8 @@ class ProfileController(
|
||||
null
|
||||
}
|
||||
if (
|
||||
sessionRestoreGeneration.get() == generation &&
|
||||
scopeKey !in freshDraftScopes &&
|
||||
activeConnectionId.value == connectionId &&
|
||||
_selectedProfile.value?.name == profileName &&
|
||||
activeSessionTransport() == transport
|
||||
|
||||
@@ -17,7 +17,8 @@ import kotlinx.coroutines.sync.withLock
|
||||
|
||||
class ProfileSessionStoreTest {
|
||||
|
||||
private val store = ProfileSessionStore(InMemoryPreferencesDataStore())
|
||||
private val dataStore = InMemoryPreferencesDataStore()
|
||||
private val store = ProfileSessionStore(dataStore)
|
||||
|
||||
@Test
|
||||
fun setAndGet_defaultProfileSession() = runBlocking {
|
||||
@@ -85,6 +86,26 @@ class ProfileSessionStoreTest {
|
||||
assertEquals("session-sse", store.sessionIdFlow("conn-1", "mizu", SSE).first())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun clearedDraftSurvivesStoreRecreationAndPreservesOtherScopes() = runBlocking {
|
||||
store.setSessionId("conn-1", "mizu", GATEWAY, "session-gw")
|
||||
store.setSessionId("conn-1", "mizu", SSE, "session-sse")
|
||||
store.setSessionId("conn-2", "mizu", GATEWAY, "session-other")
|
||||
|
||||
store.setSessionId("conn-1", "mizu", GATEWAY, null)
|
||||
val restartedStore = ProfileSessionStore(dataStore)
|
||||
|
||||
assertNull(restartedStore.sessionIdFlow("conn-1", "mizu", GATEWAY).first())
|
||||
assertEquals(
|
||||
"session-sse",
|
||||
restartedStore.sessionIdFlow("conn-1", "mizu", SSE).first(),
|
||||
)
|
||||
assertEquals(
|
||||
"session-other",
|
||||
restartedStore.sessionIdFlow("conn-2", "mizu", GATEWAY).first(),
|
||||
)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun clearConnectionRemovesAllProfilesAndTransportsForThatConnectionOnly() = runBlocking {
|
||||
store.setSessionId("conn-1", null, GATEWAY, "session-default")
|
||||
|
||||
@@ -304,9 +304,8 @@ class SessionDrawerTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
fun `new chat from all profiles requests an explicit default draft`() {
|
||||
fun `new chat from all profiles keeps the current conversation owner`() {
|
||||
var scopedNewChats = 0
|
||||
var defaultNewChats = 0
|
||||
compose.setContent {
|
||||
MaterialTheme {
|
||||
SessionDrawerContent(
|
||||
@@ -319,7 +318,6 @@ class SessionDrawerTest {
|
||||
onRefreshAllProfiles = {},
|
||||
onSelectProfileSession = { _, _ -> },
|
||||
onNewChat = { scopedNewChats++ },
|
||||
onNewDefaultChat = { defaultNewChats++ },
|
||||
onSelectSession = {},
|
||||
onDeleteSession = {},
|
||||
onRenameSession = { _, _ -> },
|
||||
@@ -332,8 +330,7 @@ class SessionDrawerTest {
|
||||
compose.onNodeWithText("New Chat").performClick()
|
||||
|
||||
compose.runOnIdle {
|
||||
assertEquals(0, scopedNewChats)
|
||||
assertEquals(1, defaultNewChats)
|
||||
assertEquals(1, scopedNewChats)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
+266
-3
@@ -14,9 +14,12 @@ import com.hermesandroid.relay.data.ChatTurnUserCheckpoint
|
||||
import com.hermesandroid.relay.data.HermesCardDispatch
|
||||
import com.hermesandroid.relay.data.MessageRole
|
||||
import com.hermesandroid.relay.data.Profile
|
||||
import com.hermesandroid.relay.data.ProactiveInboxEntry
|
||||
import com.hermesandroid.relay.data.SessionTransport
|
||||
import com.hermesandroid.relay.data.SessionActivityState
|
||||
import com.hermesandroid.relay.diagnostics.DiagnosticCategory
|
||||
import com.hermesandroid.relay.diagnostics.DiagnosticsLog
|
||||
import com.hermesandroid.relay.network.relay.ProactiveMessage
|
||||
import com.hermesandroid.relay.network.upstream.ChatHandler
|
||||
import com.hermesandroid.relay.network.upstream.DashboardApiClient
|
||||
import com.hermesandroid.relay.network.upstream.GatewayChatClient
|
||||
@@ -431,8 +434,17 @@ class ChatViewModelGatewayInboundTurnTest {
|
||||
assertEquals(owner.name, viewModel.conversationBinding.value.profileName)
|
||||
|
||||
viewModel.createNewChat()
|
||||
assertFalse(viewModel.conversationBinding.value.hasExplicitOwner)
|
||||
assertEquals(global.name, gatewayClient.sessionProfileProvider())
|
||||
assertTrue(viewModel.conversationBinding.value.hasExplicitOwner)
|
||||
assertEquals(owner.name, viewModel.conversationBinding.value.profileName)
|
||||
assertNull(viewModel.conversationBinding.value.sessionId)
|
||||
assertEquals(owner.name, gatewayClient.sessionProfileProvider())
|
||||
|
||||
viewModel.reconcileProfileContext(
|
||||
AgentDisplay.profileContextKey("connection-a", owner.name),
|
||||
sessionId = "x-bot-session",
|
||||
)
|
||||
assertNull(viewModel.conversationBinding.value.sessionId)
|
||||
assertNull(handler.currentSessionId.value)
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -647,7 +659,258 @@ class ChatViewModelGatewayInboundTurnTest {
|
||||
assertEquals("default", gatewayClient.sessionProfileProvider())
|
||||
assertEquals(null, handler.currentSessionId.value)
|
||||
assertEquals("Hermes", handler.activeAgentName)
|
||||
assertEquals("unchanged", persistedSession)
|
||||
assertEquals("cleared", persistedSession)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun freshDraftTransferKeepsNullableServerDefaultAndRejectsOldSessionRestore() {
|
||||
val named = Profile(name = "x-bot", model = "grok-4.3", description = "X Bot")
|
||||
var selected: Profile? = named
|
||||
var persistedDraft: Pair<String?, SessionTransport>? = null
|
||||
viewModel.setSelectedProfileProvider { selected }
|
||||
viewModel.setSessionProfileNameProvider { selected?.name }
|
||||
viewModel.setProfileSelectionHandler { profile ->
|
||||
selected = profile
|
||||
true
|
||||
}
|
||||
viewModel.onFreshDraftSelected = { profileName, transport ->
|
||||
persistedDraft = profileName to transport
|
||||
}
|
||||
|
||||
assertTrue(
|
||||
viewModel.createProfileChat(
|
||||
profileName = null,
|
||||
profile = null,
|
||||
contextKey = AgentDisplay.profileContextKey("connection-a", null),
|
||||
),
|
||||
)
|
||||
|
||||
assertNull(selected)
|
||||
assertTrue(viewModel.conversationBinding.value.hasExplicitOwner)
|
||||
assertNull(viewModel.conversationBinding.value.profileName)
|
||||
assertNull(viewModel.conversationBinding.value.sessionId)
|
||||
assertEquals(null to SessionTransport.GATEWAY, persistedDraft)
|
||||
assertNull(gatewayClient.sessionProfileProvider())
|
||||
|
||||
viewModel.reconcileProfileContext(
|
||||
AgentDisplay.profileContextKey("connection-a", null),
|
||||
sessionId = "old-default-session",
|
||||
)
|
||||
assertNull(viewModel.conversationBinding.value.sessionId)
|
||||
assertNull(handler.currentSessionId.value)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun freshDraftTransferToNamedProfileCreatesInsteadOfResumingItsOldSession() {
|
||||
val alpha = Profile(name = "alpha", model = "model-a", description = "Alpha")
|
||||
val beta = Profile(name = "beta", model = "model-b", description = "Beta")
|
||||
var selected: Profile? = alpha
|
||||
var persistedDraft: Pair<String?, SessionTransport>? = null
|
||||
viewModel.setSelectedProfileProvider { selected }
|
||||
viewModel.setSessionProfileNameProvider { selected?.name }
|
||||
viewModel.setProfileSelectionHandler { profile ->
|
||||
selected = profile
|
||||
true
|
||||
}
|
||||
viewModel.onFreshDraftSelected = { profileName, transport ->
|
||||
persistedDraft = profileName to transport
|
||||
}
|
||||
|
||||
viewModel.openProfileSession(
|
||||
profileName = alpha.name,
|
||||
profile = alpha,
|
||||
contextKey = AgentDisplay.profileContextKey("connection-a", alpha.name),
|
||||
sessionId = "alpha-session",
|
||||
)
|
||||
viewModel.createNewChat()
|
||||
assertTrue(
|
||||
viewModel.selectProfileFromHeader(
|
||||
profileName = beta.name,
|
||||
profile = beta,
|
||||
contextKey = AgentDisplay.profileContextKey("connection-a", beta.name),
|
||||
),
|
||||
)
|
||||
|
||||
assertEquals(beta, selected)
|
||||
assertEquals(beta.name to SessionTransport.GATEWAY, persistedDraft)
|
||||
viewModel.reconcileProfileContext(
|
||||
AgentDisplay.profileContextKey("connection-a", beta.name),
|
||||
sessionId = "beta-old-session",
|
||||
)
|
||||
assertNull(handler.currentSessionId.value)
|
||||
|
||||
gatewayHarness.createdSessionProfileName = beta.name
|
||||
val resumeCountBeforeFreshSend = gatewayHarness.rpcLog.count {
|
||||
it.first == "session.resume"
|
||||
}
|
||||
viewModel.sendMessage("Fresh beta turn")
|
||||
val create = gatewayHarness.awaitRpc("session.create")
|
||||
assertEquals(beta.name, (create["profile"] as JsonPrimitive).content)
|
||||
assertEquals(
|
||||
resumeCountBeforeFreshSend,
|
||||
gatewayHarness.rpcLog.count { it.first == "session.resume" },
|
||||
)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun headerProfileSwitchExitsProvisionalThreadBeforeFreshProfileSend() {
|
||||
val alpha = Profile(name = "alpha", model = "model-a", description = "Alpha")
|
||||
val beta = Profile(name = "beta", model = "model-b", description = "Beta")
|
||||
var selected: Profile? = alpha
|
||||
val proactiveChatIds = mutableListOf<String?>()
|
||||
viewModel.setSelectedProfileProvider { selected }
|
||||
viewModel.setSessionProfileNameProvider { selected?.name }
|
||||
viewModel.setProfileSelectionHandler { profile ->
|
||||
selected = profile
|
||||
true
|
||||
}
|
||||
viewModel.onProactiveReply = { _, chatId, _, _ -> proactiveChatIds += chatId }
|
||||
|
||||
viewModel.openProactiveThread(
|
||||
chatId = "old-phone-chat",
|
||||
entries = listOf(
|
||||
ProactiveInboxEntry(
|
||||
id = "inbox-1",
|
||||
title = "Old phone thread",
|
||||
text = "Continue here",
|
||||
receivedAt = 1L,
|
||||
chatId = "old-phone-chat",
|
||||
connectionId = "connection-a",
|
||||
),
|
||||
),
|
||||
)
|
||||
assertNull(handler.currentSessionId.value)
|
||||
|
||||
assertTrue(
|
||||
viewModel.selectProfileFromHeader(
|
||||
profileName = beta.name,
|
||||
profile = beta,
|
||||
contextKey = AgentDisplay.profileContextKey("connection-a", beta.name),
|
||||
),
|
||||
)
|
||||
viewModel.sendMessage("Fresh beta turn")
|
||||
|
||||
val create = gatewayHarness.awaitRpc("session.create")
|
||||
assertEquals(beta.name, (create["profile"] as JsonPrimitive).content)
|
||||
assertTrue(proactiveChatIds.isEmpty())
|
||||
assertEquals(beta.name, viewModel.conversationBinding.value.profileName)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun headerProfileSwitchExitsPromotedPhoneSessionWithoutReusingItsChatId() {
|
||||
val alpha = Profile(name = "alpha", model = "model-a", description = "Alpha")
|
||||
val beta = Profile(name = "beta", model = "model-b", description = "Beta")
|
||||
var selected: Profile? = alpha
|
||||
val proactiveChatIds = mutableListOf<String?>()
|
||||
viewModel.setSelectedProfileProvider { selected }
|
||||
viewModel.setSessionProfileNameProvider { selected?.name }
|
||||
viewModel.setProfileSelectionHandler { profile ->
|
||||
selected = profile
|
||||
true
|
||||
}
|
||||
viewModel.onProactiveReply = { _, chatId, _, _ -> proactiveChatIds += chatId }
|
||||
handler.addSession(
|
||||
com.hermesandroid.relay.data.ChatSession(
|
||||
sessionId = "promoted-phone-session",
|
||||
title = "Promoted thread",
|
||||
model = null,
|
||||
source = "phone",
|
||||
),
|
||||
)
|
||||
handler.setSessionId("promoted-phone-session")
|
||||
|
||||
assertTrue(
|
||||
viewModel.selectProfileFromHeader(
|
||||
profileName = beta.name,
|
||||
profile = beta,
|
||||
contextKey = AgentDisplay.profileContextKey("connection-a", beta.name),
|
||||
),
|
||||
)
|
||||
assertNull(handler.currentSessionId.value)
|
||||
viewModel.sendMessage("Fresh beta after Thread")
|
||||
|
||||
val create = gatewayHarness.awaitRpc("session.create")
|
||||
assertEquals(beta.name, (create["profile"] as JsonPrimitive).content)
|
||||
assertTrue(proactiveChatIds.isEmpty())
|
||||
}
|
||||
|
||||
@Test
|
||||
fun newChatAndConnectionSwitchRetireProvisionalThreadRouting() {
|
||||
val entry = ProactiveInboxEntry(
|
||||
id = "inbox-1",
|
||||
title = "Old phone thread",
|
||||
text = "Continue here",
|
||||
receivedAt = 1L,
|
||||
chatId = "old-phone-chat",
|
||||
connectionId = "connection-a",
|
||||
)
|
||||
val inbound = ProactiveMessage(
|
||||
messageId = "late-1",
|
||||
chatId = "old-phone-chat",
|
||||
text = "Late old-thread message",
|
||||
title = "Old phone thread",
|
||||
surfacing = "thread",
|
||||
sentAt = 2L,
|
||||
)
|
||||
|
||||
viewModel.openProactiveThread("old-phone-chat", listOf(entry))
|
||||
viewModel.createNewChat()
|
||||
assertFalse(viewModel.injectThreadMessage(inbound))
|
||||
|
||||
val switches = MutableSharedFlow<String>(extraBufferCapacity = 1)
|
||||
viewModel.observeConnectionSwitches(switches)
|
||||
viewModel.openProactiveThread("old-phone-chat", listOf(entry))
|
||||
switches.tryEmit("connection-b")
|
||||
awaitCondition { handler.messages.value.isEmpty() }
|
||||
assertFalse(viewModel.injectThreadMessage(inbound))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun staleThreadPromotionCannotReplaceTransferredProfileDraft() {
|
||||
val beta = Profile(name = "beta", model = "model-b", description = "Beta")
|
||||
var selected: Profile? = Profile(name = "alpha", model = "model-a")
|
||||
viewModel.setSelectedProfileProvider { selected }
|
||||
viewModel.setSessionProfileNameProvider { selected?.name }
|
||||
viewModel.setProfileSelectionHandler { profile ->
|
||||
selected = profile
|
||||
true
|
||||
}
|
||||
viewModel.onProactiveReply = { _, _, _, _ -> }
|
||||
viewModel.openProactiveThread(
|
||||
"old-phone-chat",
|
||||
listOf(
|
||||
ProactiveInboxEntry(
|
||||
id = "inbox-1",
|
||||
title = "Old phone thread",
|
||||
text = "Continue here",
|
||||
receivedAt = 1L,
|
||||
chatId = "old-phone-chat",
|
||||
connectionId = "connection-a",
|
||||
),
|
||||
),
|
||||
)
|
||||
viewModel.sendMessage("Promote the old Thread")
|
||||
|
||||
assertTrue(
|
||||
viewModel.selectProfileFromHeader(
|
||||
profileName = beta.name,
|
||||
profile = beta,
|
||||
contextKey = AgentDisplay.profileContextKey("connection-a", beta.name),
|
||||
),
|
||||
)
|
||||
handler.addSession(
|
||||
com.hermesandroid.relay.data.ChatSession(
|
||||
sessionId = "late-promoted-thread",
|
||||
title = "Late promoted thread",
|
||||
model = null,
|
||||
source = "phone",
|
||||
),
|
||||
)
|
||||
shadowOf(Looper.getMainLooper()).idleFor(2, TimeUnit.SECONDS)
|
||||
Thread.sleep(100)
|
||||
|
||||
assertNull(handler.currentSessionId.value)
|
||||
assertEquals(beta.name, viewModel.conversationBinding.value.profileName)
|
||||
}
|
||||
|
||||
@Test
|
||||
|
||||
+27
@@ -58,6 +58,33 @@ class ConversationBindingControllerTest {
|
||||
assertEquals("a2", controller.state.value.sessionId)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun newDraftKeepsExplicitAllProfilesOwnerAndRejectsStaleRestore() {
|
||||
val alpha = Profile("alpha", "model-a", "Alpha")
|
||||
controller.openExplicit("c::alpha", alpha.name, "a1", alpha, null)
|
||||
|
||||
controller.startFreshDraft()
|
||||
|
||||
assertEquals("c::alpha", controller.state.value.contextKey)
|
||||
assertEquals("alpha", controller.state.value.profileName)
|
||||
assertNull(controller.state.value.sessionId)
|
||||
assertEquals(alpha, controller.state.value.displayProfile)
|
||||
assertTrue(controller.state.value.hasExplicitOwner)
|
||||
assertFalse(controller.reconcileGlobal("c::alpha", "alpha", "a1"))
|
||||
assertNull(controller.state.value.sessionId)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun newDraftPromotesGlobalOwnerAndRejectsItsStoredSession() {
|
||||
controller.forceGlobal("c::alpha", "alpha", "a1")
|
||||
|
||||
controller.startFreshDraft()
|
||||
|
||||
assertTrue(controller.state.value.hasExplicitOwner)
|
||||
assertNull(controller.state.value.sessionId)
|
||||
assertFalse(controller.reconcileGlobal("c::alpha", "alpha", "a1"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun profileLockRejectsOtherOwnersAndAllowsTheLockedOwner() {
|
||||
val locked = AgentDisplay.profileSessionKey("beta")
|
||||
|
||||
+39
@@ -4,6 +4,7 @@ import android.content.Context
|
||||
import com.hermesandroid.relay.auth.AuthManager
|
||||
import com.hermesandroid.relay.data.AgentDisplay
|
||||
import com.hermesandroid.relay.data.Profile
|
||||
import com.hermesandroid.relay.data.SessionTransport
|
||||
import com.hermesandroid.relay.network.upstream.DashboardApiClient
|
||||
import com.hermesandroid.relay.network.upstream.DashboardProfileScope
|
||||
import com.hermesandroid.relay.network.upstream.GatewayAvailability
|
||||
@@ -366,4 +367,42 @@ class ProfileControllerLockTest {
|
||||
controller.selectProfile(coder)
|
||||
assertEquals(coder, controller.selectedProfile.value)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun freshDraftFencesRestoreAndClearsOnlyItsConnectionProfileTransport() = runBlocking {
|
||||
val sessions = controller.profileSessionStore
|
||||
sessions.setSessionId(connectionId, mizu.name, SessionTransport.SSE, "old-sse")
|
||||
sessions.setSessionId(connectionId, mizu.name, SessionTransport.GATEWAY, "old-gateway")
|
||||
sessions.setSessionId("other-connection", mizu.name, SessionTransport.SSE, "other-sse")
|
||||
controller.selectProfile(mizu)
|
||||
awaitSelected(mizu.name)
|
||||
|
||||
controller.markFreshDraft(connectionId, mizu.name, SessionTransport.SSE)
|
||||
withTimeout(5_000) {
|
||||
sessions.sessionIdFlow(connectionId, mizu.name, SessionTransport.SSE)
|
||||
.first { it == null }
|
||||
}
|
||||
|
||||
// Simulate an older read observing the pre-clear value: the live intent
|
||||
// fence still wins until a real session supersedes the draft.
|
||||
sessions.setSessionId(connectionId, mizu.name, SessionTransport.SSE, "stale-sse")
|
||||
controller.refreshLastSessionForProfile(connectionId, mizu.name)
|
||||
assertNull(lastSessionIds.last())
|
||||
|
||||
assertEquals(
|
||||
"old-gateway",
|
||||
sessions.sessionIdFlow(connectionId, mizu.name, SessionTransport.GATEWAY).first(),
|
||||
)
|
||||
assertEquals(
|
||||
"other-sse",
|
||||
sessions.sessionIdFlow("other-connection", mizu.name, SessionTransport.SSE).first(),
|
||||
)
|
||||
|
||||
controller.markSessionPersisted(connectionId, mizu.name, SessionTransport.SSE)
|
||||
sessions.setSessionId(connectionId, mizu.name, SessionTransport.SSE, "new-sse")
|
||||
controller.refreshLastSessionForProfile(connectionId, mizu.name)
|
||||
withTimeout(5_000) {
|
||||
while (lastSessionIds.lastOrNull() != "new-sse") Thread.sleep(10)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -2836,6 +2836,20 @@ session or starts a draft, never hot-swaps a live session. Model/provider,
|
||||
personality, reasoning, approval, Fast, and YOLO state reset at the ViewModel
|
||||
context boundary before destination session truth can repopulate them.
|
||||
|
||||
New Chat retains the current concrete conversation owner even when the drawer is
|
||||
browsing All Profiles. A profile choice made from that empty draft transfers an
|
||||
explicit fresh-draft intent rather than restoring the destination's previous
|
||||
session. Android persists and generation-fences that intent by exact
|
||||
connection/profile/transport; it clears only the resumable pointer, leaving the
|
||||
stored conversation, transcript, and per-owner composer drafts intact.
|
||||
|
||||
Phone Threads keep their connection/chat-id ownership when leaving that surface.
|
||||
They are never transferred into a different profile binding: the atomic header
|
||||
switch retires provisional or in-progress promotion state before creating the
|
||||
destination profile draft, while durable inbox rows, promoted sessions,
|
||||
notification ownership, and session-to-chat-id indexes remain untouched. A
|
||||
generation fence prevents a delayed promotion from replacing the new draft.
|
||||
|
||||
**Consequences.** The hamburger remains exclusively the Session Drawer. Agent
|
||||
Passport stays focused on inspection and configuration. The drawer may widen
|
||||
its read-only browse scope to all profiles and organize that combined set by
|
||||
|
||||
+1
-1
@@ -475,7 +475,7 @@ Bottom navigation bar with 4 tabs:
|
||||
- **Upstream animated pets** — the agent sheet consumes the profile-scoped Gateway `pet.info`, `pet.gallery`, `pet.select`, and `pet.disable` contracts. Android caches the bounded PNG/WebP sprite sheet by connection, effective profile, and `spritesheetRevision`; it sends `knownRevision` on refresh and reuses the existing bounded pet renderer for the returned geometry, row taxonomy, and activity states. The active upstream pet becomes the phone companion unless the user explicitly selected a phone-local floating pet. Selection and disable write Hermes `display.pet.*` state and therefore follow the profile across current Hermes surfaces; a method-not-found response leaves older hosts on the established local pet flow.
|
||||
- **Profile creation** — Manage uses `profiles.create` on current Gateways and labels authentication as shared sign-in, copied credential snapshot, or isolated/no-copy. Android serializes `mirror_credentials` and `share_auth` explicitly, reports best-effort SOUL/model/credential results without claiming full success, and never receives or logs credentials. The user may explicitly enable the authenticated Dashboard create route as an older-host fallback only for the legacy shared/default choice; explicit isolation never degrades to an ambiguous older mutation.
|
||||
- **Deletion boundary** — Hermes exposes no `profiles.delete` Gateway RPC. Android continues to delete profiles only through authenticated Dashboard `DELETE /api/profiles/{name}`.
|
||||
- **Profile switch lifecycle** — selecting an inactive profile never changes Hermes' sticky server default and never hot-swaps a live session. Android switches connection/profile context, restores that profile's last session only from the compatible Gateway or SSE transport slot, or opens a fresh draft. Gateway turns detach and reconcile in their original durable session; live SSE switching is disabled. Model/provider, personality, reasoning, approval, Fast, and YOLO state are cleared before destination session truth re-seeds them.
|
||||
- **Profile switch lifecycle** — selecting an inactive profile never changes Hermes' sticky server default and never hot-swaps a live session. Android switches connection/profile context, restores that profile's last session only from the compatible Gateway or SSE transport slot, or opens a fresh draft. New Chat from All Profiles keeps the current conversation owner, and selecting another profile while that draft is empty transfers fresh-draft intent to the destination instead of restoring its prior session. That intent is fenced and persisted by exact connection/profile/transport while the prior session and history remain available in the drawer. Provisional and promoted phone Threads are not transferable profile drafts: a header profile switch exits their local routing state before establishing the destination draft, preserves their durable inbox/session/index data, and generation-fences any pending promotion. Gateway turns detach and reconcile in their original durable session; live SSE switching is disabled. Model/provider, personality, reasoning, approval, Fast, and YOLO state are cleared before destination session truth re-seeds them.
|
||||
- **Bot Mode workspace** — the session drawer exposes one entry into a separate full-screen messenger surface; it does not add Bot or group rows to the ordinary session taxonomy. Android refreshes every saved Dashboard/Gateway with bounded concurrency, preserves last-good rows as visibly offline, and collapses duplicate routes by upstream `install_id` before assigning source-qualified handles. Every Bot carries an immutable `(connectionId, profile)` owner; labels, installation metadata, and the currently resolved URL are presentation/routing data rather than identity. All gateways and one-gateway filters never mutate the foreground connection.
|
||||
- **Canonical Bot Chat** — each individual row resolves the exact hidden session titled `Bot Chat` on its owning Gateway. Lookup failure is not absence, so Android creates and materializes the lazy row with `session.title` only after an authoritative empty exact-title result. The dedicated Bot Chat destination retains that route's pooled Gateway client, loads history through the same connection/profile Dashboard, sends only through Gateway, and returns directly to Bot Mode without rebinding Standard Chat or the global connection. `/new` or `/reset` compacts the canonical conversation instead of forking it. The route pool mints a fresh WebSocket ticket per dial, includes the immutable profile in the WebSocket URL, isolates credentials by exact trusted connection origin, and tears down only the removed connection's clients.
|
||||
- **Bot group projection** — Android merges the bounded `ui_meta["hermes-bots-groups"]` v3 projection across gateways by durable room identity and newest revision. Rooms and recent messages are visibly read-only; Android does not create, rename, disband, join, send, coordinate member turns, or become a second room-log authority. Binary room images are ignored at this metadata boundary.
|
||||
|
||||
Reference in New Issue
Block a user