Compare commits

..
Author SHA1 Message Date
Bailey Dixon 7a97b71844 docs: publish native git workspace references 2026-08-26 19:09:15 -04:00
Bailey Dixon ae51ae3ab1 Merge origin/dev into feature/native-git-workspace 2026-08-26 19:03:31 -04:00
Bailey Dixon 1bdcab8fc0 feat(android): add native git workspace surfaces 2026-08-26 19:03:21 -04:00
Bailey Dixon 0c77d010fa Merge pull request #454 from Codename-11/fix/android-smooth-sphere-motion
fix(android): keep visible sphere motion smooth
2026-08-26 18:51:23 -04:00
Bailey Dixon dc18209c3c fix(android): keep visible sphere motion smooth 2026-08-26 18:18:03 -04:00
Bailey Dixon 69347adb34 Merge pull request #445 from Codename-11/chore/reconcile-android-1.13.2
chore: reconcile Android 1.13.2 into dev
2026-08-25 21:36:11 -04:00
Bailey Dixon 43a809e41a chore: reconcile android-v1.13.2 into dev 2026-08-25 21:25:01 -04:00
Bailey Dixon a5cc0104bf Merge pull request #443 from Codename-11/fix/android-1.13.2-no-git
release(android): android-v1.13.2
2026-08-25 20:38:04 -04:00
Bailey Dixon d5cce4e390 Merge pull request #441 from Codename-11/fix/android-session-activity-fallback
fix(android): keep unknown session activity neutral
2026-08-25 19:41:41 -04:00
Bailey Dixon ae9b22a9e6 fix(android): keep unknown session activity neutral 2026-08-25 19:01:25 -04:00
Bailey Dixon 96a9e8077e Merge pull request #440 from Codename-11/chore/automate-hotfix-backmerge
feat(ci): automate conflict-free release backmerges
2026-08-25 17:12:49 -04:00
Bailey Dixon a97e6a2b14 chore: merge current dev into release backmerge automation 2026-08-25 16:53:13 -04:00
Bailey Dixon 4317da85fd Merge pull request #439 from Codename-11/fix/android-supervised-return-blank
fix(android): stabilize supervised parent relock
2026-08-25 16:24:42 -04:00
Bailey Dixon 45fde0ad9a feat(ci): automate conflict-free release backmerges 2026-08-25 16:21:14 -04:00
Bailey Dixon 94565e9d6d fix(android): stabilize supervised parent relock 2026-08-25 16:13:47 -04:00
Bailey Dixon 56c2e6fa07 Merge pull request #438 from Codename-11/chore/backmerge-android-1.13.1
chore: back-merge Android 1.13.1
2026-08-25 15:30:33 -04:00
Bailey Dixon 28629f3d93 chore: back-merge android 1.13.1 2026-08-25 15:18:32 -04:00
Bailey Dixon 0d1faf47a0 Merge pull request #435 from Codename-11/fix/git-state-audit
fix: harden Git state repository operations
2026-08-25 14:05:40 -04:00
Bailey Dixon 00288a2b3b test(git-state): cover links across platforms 2026-08-25 13:54:45 -04:00
Bailey Dixon 8f52feffba fix(git-state): harden repository operations 2026-08-25 13:51:10 -04:00
Bailey Dixon ee29e49361 Merge pull request #434 from Codename-11/fix/android-session-activity-truth
fix(android): make session activity authoritative
2026-08-25 12:37:31 -04:00
Bailey Dixon e2073b7692 chore: merge dev into session activity fix 2026-08-25 12:26:42 -04:00
Bailey Dixon 70b6d8ee5a Merge pull request #433 from mrvigneshvt/feat/git-state
feat: Git State — Hermex-parity repo management for host repos
2026-08-25 12:03:50 -04:00
Bailey Dixon 1f5e50ccd7 chore: merge dev into git-state 2026-08-25 11:51:44 -04:00
Bailey Dixon 5580c9d9bb Merge pull request #419 from Codename-11/feature/android-supervised-mode
feat(android): add supervised mode
2026-08-25 11:42:21 -04:00
Bailey Dixon 2ebdf55501 Merge branch 'dev' into feature/android-supervised-mode 2026-08-25 11:32:54 -04:00
mrvigneshvt ad107ea205 feat(git-state): add AI commit messages, stash-checkout, and push-after-commit
Commit-message generation reuses the upstream async LLM helper via the plugin's deferred-import pattern; empty staged diffs never call the model and failures degrade to an empty message plus notice. stash_checkout auto-stashes a dirty tree before switching (recoverable; stash surfaced as a notice). Push-after-commit toggle auto-starts the push confirmation flow without bypassing the confirmation token. Truncation caps consistent across all bounded endpoints. New UI strings localized across the 12-catalog parity gate.
2026-08-25 13:25:21 +00:00
mrvigneshvt f5aeb27e5a feat(git-state): add git write operations and Android write UI
POST endpoints for stage, unstage, discard, commit (selected paths supported), fetch, pull (--ff-only), push, and checkout with new-branch/track. Destructive ops enforce fixed per-use confirmation tokens (403 on missing or mismatched confirmation); the plugin.api.write grant gates writes client-side per the documented plugin contract; git failures classify into a structured taxonomy mapped to HTTP (409 dirty/conflict, 502 auth/network, 400 invalid). Android: commit dialog, branch picker with track, confirmation dialogs (standard AlertDialog pattern), grant-refusal notice, mutation progress/error rendering, 16 view-model tests. Dashboard: identically gated write controls. 56 endpoint/helper-level tests; deterministic fixtures.
2026-08-25 13:25:21 +00:00
mrvigneshvt fdaeb121d5 feat(git-state): add read-only git workspace browser (scan, status, branches, diff, file read)
Plugin endpoints under /api/plugins/hermes-relay/git/* backed by a scanned-repo allowlist with configurable base path; bounded responses with truncation flags; traversal-rejected file reads returning working-tree content with clear binary/non-UTF-8 errors; remote URLs scrubbed of userinfo; zero shell interpolation. Registers the Git mobile plugin page and a read-only dashboard tab; Android renders the surface via a dedicated Compose screen with view model and unit tests; all locale catalogs refreshed.
2026-08-25 13:25:21 +00:00
Bailey Dixon 06c0df6304 fix(android): make session activity authoritative 2026-08-25 08:51:12 -04:00
Bailey Dixon 71a2b3a7fb Merge pull request #431 from Codename-11/main
chore: reconcile production release into dev
2026-08-25 00:05:05 -04:00
Bailey Dixon 65e48084cb Merge remote-tracking branch 'origin/dev' into feature/android-supervised-mode 2026-08-24 21:52:07 -04:00
Bailey Dixon 1074ecc24f Merge remote-tracking branch 'origin/dev' into feature/android-supervised-mode
# Conflicts:
#	app/src/main/kotlin/com/hermesandroid/relay/ui/RelayApp.kt
#	app/src/main/kotlin/com/hermesandroid/relay/ui/screens/SettingsScreen.kt
#	docs/localization-status.json
2026-08-24 21:41:12 -04:00
Bailey Dixon f2a23e32aa fix(android): preserve supervised restart redirect 2026-08-24 21:33:01 -04:00
Bailey Dixon 630cc6d316 Merge remote-tracking branch 'origin/dev' into feature/android-supervised-mode
# Conflicts:
#	app/src/main/kotlin/com/hermesandroid/relay/ui/RelayApp.kt
#	app/src/main/kotlin/com/hermesandroid/relay/ui/screens/ChatScreen.kt
#	docs/decisions.md
#	docs/localization-status.json
#	plugin/dashboard/dist/index.js
2026-08-24 21:08:50 -04:00
Bailey Dixon e16205d82a feat(android): polish supervised appearance 2026-08-24 20:50:11 -04:00
Bailey Dixon 676c37e5ca fix(android): stabilize supervised mode transitions 2026-08-24 20:26:44 -04:00
Bailey Dixon 9b6fed9bdd fix(android): bootstrap supervised navigation 2026-08-24 20:15:19 -04:00
Bailey Dixon 4d90eef3d8 Merge remote-tracking branch 'origin/dev' into feature/android-supervised-mode 2026-08-24 20:15:18 -04:00
Bailey Dixon 478323893a feat(android): refine supervised controls 2026-08-24 19:36:10 -04:00
Bailey Dixon fcddeeb810 docs: document Android supervised mode 2026-08-24 16:34:59 -04:00
Bailey Dixon 49002b7141 feat(plugin): report supervised Android clients 2026-08-24 16:34:59 -04:00
Bailey Dixon 326eb47df3 feat(android): add supervised mode 2026-08-24 16:34:59 -04:00
69 changed files with 7802 additions and 104 deletions
+9 -1
View File
@@ -38,6 +38,10 @@ jobs:
working-directory: plugin/dashboard
run: npm run build
- name: Test dashboard source
working-directory: plugin/dashboard
run: npm test
- name: Setup Python
uses: actions/setup-python@v7
with:
@@ -54,7 +58,11 @@ jobs:
run: pip install -r relay_server/requirements.txt fastapi httpx requests
- name: Run dashboard API tests
run: python -m unittest plugin.dashboard.test_plugin_api
run: >-
python -m unittest
plugin.dashboard.test_plugin_api
plugin.dashboard.test_git_api
plugin.dashboard.test_mobile_plugin_api
- name: Verify dashboard bundle outputs
run: |
+5 -1
View File
@@ -106,4 +106,8 @@ jobs:
plugin/tests/test_session_grants.py \
plugin/tests/test_native_layout_imports.py \
plugin/tests/test_profile_discovery.py \
plugin/tests/test_profiles_updated_broadcast.py
plugin/tests/test_profiles_updated_broadcast.py \
plugin/tests/test_git_state.py \
plugin/tests/test_git_state_write.py \
plugin/tests/test_git_state_extras.py \
plugin/tests/test_mobile_plugin_store.py
+9
View File
@@ -6,6 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/), and this
## [Unreleased]
### Added
- **Android presents Relay Git as a first-class native workspace.** A compact optional Chat rail opens repository status, line totals, filters, diffs, branches, staging, commits, and remotes; the full workspace remains available from Settings when Chat controls are hidden.
- **Hermes-Relay Plugin provides a bounded Git workspace API for authenticated Dashboard clients.** Configured repository roots, path validation, tracked line totals, scoped write grants, and explicit confirmation protect repository reads and mutations.
### Fixed
- **The visible Android Sphere keeps its smooth procedural motion across startup and chat.** Backgrounded and motion-disabled surfaces remain still without reducing foreground animation to a stepped ambient pulse.
## [Android 1.13.2] - 2026-08-25
### Added
+5
View File
@@ -159,6 +159,11 @@ manual fallbacks when QR or clipboard transfer is unavailable.
</tr>
</table>
<p align="center">
<img src="assets/screenshots/supplemental/15_git_workspace.png" alt="Native Git workspace showing repository changes, an inline diff, and staging controls" width="260"><br>
<sub><b>Native Git workspace</b> — optional Hermes-Relay plugin</sub>
</p>
### Simplified Chinese
<table>
@@ -33,6 +33,8 @@ class ChatInputPreferencesRepository(
stringPreferencesKey("physical_keyboard_enter_behavior")
internal val KEY_CONVERT_LARGE_PASTES =
booleanPreferencesKey("convert_large_pastes_to_attachments")
internal val KEY_SHOW_GIT_WORKSPACE_IN_CHAT =
booleanPreferencesKey("show_git_workspace_in_chat")
}
val physicalKeyboardEnterBehavior: Flow<PhysicalKeyboardEnterBehavior> = dataStore.data
@@ -47,6 +49,10 @@ class ChatInputPreferencesRepository(
.map { preferences -> preferences[KEY_CONVERT_LARGE_PASTES] ?: true }
.distinctUntilChanged()
val showGitWorkspaceInChat: Flow<Boolean> = dataStore.data
.map { preferences -> preferences[KEY_SHOW_GIT_WORKSPACE_IN_CHAT] ?: true }
.distinctUntilChanged()
suspend fun setPhysicalKeyboardEnterBehavior(behavior: PhysicalKeyboardEnterBehavior) {
dataStore.edit { preferences ->
preferences[KEY_PHYSICAL_KEYBOARD_ENTER] = behavior.storedValue
@@ -58,4 +64,10 @@ class ChatInputPreferencesRepository(
preferences[KEY_CONVERT_LARGE_PASTES] = enabled
}
}
suspend fun setShowGitWorkspaceInChat(enabled: Boolean) {
dataStore.edit { preferences ->
preferences[KEY_SHOW_GIT_WORKSPACE_IN_CHAT] = enabled
}
}
}
@@ -0,0 +1,163 @@
package com.hermesandroid.relay.data
import com.hermesandroid.relay.network.upstream.DashboardApiClient
import com.hermesandroid.relay.plugins.runtime.ScopedPluginApiClient
import kotlinx.serialization.json.Json
import kotlinx.serialization.json.JsonPrimitive
import kotlinx.serialization.json.buildJsonArray
import kotlinx.serialization.json.buildJsonObject
import kotlinx.serialization.json.decodeFromJsonElement
import kotlinx.serialization.json.put
// Read + write client for the Hermes-Relay Git State endpoints.
// All requests are confined to the ``hermes-relay`` plugin namespace and the
// ``git/*`` sub-path via ScopedPluginApiClient, which rejects traversal and
// encodes query values.
private fun pathsArray(paths: List<String>) = buildJsonArray { paths.forEach { add(JsonPrimitive(it)) } }
class GitStateApiClient(
dashboard: DashboardApiClient,
) {
private val scoped = ScopedPluginApiClient("hermes-relay", dashboard)
private val json = Json { ignoreUnknownKeys = true }
suspend fun repos(): Result<List<GitRepo>> = scoped
.get("git/repos")
.mapCatching { element ->
json.decodeFromJsonElement<ReposResponse>(element).repos
}
suspend fun status(repo: String): Result<GitStatus> = scoped
.get("git/status", mapOf("repo" to repo))
.mapCatching { element -> json.decodeFromJsonElement<GitStatus>(element) }
suspend fun branches(repo: String): Result<List<GitBranch>> = scoped
.get("git/branches", mapOf("repo" to repo))
.mapCatching { element ->
json.decodeFromJsonElement<BranchesResponse>(element).branches
}
suspend fun diff(repo: String, path: String, kind: String): Result<GitDiff> = scoped
.get("git/diff", mapOf("repo" to repo, "path" to path, "kind" to kind))
.mapCatching { element -> json.decodeFromJsonElement<GitDiff>(element) }
suspend fun file(repo: String, path: String): Result<GitFile> = scoped
.get("git/file", mapOf("repo" to repo, "path" to path))
.mapCatching { element -> json.decodeFromJsonElement<GitFile>(element) }
// ── Write operations ───────────────────────────────────────────────────
// Every write requires the plugin.api.write grant, which the app enforces
// (see GitStateViewModel: a POST is never sent without the grant). The
// server additionally enforces per-use confirmation strings for destructive
// ops (discard/push/dirty-checkout) — the caller passes the echoed token.
suspend fun stage(repo: String, paths: List<String>): Result<GitMutationResult> =
scoped.post("git/stage", buildJsonObject {
put("repo", repo)
put("paths", pathsArray(paths))
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun unstage(repo: String, paths: List<String>): Result<GitMutationResult> =
scoped.post("git/unstage", buildJsonObject {
put("repo", repo)
put("paths", pathsArray(paths))
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun discard(
repo: String,
paths: List<String>,
confirmation: String,
deleteUntracked: Boolean = false,
): Result<GitMutationResult> = scoped.post("git/discard", buildJsonObject {
put("repo", repo)
put("paths", pathsArray(paths))
put("confirmation", confirmation)
put("delete_untracked", deleteUntracked)
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun commit(repo: String, message: String): Result<GitMutationResult> =
scoped.post("git/commit", buildJsonObject {
put("repo", repo)
put("message", message)
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun commitSelected(
repo: String,
message: String,
paths: List<String>,
): Result<GitMutationResult> = scoped.post("git/commit_selected", buildJsonObject {
put("repo", repo)
put("message", message)
put("paths", pathsArray(paths))
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun fetch(repo: String, remote: String = "origin"): Result<GitMutationResult> =
scoped.post("git/fetch", buildJsonObject {
put("repo", repo)
put("remote", remote)
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun pull(repo: String, remote: String = "origin", branch: String = ""): Result<GitMutationResult> =
scoped.post("git/pull", buildJsonObject {
put("repo", repo)
put("remote", remote)
put("branch", branch)
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun push(
repo: String,
confirmation: String,
remote: String = "origin",
branch: String = "",
): Result<GitMutationResult> = scoped.post("git/push", buildJsonObject {
put("repo", repo)
put("remote", remote)
put("branch", branch)
put("confirmation", confirmation)
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
suspend fun checkout(
repo: String,
ref: String,
confirmation: String? = null,
newBranch: String = "",
track: Boolean = false,
): Result<GitMutationResult> = scoped.post("git/checkout", buildJsonObject {
put("repo", repo)
put("ref", ref)
if (confirmation != null) put("confirmation", confirmation)
if (newBranch.isNotEmpty()) put("new_branch", newBranch)
put("track", track)
}).mapCatching { json.decodeFromJsonElement<GitMutationResult>(it) }
// ── Phase 3 extras ─────────────────────────────────────────────────────
/** Generate a commit-message suggestion from the staged diff. */
suspend fun commitMessage(repo: String): Result<GitCommitMessage> =
scoped.post("git/commit_message", buildJsonObject {
put("repo", repo)
}).mapCatching { json.decodeFromJsonElement<GitCommitMessage>(it) }
/** Generate a commit-message suggestion from the given paths' staged diff. */
suspend fun commitMessageSelected(
repo: String,
paths: List<String>,
): Result<GitCommitMessage> = scoped.post("git/commit_message_selected", buildJsonObject {
put("repo", repo)
put("paths", pathsArray(paths))
}).mapCatching { json.decodeFromJsonElement<GitCommitMessage>(it) }
/** Checkout that auto-stashes a dirty tree first. */
suspend fun stashCheckout(
repo: String,
ref: String,
newBranch: String = "",
track: Boolean = false,
): Result<GitStashCheckoutResult> = scoped.post("git/stash_checkout", buildJsonObject {
put("repo", repo)
put("ref", ref)
if (newBranch.isNotEmpty()) put("new_branch", newBranch)
put("track", track)
}).mapCatching { json.decodeFromJsonElement<GitStashCheckoutResult>(it) }
}
@@ -0,0 +1,107 @@
package com.hermesandroid.relay.data
import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable
/** A repository discovered by the plugin's /git/repos endpoint. */
@Serializable
data class GitRepo(
val id: String,
val name: String,
val root: String,
@SerialName("current_branch") val currentBranch: String? = null,
val dirty: Boolean = false,
)
/** Working-tree status from /git/status. */
@Serializable
data class GitStatus(
val counts: GitStatusCounts = GitStatusCounts(),
val staged: List<GitStatusEntry> = emptyList(),
val modified: List<GitStatusEntry> = emptyList(),
val untracked: List<GitStatusEntry> = emptyList(),
val truncated: Boolean = false,
)
@Serializable
data class GitStatusCounts(
val staged: Int = 0,
val modified: Int = 0,
val untracked: Int = 0,
/** Unique changed paths. -1 means an older plugin did not provide it. */
val changes: Int = -1,
val additions: Int = 0,
val deletions: Int = 0,
)
@Serializable
data class GitStatusEntry(
val path: String,
val additions: Int? = null,
val deletions: Int? = null,
)
/** A branch from /git/branches. */
@Serializable
data class GitBranch(
val name: String,
val upstream: String? = null,
val ahead: Int = 0,
val behind: Int = 0,
@SerialName("is_current") val isCurrent: Boolean = false,
)
/** A per-file diff from /git/diff. */
@Serializable
data class GitDiff(
val path: String,
val kind: String,
val diff: String,
val truncated: Boolean = false,
)
/** A tracked-file read from /git/file. */
@Serializable
data class GitFile(
val path: String,
val content: String,
val truncated: Boolean = false,
)
/** Wrapper for /git/repos response. */
@Serializable
internal data class ReposResponse(
val repos: List<GitRepo> = emptyList(),
val notice: String? = null,
)
/** Wrapper for /git/branches response. */
@Serializable
internal data class BranchesResponse(
val branches: List<GitBranch> = emptyList(),
)
/** A mutation response: fresh HEAD oid + working-tree status (+ branches). */
@Serializable
data class GitMutationResult(
val head: String = "",
val status: GitStatus = GitStatus(),
val branches: List<GitBranch> = emptyList(),
)
/** A /git/commit_message suggestion: generated message + optional notice. */
@Serializable
data class GitCommitMessage(
val message: String = "",
val notice: String = "",
)
/** A /git/stash_checkout result: standard mutation shape + stash flag/message. */
@Serializable
data class GitStashCheckoutResult(
val head: String = "",
val status: GitStatus = GitStatus(),
val branches: List<GitBranch> = emptyList(),
val stashed: Boolean = false,
@SerialName("stash_message") val stashMessage: String = "",
)
@@ -0,0 +1,55 @@
package com.hermesandroid.relay.ui
import com.hermesandroid.relay.data.GitRepo
import com.hermesandroid.relay.ui.components.ChatGitWorkspaceSummary
import com.hermesandroid.relay.viewmodel.GitRepoDetailState
internal fun selectGitRepoForWorkspace(
repos: List<GitRepo>,
selectedRepoId: String?,
sessionRepoRoot: String?,
sessionWorkingDirectory: String?,
): GitRepo? {
if (repos.isEmpty()) return null
fun normalized(path: String): String =
path.trim().replace('\\', '/').trimEnd('/')
val exactRoot = sessionRepoRoot?.let(::normalized).orEmpty()
val workingDirectory = sessionWorkingDirectory?.let(::normalized).orEmpty()
val matched = exactRoot.takeIf { it.isNotBlank() }?.let { root ->
repos.firstOrNull { normalized(it.root).equals(root, ignoreCase = true) }
} ?: workingDirectory.takeIf { it.isNotBlank() }?.let { cwd ->
repos.filter { repo ->
val root = normalized(repo.root)
cwd.equals(root, ignoreCase = true) ||
cwd.startsWith("$root/", ignoreCase = true)
}.maxByOrNull { normalized(it.root).length }
}
if (matched != null) return matched
if (repos.any { it.id == selectedRepoId }) return null
return repos.singleOrNull()
}
internal fun buildChatGitWorkspaceSummary(
repo: GitRepo?,
detail: GitRepoDetailState,
): ChatGitWorkspaceSummary? {
val ready = detail as? GitRepoDetailState.Ready ?: return null
repo ?: return null
val status = ready.status
val changedPaths = buildSet {
status.staged.forEach { add(it.path) }
status.modified.forEach { add(it.path) }
status.untracked.forEach { add(it.path) }
}
val branch = ready.branches.firstOrNull { it.isCurrent }?.name
?: repo.currentBranch.orEmpty()
if (branch.isBlank()) return null
return ChatGitWorkspaceSummary(
branch = branch,
changeCount = status.counts.changes.takeIf { it >= 0 } ?: changedPaths.size,
additions = status.counts.additions,
deletions = status.counts.deletions,
)
}
@@ -179,6 +179,9 @@ import com.hermesandroid.relay.ui.screens.SupervisedAppearanceSettingsScreen
import com.hermesandroid.relay.ui.screens.UsageLimitsScreen
import com.hermesandroid.relay.ui.screens.PluginsScreen
import com.hermesandroid.relay.ui.screens.PluginPageScreen
import com.hermesandroid.relay.ui.screens.GitStateScreen
import com.hermesandroid.relay.viewmodel.GitStateViewModel
import com.hermesandroid.relay.viewmodel.GitStateUiState
import com.hermesandroid.relay.ui.screens.TerminalScreen
import com.hermesandroid.relay.ui.screens.NotificationCompanionSettingsScreen
import com.hermesandroid.relay.ui.screens.ProactiveSettingsScreen
@@ -198,7 +201,9 @@ import com.hermesandroid.relay.viewmodel.ChatTransportPath
import com.hermesandroid.relay.viewmodel.ChatTransportReadiness
import com.hermesandroid.relay.viewmodel.ChatViewModel
import com.hermesandroid.relay.viewmodel.ConnectionViewModel
import com.hermesandroid.relay.plugins.runtime.PLUGIN_API_WRITE_CAPABILITY
import com.hermesandroid.relay.viewmodel.PluginsViewModel
import com.hermesandroid.relay.viewmodel.PluginsHubState
import com.hermesandroid.relay.viewmodel.ProfileInspectorViewModel
import com.hermesandroid.relay.viewmodel.TerminalViewModel
import com.hermesandroid.relay.viewmodel.VoiceViewModel
@@ -446,6 +451,7 @@ sealed class Screen(
}
data object Settings : Screen("settings", "Settings", Icons.Filled.Settings)
data object Plugins : Screen("plugins", "Plugins", Icons.Filled.Extension)
data object GitState : Screen("git_state", "Git", Icons.Filled.Code)
data object PluginPage : Screen(
"plugins/{pluginId}/pages/{pageId}",
"Plugin",
@@ -632,6 +638,7 @@ fun RelayApp() {
val chatViewModel: ChatViewModel = processRuntime.chatViewModel
val terminalViewModel: TerminalViewModel = viewModel()
val pluginsViewModel: PluginsViewModel = viewModel()
val gitStateViewModel: GitStateViewModel = viewModel()
val voiceViewModel: VoiceViewModel = processRuntime.voiceViewModel
val runtimeInitializationState by processRuntime.initializationState.collectAsState()
@@ -850,6 +857,11 @@ fun RelayApp() {
val serverCapabilities by connectionViewModel.serverCapabilities.collectAsState()
val gatewayAvailability by connectionViewModel.gatewayAvailability.collectAsState()
val effectiveDashboardUrl by connectionViewModel.effectiveDashboardUrl.collectAsState()
val gitOwnerKey = activeConnectionId?.takeIf { it.isNotBlank() }?.let { connectionId ->
effectiveDashboardUrl.takeIf { it.isNotBlank() }?.let { dashboardUrl ->
"$connectionId\u0000${effectiveSessionProfileName.orEmpty()}\u0000$dashboardUrl"
}
}
LaunchedEffect(
activeConnectionId,
effectiveDashboardUrl,
@@ -864,6 +876,64 @@ fun RelayApp() {
sessionId = currentChatSessionId,
)
}
LaunchedEffect(gitOwnerKey) {
val dashboard = effectiveDashboardUrl
.takeIf { it.isNotBlank() }
?.let { connectionViewModel.dashboardClientForActive(it) }
gitStateViewModel.configure(dashboard, gitOwnerKey)
}
// Mirror the plugin.api.write grant into the Git view model so write
// mutations are refused client-side until the user grants write access
// (matches the plug-in's grant gating in PluginsViewModel).
val pluginsHubState by pluginsViewModel.hubState.collectAsState()
LaunchedEffect(pluginsHubState, gitOwnerKey) {
val ready = pluginsHubState as? PluginsHubState.Ready
val granted = ready
?.takeIf { it.ownerKey == gitOwnerKey }
?.plugins
?.firstOrNull { it.catalog.id == "hermes-relay" }
?.preferences
?.grants
?.contains(PLUGIN_API_WRITE_CAPABILITY) == true
gitStateViewModel.setWriteGrant(gitOwnerKey, granted)
}
val gitReposState by gitStateViewModel.repos.collectAsState()
val gitDetailState by gitStateViewModel.detail.collectAsState()
val selectedGitRepoId by gitStateViewModel.selectedRepoId.collectAsState()
val chatSessions by chatViewModel.sessions.collectAsState()
val activeChatSession = remember(chatSessions, currentChatSessionId) {
chatSessions.firstOrNull { it.sessionId == currentChatSessionId }
}
// Bind Git to the active coding session when upstream supplies its exact
// workspace metadata. CWD fallback only matches a path-segment descendant;
// an ambiguous multi-repo catalog stays unselected until the user chooses.
LaunchedEffect(gitReposState, activeChatSession, selectedGitRepoId) {
val repos = (gitReposState as? GitStateUiState.Ready)?.repos.orEmpty()
val target = selectGitRepoForWorkspace(
repos = repos,
selectedRepoId = selectedGitRepoId,
sessionRepoRoot = activeChatSession?.gitRepoRoot,
sessionWorkingDirectory = activeChatSession?.workingDirectory,
)
if (target != null && target.id != selectedGitRepoId) {
gitStateViewModel.selectRepo(target.id)
}
}
val gitWorkspaceAvailable = gitReposState is GitStateUiState.Ready
val gitWorkspaceSummary = remember(
gitReposState,
gitDetailState,
selectedGitRepoId,
) {
val repo = (gitReposState as? GitStateUiState.Ready)
?.repos
?.firstOrNull { it.id == selectedGitRepoId }
buildChatGitWorkspaceSummary(repo, gitDetailState)
}
// What's New auto-show
val showWhatsNew by connectionViewModel.showWhatsNew.collectAsState()
@@ -2262,6 +2332,11 @@ fun RelayApp() {
onNavigateToBotMode = {
navController.navigate(Screen.BotMode.route) { launchSingleTop = true }
},
gitWorkspaceAvailable = gitWorkspaceAvailable,
gitWorkspaceSummary = gitWorkspaceSummary,
onNavigateToGitWorkspace = {
navController.navigate(Screen.GitState.route) { launchSingleTop = true }
},
)
}
composable(Screen.BotMode.route) {
@@ -2617,6 +2692,9 @@ fun RelayApp() {
onNavigateToPlugins = {
navController.navigate(Screen.Plugins.route)
},
onNavigateToGitWorkspace = {
navController.navigate(Screen.GitState.route)
},
onNavigateToChatSettings = {
navController.navigate(Screen.ChatSettings.route)
},
@@ -2740,10 +2818,20 @@ fun RelayApp() {
viewModel = pluginsViewModel,
onBack = { navController.popBackStack() },
onOpenPage = { pluginId, pageId ->
navController.navigate(Screen.PluginPage.route(pluginId, pageId))
if (pluginId == "hermes-relay" && pageId == "git") {
navController.navigate(Screen.GitState.route)
} else {
navController.navigate(Screen.PluginPage.route(pluginId, pageId))
}
},
)
}
composable(Screen.GitState.route) {
GitStateScreen(
viewModel = gitStateViewModel,
onBack = { navController.popBackStack() },
)
}
composable(
route = Screen.PluginPage.route,
arguments = listOf(
@@ -0,0 +1,156 @@
package com.hermesandroid.relay.ui.components
import androidx.compose.foundation.BorderStroke
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.KeyboardArrowRight
import androidx.compose.material.icons.filled.AccountTree
import androidx.compose.material3.Icon
import androidx.compose.material3.Surface
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.semantics.clearAndSetSemantics
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import androidx.compose.ui.res.pluralStringResource
import androidx.compose.ui.res.stringResource
import com.hermesandroid.relay.R
import com.hermesandroid.relay.ui.theme.RelayRefresh
import com.hermesandroid.relay.ui.theme.appearanceRoundedCornerShape
import com.hermesandroid.relay.ui.theme.relayMetadataStyle
/** Small, read-only Git projection supplied by the native workspace owner. */
data class ChatGitWorkspaceSummary(
val branch: String,
val changeCount: Int,
val additions: Int? = null,
val deletions: Int? = null,
)
@Composable
fun ChatGitContextButton(
onClick: () -> Unit,
modifier: Modifier = Modifier,
) {
Box(modifier = modifier) {
RelayChromeIconButton(
icon = Icons.Filled.AccountTree,
contentDescription = stringResource(R.string.chat_git_open_workspace),
onClick = onClick,
)
Surface(
modifier = Modifier
.size(9.dp)
.align(Alignment.TopEnd),
shape = CircleShape,
color = RelayRefresh.Green,
border = BorderStroke(1.5.dp, RelayRefresh.Background),
content = {},
)
}
}
@Composable
fun ChatGitWorkspaceRail(
summary: ChatGitWorkspaceSummary,
onClick: () -> Unit,
modifier: Modifier = Modifier,
) {
val branch = summary.branch.trim()
val changeCount = summary.changeCount.coerceAtLeast(0)
val changeLabel = pluralStringResource(
R.plurals.chat_git_change_count,
changeCount,
changeCount,
)
val additions = summary.additions?.coerceAtLeast(0)
val deletions = summary.deletions?.coerceAtLeast(0)
val a11yLabel = buildList {
add(stringResource(R.string.chat_git_branch, branch))
add(changeLabel)
additions?.let { add(stringResource(R.string.chat_git_additions, it)) }
deletions?.let { add(stringResource(R.string.chat_git_deletions, it)) }
add(stringResource(R.string.chat_git_open_workspace))
}.joinToString(". ")
Surface(
onClick = onClick,
modifier = modifier
.fillMaxWidth()
.height(38.dp)
.clearAndSetSemantics { contentDescription = a11yLabel },
shape = appearanceRoundedCornerShape(12.dp),
color = RelayRefresh.Background.copy(alpha = 0.72f),
border = BorderStroke(1.dp, RelayRefresh.LineStrong),
) {
Row(
modifier = Modifier.padding(horizontal = 11.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp),
) {
Icon(
imageVector = Icons.Filled.AccountTree,
contentDescription = null,
tint = RelayRefresh.Cyan,
modifier = Modifier.size(17.dp),
)
Text(
text = branch,
style = relayMetadataStyle(),
color = RelayRefresh.Paper,
maxLines = 1,
overflow = TextOverflow.Ellipsis,
modifier = Modifier.widthIn(max = 92.dp),
)
Box(
modifier = Modifier
.width(1.dp)
.height(16.dp)
.background(RelayRefresh.LineStrong),
)
Text(
text = changeLabel,
style = relayMetadataStyle(),
color = RelayRefresh.Muted,
maxLines = 1,
)
Spacer(modifier = Modifier.weight(1f))
additions?.let {
Text(
text = "+$it",
style = relayMetadataStyle(),
color = RelayRefresh.Green,
maxLines = 1,
)
}
deletions?.let {
Text(
text = "-$it",
style = relayMetadataStyle(),
color = RelayRefresh.Danger,
maxLines = 1,
)
}
Icon(
imageVector = Icons.AutoMirrored.Filled.KeyboardArrowRight,
contentDescription = null,
tint = RelayRefresh.Muted,
modifier = Modifier.size(18.dp),
)
}
}
}
@@ -14,7 +14,6 @@ import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableFloatStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.withFrameNanos
import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clipToBounds
import androidx.compose.ui.geometry.Offset
@@ -26,8 +25,6 @@ import androidx.compose.ui.text.rememberTextMeasurer
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.hermesandroid.relay.ui.theme.LocalBrand
import kotlinx.coroutines.delay
import kotlin.math.sin
/**
* ASCII morphing sphere — the visual embodiment of the AI agent.
@@ -56,19 +53,13 @@ import kotlin.math.sin
private const val SPHERE_TIME_UNITS_PER_SEC = 1f
private const val SPHERE_TWO_PI = 6.2832f
private const val SPHERE_COLOR_RADIANS_PER_SEC = 0.7854f
private const val SPHERE_IDLE_BREATH_RADIANS_PER_SEC = 0.72f
private const val SPHERE_IDLE_BREATH_SCALE = 0.012f
private const val SPHERE_IDLE_LAYER_FRAME_INTERVAL_MS = 184L
internal enum class SphereMotionMode {
Still,
AmbientLayer,
Procedural,
}
internal fun sphereMotionMode(
state: SphereState,
voiceMode: Boolean,
motionVisible: Boolean,
fixedTime: Float?,
fixedColorPhase: Float?,
@@ -76,11 +67,7 @@ internal fun sphereMotionMode(
if (!motionVisible || fixedTime != null || fixedColorPhase != null) {
return SphereMotionMode.Still
}
return if (state == SphereState.Idle && !voiceMode) {
SphereMotionMode.AmbientLayer
} else {
SphereMotionMode.Procedural
}
return SphereMotionMode.Procedural
}
@Composable
@@ -134,15 +121,12 @@ fun MorphingSphere(
val cg2 by animateFloatAsState(targetC.g2, spec, label = "cg2")
val cb2 by animateFloatAsState(targetC.b2, spec, label = "cb2")
// Active states retain the full procedural animation. Visible Idle uses a
// lightweight graphics-layer breath: redrawing the 58x34 glyph grid just
// for ambient drift was the measured screen-on hotspot, while transforming
// its cached layer preserves the intended living Sphere at far lower cost.
// Every visible Sphere uses the same display-synced procedural loop so
// startup, chat, and voice all feel equally smooth. Backgrounded and
// explicitly paused/reduced-motion renderers still pin a static frame.
val animatedTime = remember { mutableFloatStateOf(0f) }
val animatedColorPhase = remember { mutableFloatStateOf(0f) }
val motionMode = sphereMotionMode(
state = state,
voiceMode = effVoiceMode,
motionVisible = motionVisible,
fixedTime = fixedTime,
fixedColorPhase = fixedColorPhase,
@@ -162,25 +146,6 @@ fun MorphingSphere(
}
}
}
val idleBreathPhase = remember { mutableFloatStateOf(0f) }
LaunchedEffect(motionMode) {
if (motionMode != SphereMotionMode.AmbientLayer) {
idleBreathPhase.floatValue = 0f
return@LaunchedEffect
}
var lastNanos = withFrameNanos { it }
while (true) {
val now = withFrameNanos { it }
val dtSec = (now - lastNanos).coerceAtLeast(0L) / 1_000_000_000f
lastNanos = now
idleBreathPhase.floatValue =
(idleBreathPhase.floatValue + dtSec * SPHERE_IDLE_BREATH_RADIANS_PER_SEC) %
SPHERE_TWO_PI
// The frame wait plus this delay caps the gentle layer-only pulse
// near 5fps while active procedural states retain display-rate motion.
delay(SPHERE_IDLE_LAYER_FRAME_INTERVAL_MS)
}
}
val time = fixedTime ?: animatedTime.floatValue
val colorPhase = fixedColorPhase ?: animatedColorPhase.floatValue
@@ -192,18 +157,7 @@ fun MorphingSphere(
val textMeasurer = rememberTextMeasurer(cacheSize = 64)
val glyphStrings = remember { HashMap<Char, String>(32) }
Canvas(
modifier = modifier
.fillMaxSize()
.graphicsLayer {
if (motionMode == SphereMotionMode.AmbientLayer) {
val scale = 1f + sin(idleBreathPhase.floatValue) * SPHERE_IDLE_BREATH_SCALE
scaleX = scale
scaleY = scale
}
}
.clipToBounds(),
) {
Canvas(modifier = modifier.fillMaxSize().clipToBounds()) {
val canvasW = size.width
val canvasH = size.height
val cellW = canvasW / cols
@@ -193,6 +193,9 @@ import com.hermesandroid.relay.ui.components.BackgroundTaskCard
import com.hermesandroid.relay.ui.components.LocalRelayServerImageResolver
import com.hermesandroid.relay.ui.components.RelayServerImageResolver
import com.hermesandroid.relay.ui.components.ChatInputBar
import com.hermesandroid.relay.ui.components.ChatGitContextButton
import com.hermesandroid.relay.ui.components.ChatGitWorkspaceRail
import com.hermesandroid.relay.ui.components.ChatGitWorkspaceSummary
import com.hermesandroid.relay.ui.components.ChatFailureDetailsDialog
import com.hermesandroid.relay.ui.components.ChatFailurePanel
import com.hermesandroid.relay.viewmodel.ChatFailureRoute
@@ -719,6 +722,9 @@ fun ChatScreen(
onNavigateToProfileInspector: (String) -> Unit = {},
supervisedPolicy: SupervisedModePolicy = SupervisedModePolicy(),
onNavigateToBotMode: () -> Unit = {},
gitWorkspaceSummary: ChatGitWorkspaceSummary? = null,
gitWorkspaceAvailable: Boolean = gitWorkspaceSummary != null,
onNavigateToGitWorkspace: () -> Unit = {},
) {
val supervised = supervisedPolicy.enabled
val supervisedVisibility = supervisedPolicy.visibility.resolved()
@@ -1067,6 +1073,13 @@ fun ChatScreen(
connectionViewModel.physicalKeyboardEnterBehavior.collectAsState()
val convertLargePastesToAttachments by
connectionViewModel.convertLargePastesToAttachments.collectAsState()
val showGitWorkspaceInChat by
connectionViewModel.showGitWorkspaceInChat.collectAsState()
val visibleGitWorkspaceSummary = gitWorkspaceSummary?.takeIf {
!supervised && showGitWorkspaceInChat && it.branch.isNotBlank()
}
val showGitWorkspaceContextEntry =
!supervised && showGitWorkspaceInChat && gitWorkspaceAvailable
val availableSkills by chatViewModel.availableSkills.collectAsState()
val queuedMessages by chatViewModel.queuedMessages.collectAsState()
@@ -2996,6 +3009,12 @@ fun ChatScreen(
// info. Dropping it here declutters the actions row and frees
// width for the title subtitle.)
if (!supervised) {
if (showGitWorkspaceContextEntry) {
ChatGitContextButton(
onClick = onNavigateToGitWorkspace,
modifier = Modifier.padding(end = 4.dp),
)
}
RelayChromeIconButton(
icon = Icons.Filled.Code,
contentDescription = stringResource(R.string.cd_terminal),
@@ -4457,6 +4476,14 @@ fun ChatScreen(
}
}
visibleGitWorkspaceSummary?.let { summary ->
ChatGitWorkspaceRail(
summary = summary,
onClick = onNavigateToGitWorkspace,
modifier = Modifier.padding(horizontal = 16.dp, vertical = 4.dp),
)
}
ChatInputBar(
value = inputText,
onValueChange = { inputText = it },
@@ -391,6 +391,32 @@ fun ChatSettingsScreen(
HorizontalDivider()
val showGitWorkspaceInChat by
connectionViewModel.showGitWorkspaceInChat.collectAsState()
Row(
modifier = Modifier.fillMaxWidth(),
horizontalArrangement = Arrangement.SpaceBetween,
verticalAlignment = Alignment.CenterVertically,
) {
Column(modifier = Modifier.weight(1f)) {
Text(
text = stringResource(R.string.chat_settings_show_git_workspace),
style = MaterialTheme.typography.bodyMedium,
)
Text(
text = stringResource(R.string.chat_settings_show_git_workspace_desc),
style = MaterialTheme.typography.bodySmall,
color = MaterialTheme.colorScheme.onSurfaceVariant,
)
}
Switch(
checked = showGitWorkspaceInChat,
onCheckedChange = connectionViewModel::setShowGitWorkspaceInChat,
)
}
HorizontalDivider()
val recentPromptsEnabled by
connectionViewModel.chatRecentPromptsEnabled.collectAsState()
Row(
@@ -0,0 +1,846 @@
package com.hermesandroid.relay.ui.screens
import androidx.compose.foundation.background
import androidx.compose.foundation.BorderStroke
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.layout.width
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.verticalScroll
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.ArrowBack
import androidx.compose.material.icons.filled.AccountTree
import androidx.compose.material.icons.filled.AutoAwesome
import androidx.compose.material.icons.filled.Check
import androidx.compose.material.icons.filled.Close
import androidx.compose.material.icons.filled.ExpandLess
import androidx.compose.material.icons.filled.ExpandMore
import androidx.compose.material.icons.filled.Download
import androidx.compose.material.icons.filled.FileUpload
import androidx.compose.material.icons.filled.MoreVert
import androidx.compose.material.icons.filled.Refresh
import androidx.compose.material3.AlertDialog
import androidx.compose.material3.Button
import androidx.compose.material3.Card
import androidx.compose.material3.CardDefaults
import androidx.compose.material3.Checkbox
import androidx.compose.material3.CircularProgressIndicator
import androidx.compose.material3.DropdownMenu
import androidx.compose.material3.DropdownMenuItem
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.FilterChip
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.ModalBottomSheet
import androidx.compose.material3.OutlinedButton
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Surface
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.material3.TopAppBar
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.collectAsState
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.saveable.rememberSaveable
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.contentDescription
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.text.font.FontFamily
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import com.hermesandroid.relay.R
import com.hermesandroid.relay.data.GitBranch
import com.hermesandroid.relay.data.GitRepo
import com.hermesandroid.relay.data.GitStatus
import com.hermesandroid.relay.viewmodel.GitConfirmationStrings
import com.hermesandroid.relay.viewmodel.GitContentViewState
import com.hermesandroid.relay.viewmodel.GitMessageGenerationState
import com.hermesandroid.relay.viewmodel.GitMutationState
import com.hermesandroid.relay.viewmodel.GitRepoDetailState
import com.hermesandroid.relay.viewmodel.GitStateUiState
import com.hermesandroid.relay.viewmodel.GitStateViewModel
import com.hermesandroid.relay.viewmodel.GitTarget
private enum class FileFilter { All, Staged, Modified, Untracked }
private enum class ContentMode { Diff, File }
private data class DisplayFile(
val path: String,
val filter: FileFilter,
val additions: Int?,
val deletions: Int?,
)
/** First-class native Git workspace backed by the optional Relay contribution. */
@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun GitStateScreen(viewModel: GitStateViewModel, onBack: () -> Unit) {
val reposState by viewModel.repos.collectAsState()
val detailState by viewModel.detail.collectAsState()
val contentState by viewModel.content.collectAsState()
val mutation by viewModel.mutation.collectAsState()
val messageGeneration by viewModel.messageGeneration.collectAsState()
val stashNotice by viewModel.stashNotice.collectAsState()
val hasGrant by viewModel.writeGrant.collectAsState()
val selectedRepoId by viewModel.selectedRepoId.collectAsState()
// A path can be staged and modified at the same time. Keep the category in
// the selection identity so selecting one row never silently selects the
// other layer or disables its correct action.
var selection by remember { mutableStateOf(setOf<DisplayFile>()) }
var filter by rememberSaveable { mutableStateOf(FileFilter.All) }
var expandedPath by rememberSaveable { mutableStateOf<String?>(null) }
var contentMode by rememberSaveable { mutableStateOf(ContentMode.Diff) }
var showRepos by rememberSaveable { mutableStateOf(false) }
var showBranches by rememberSaveable { mutableStateOf(false) }
var showCommit by rememberSaveable { mutableStateOf(false) }
var showOverflow by rememberSaveable { mutableStateOf(false) }
var pushAfter by rememberSaveable { mutableStateOf(false) }
var pendingConfirm by remember { mutableStateOf<ConfirmationRequest?>(null) }
val repos = (reposState as? GitStateUiState.Ready)?.repos.orEmpty()
val selectedRepo = repos.firstOrNull { it.id == selectedRepoId }
val detail = detailState as? GitRepoDetailState.Ready
val currentBranch = detail?.branches?.firstOrNull { it.isCurrent }
val changeCount = detail?.status?.uniqueChangeCount() ?: 0
val stageSelection: () -> Unit = {
val unstaged = selection.filter { it.filter != FileFilter.Staged }.map { it.path }
if (unstaged.isEmpty()) {
viewModel.unstage(selection.map { it.path }.distinct())
} else {
viewModel.stage(unstaged.distinct())
}
selection = emptySet()
}
val discardSelection: () -> Unit = {
viewModel.currentTarget()?.let { target ->
val discardable = selection.filter { it.filter != FileFilter.Staged }
if (discardable.isNotEmpty()) {
pendingConfirm = ConfirmationRequest.Discard(
paths = discardable.map { it.path }.distinct(),
deleteUntracked = discardable.any { it.filter == FileFilter.Untracked },
target = target,
)
}
}
}
LaunchedEffect(repos, selectedRepoId) {
if (repos.size == 1 && selectedRepoId == null) viewModel.selectRepo(repos.single().id)
}
LaunchedEffect(selectedRepoId) {
selection = emptySet()
expandedPath = null
}
Scaffold(
topBar = {
TopAppBar(
navigationIcon = {
IconButton(onClick = onBack) {
Icon(Icons.AutoMirrored.Filled.ArrowBack, stringResource(R.string.git_state_back))
}
},
title = {
Surface(
onClick = { showRepos = true },
enabled = repos.isNotEmpty(),
shape = RoundedCornerShape(12.dp),
color = Color.Transparent,
border = BorderStroke(1.dp, MaterialTheme.colorScheme.outlineVariant),
) {
Column(Modifier.padding(horizontal = 10.dp, vertical = 5.dp)) {
Row(verticalAlignment = Alignment.CenterVertically) {
Text(
selectedRepo?.name ?: stringResource(R.string.git_state_title),
style = MaterialTheme.typography.titleMedium,
maxLines = 1,
overflow = TextOverflow.Ellipsis,
)
if (repos.isNotEmpty()) Icon(Icons.Filled.ExpandMore, "Choose repository", Modifier.size(20.dp))
}
selectedRepo?.let {
Text(branchSummary(it, currentBranch), style = MaterialTheme.typography.labelSmall, color = MaterialTheme.colorScheme.onSurfaceVariant)
}
}
}
},
actions = {
IconButton(onClick = { selectedRepo?.let { viewModel.selectRepo(it.id) } ?: viewModel.loadRepos() }) {
Icon(Icons.Filled.Refresh, "Refresh Git workspace")
}
Box {
IconButton(onClick = { showOverflow = true }) { Icon(Icons.Filled.MoreVert, "More Git actions") }
DropdownMenu(expanded = showOverflow, onDismissRequest = { showOverflow = false }) {
DropdownMenuItem(text = { Text("Choose repository") }, onClick = { showOverflow = false; showRepos = true })
DropdownMenuItem(text = { Text(stringResource(R.string.git_state_branches)) }, enabled = detail != null, onClick = { showOverflow = false; showBranches = true })
}
}
},
)
},
bottomBar = {
if (detail != null) {
Surface(shadowElevation = 8.dp, tonalElevation = 2.dp) {
Column {
if (selection.isNotEmpty()) {
SelectionRail(
count = selection.size,
canWrite = hasGrant,
allStaged = selection.all { it.filter == FileFilter.Staged },
onStage = stageSelection,
onDiscard = discardSelection,
)
}
Row(Modifier.fillMaxWidth().padding(horizontal = 16.dp, vertical = 10.dp), horizontalArrangement = Arrangement.spacedBy(10.dp)) {
OutlinedButton(onClick = { showBranches = true }, modifier = Modifier.weight(1f)) {
Icon(Icons.Filled.AccountTree, null, Modifier.size(18.dp)); Spacer(Modifier.width(8.dp)); Text(stringResource(R.string.git_state_branches))
}
Button(onClick = { showCommit = true }, enabled = hasGrant && detail.status.counts.staged > 0, modifier = Modifier.weight(1f)) {
Icon(Icons.Filled.AutoAwesome, null, Modifier.size(18.dp)); Spacer(Modifier.width(8.dp)); Text(stringResource(R.string.git_state_commit))
}
}
}
}
}
},
) { padding ->
when (val state = reposState) {
GitStateUiState.Loading -> FullState(Modifier.padding(padding), true, "Finding repositories")
is GitStateUiState.Unavailable -> UnavailableState(Modifier.padding(padding), state.message, viewModel::loadRepos)
is GitStateUiState.Error -> UnavailableState(Modifier.padding(padding), state.message, viewModel::loadRepos)
is GitStateUiState.Ready -> when {
state.repos.isEmpty() -> FullState(Modifier.padding(padding), false, "No Git repositories found", "Add a repository to the host's configured Git roots, then refresh.")
selectedRepo == null -> RepositoryPrompt(Modifier.padding(padding), state.repos, viewModel::selectRepo)
else -> WorkspaceBody(
modifier = Modifier.padding(padding),
repo = selectedRepo,
reposNotice = state.notice,
detailState = detailState,
mutation = mutation,
stashNotice = stashNotice,
hasGrant = hasGrant,
filter = filter,
onFilter = { filter = it },
selection = selection,
onToggleSelected = { file ->
selection = if (file in selection) selection - file else selection + file
},
expandedPath = expandedPath,
contentMode = contentMode,
contentState = contentState,
onOpen = { file, mode ->
if (file.filter != FileFilter.Untracked) {
val opening = expandedPath != file.path || contentMode != mode
expandedPath = if (opening) file.path else null
contentMode = mode
if (opening) {
if (mode == ContentMode.File) viewModel.loadFile(file.path)
else viewModel.loadDiff(file.path, if (file.filter == FileFilter.Staged) "staged" else "unstaged")
}
}
},
onFetch = viewModel::fetch,
onPull = viewModel::pull,
onPush = { viewModel.currentTarget()?.let { pendingConfirm = ConfirmationRequest.Push(it) } },
onClearMutation = viewModel::clearMutationError,
onRetry = { viewModel.selectRepo(selectedRepo.id) },
)
}
}
}
if (showRepos) RepositorySheet(repos, selectedRepo?.id, { showRepos = false }) { showRepos = false; viewModel.selectRepo(it) }
if (showBranches && detail != null) {
BranchSheet(
branches = detail.branches,
hasGrant = hasGrant,
dirty = changeCount > 0,
onDismiss = { showBranches = false },
onSwitch = { ref ->
showBranches = false
if (changeCount > 0) viewModel.currentTarget()?.let { pendingConfirm = ConfirmationRequest.DirtyCheckout(ref, it) } else viewModel.checkout(ref)
},
onStashSwitch = { showBranches = false; viewModel.stashCheckout(it) },
onCreate = { name, track -> showBranches = false; viewModel.checkout("", newBranch = name, track = track) },
)
}
if (showCommit && detail != null) {
val stagedPaths = detail.status.staged.map { it.path }
CommitDialog(
hasStaged = stagedPaths.isNotEmpty(),
generating = messageGeneration is GitMessageGenerationState.Loading,
generatedMessage = (messageGeneration as? GitMessageGenerationState.Ready)?.message.orEmpty(),
generationNotice = (messageGeneration as? GitMessageGenerationState.Ready)?.notice,
pushAfter = pushAfter,
onPushAfterChange = { pushAfter = it },
onGenerate = { viewModel.generateCommitMessage(stagedPaths) },
onDismiss = { showCommit = false },
onCommit = { message ->
showCommit = false
viewModel.commit(message) { target -> if (pushAfter) pendingConfirm = ConfirmationRequest.Push(target) }
},
)
}
pendingConfirm?.let { request ->
ConfirmationDialog(
request,
onDismiss = { pendingConfirm = null },
onDiscard = { paths, deleteUntracked, target -> pendingConfirm = null; viewModel.discard(paths, GitConfirmationStrings.DISCARD, deleteUntracked, target) },
onPush = { target -> pendingConfirm = null; viewModel.push(GitConfirmationStrings.PUSH, expectedTarget = target) },
onCheckout = { ref, target -> pendingConfirm = null; viewModel.checkout(ref, GitConfirmationStrings.DIRTY_CHECKOUT, expectedTarget = target) },
)
}
}
@Composable
private fun WorkspaceBody(
modifier: Modifier,
repo: GitRepo,
reposNotice: String?,
detailState: GitRepoDetailState,
mutation: GitMutationState,
stashNotice: String?,
hasGrant: Boolean,
filter: FileFilter,
onFilter: (FileFilter) -> Unit,
selection: Set<DisplayFile>,
onToggleSelected: (DisplayFile) -> Unit,
expandedPath: String?,
contentMode: ContentMode,
contentState: GitContentViewState,
onOpen: (DisplayFile, ContentMode) -> Unit,
onFetch: () -> Unit,
onPull: () -> Unit,
onPush: () -> Unit,
onClearMutation: () -> Unit,
onRetry: () -> Unit,
) {
when (detailState) {
GitRepoDetailState.Idle, GitRepoDetailState.Loading -> FullState(modifier, true, "Loading workspace")
is GitRepoDetailState.Error -> UnavailableState(modifier, detailState.message, onRetry)
is GitRepoDetailState.Ready -> {
val status = detailState.status
val allFiles = buildList {
status.staged.forEach { add(DisplayFile(it.path, FileFilter.Staged, it.additions, it.deletions)) }
status.modified.forEach { add(DisplayFile(it.path, FileFilter.Modified, it.additions, it.deletions)) }
status.untracked.forEach { add(DisplayFile(it.path, FileFilter.Untracked, it.additions, it.deletions)) }
}
val visible = allFiles.filter { filter == FileFilter.All || it.filter == filter }
LazyColumn(modifier.fillMaxSize(), contentPadding = PaddingValues(bottom = 18.dp)) {
item {
SummaryRail(repo, detailState)
RemoteActions(hasGrant, status, onFetch, onPull, onPush)
reposNotice?.let { NoticeCard(it) }
if (!hasGrant) WriteGrantNotice()
MutationBanner(mutation, onClearMutation)
stashNotice?.let { NoticeCard(it) }
if (status.truncated) NoticeCard(stringResource(R.string.git_state_truncated), error = true)
FilterRow(filter, status, onFilter)
}
if (visible.isEmpty()) item { EmptyFilterState(filter) }
FileFilter.entries.filter { it != FileFilter.All }.forEach { group ->
val files = visible.filter { it.filter == group }
if (files.isNotEmpty()) {
item { GroupHeader(group.name, files.size) }
items(files, key = { "${group.name}:${it.path}" }) { file ->
FileRow(
file = file,
selected = file in selection,
expanded = expandedPath == file.path,
mode = contentMode,
contentState = contentState,
onToggleSelected = { onToggleSelected(file) },
onOpen = { onOpen(file, it) },
)
}
}
}
}
}
}
}
@Composable
private fun SummaryRail(repo: GitRepo, detail: GitRepoDetailState.Ready) {
val count = detail.status.uniqueChangeCount()
val current = detail.branches.firstOrNull { it.isCurrent }
Surface(
Modifier.fillMaxWidth().padding(horizontal = 16.dp, vertical = 8.dp),
shape = RoundedCornerShape(14.dp),
color = MaterialTheme.colorScheme.surfaceContainer,
) {
Row(Modifier.padding(horizontal = 14.dp, vertical = 10.dp), verticalAlignment = Alignment.CenterVertically) {
Text("$count changes", style = MaterialTheme.typography.titleSmall, fontWeight = FontWeight.SemiBold)
VerticalDivider()
Text("+${detail.status.counts.additions}", color = Color(0xFF2E7D32), style = MaterialTheme.typography.labelLarge)
VerticalDivider()
Text("−${detail.status.counts.deletions}", color = MaterialTheme.colorScheme.error, style = MaterialTheme.typography.labelLarge)
Spacer(Modifier.weight(1f))
Surface(
shape = RoundedCornerShape(18.dp),
border = BorderStroke(1.dp, MaterialTheme.colorScheme.outlineVariant),
color = Color.Transparent,
) {
Row(Modifier.padding(horizontal = 9.dp, vertical = 5.dp), verticalAlignment = Alignment.CenterVertically) {
Icon(Icons.Filled.AccountTree, null, Modifier.size(16.dp)); Spacer(Modifier.width(5.dp))
Text(current?.name ?: repo.currentBranch ?: "Detached", style = MaterialTheme.typography.labelLarge, maxLines = 1)
if (repo.dirty || count > 0) { Spacer(Modifier.width(7.dp)); Box(Modifier.size(7.dp).background(MaterialTheme.colorScheme.tertiary, CircleShape)) }
}
}
}
}
}
@Composable
private fun VerticalDivider() {
Box(
Modifier.padding(horizontal = 10.dp).width(1.dp).height(22.dp)
.background(MaterialTheme.colorScheme.outlineVariant),
)
}
@Composable
private fun RemoteActions(hasGrant: Boolean, status: GitStatus, onFetch: () -> Unit, onPull: () -> Unit, onPush: () -> Unit) {
Row(Modifier.fillMaxWidth().padding(horizontal = 12.dp), verticalAlignment = Alignment.CenterVertically) {
TextButton(onClick = onFetch, enabled = hasGrant && status.counts.untracked == 0, modifier = Modifier.weight(1f)) {
Icon(Icons.Filled.Refresh, null, Modifier.size(18.dp)); Spacer(Modifier.width(6.dp)); Text(stringResource(R.string.git_state_fetch))
}
VerticalDivider()
TextButton(onClick = onPull, enabled = hasGrant, modifier = Modifier.weight(1f)) {
Icon(Icons.Filled.Download, null, Modifier.size(18.dp)); Spacer(Modifier.width(6.dp)); Text(stringResource(R.string.git_state_pull))
}
VerticalDivider()
TextButton(onClick = onPush, enabled = hasGrant && status.counts.staged == 0, modifier = Modifier.weight(1f)) {
Icon(Icons.Filled.FileUpload, null, Modifier.size(18.dp)); Spacer(Modifier.width(6.dp)); Text(stringResource(R.string.git_state_push))
}
}
}
@Composable
private fun FilterRow(selected: FileFilter, status: GitStatus, onSelect: (FileFilter) -> Unit) {
val counts = mapOf(
FileFilter.All to status.uniqueChangeCount(),
FileFilter.Staged to status.counts.staged,
FileFilter.Modified to status.counts.modified,
FileFilter.Untracked to status.counts.untracked,
)
Row(
Modifier.fillMaxWidth().padding(horizontal = 8.dp, vertical = 8.dp),
horizontalArrangement = Arrangement.spacedBy(4.dp),
) {
FileFilter.entries.forEach { item ->
val isSelected = selected == item
Surface(
onClick = { onSelect(item) },
modifier = Modifier.weight(1f),
shape = RoundedCornerShape(12.dp),
color = if (isSelected) MaterialTheme.colorScheme.secondaryContainer else Color.Transparent,
border = BorderStroke(
1.dp,
if (isSelected) MaterialTheme.colorScheme.primary else MaterialTheme.colorScheme.outlineVariant,
),
) {
Box(Modifier.padding(horizontal = 3.dp, vertical = 9.dp), contentAlignment = Alignment.Center) {
Text(
"${item.name} ${counts.getValue(item)}",
style = MaterialTheme.typography.labelMedium,
maxLines = 1,
)
}
}
}
}
}
private fun GitStatus.uniqueChangeCount(): Int = counts.changes.takeIf { it >= 0 } ?: buildSet {
staged.forEach { add(it.path) }
modified.forEach { add(it.path) }
untracked.forEach { add(it.path) }
}.size
@Composable
private fun FileRow(
file: DisplayFile,
selected: Boolean,
expanded: Boolean,
mode: ContentMode,
contentState: GitContentViewState,
onToggleSelected: () -> Unit,
onOpen: (ContentMode) -> Unit,
) {
Column(Modifier.fillMaxWidth()) {
Row(
Modifier.fillMaxWidth()
.then(
if (file.filter == FileFilter.Untracked) Modifier
else Modifier.clickable { onOpen(ContentMode.Diff) },
)
.padding(horizontal = 12.dp, vertical = 7.dp),
verticalAlignment = Alignment.CenterVertically,
) {
Checkbox(
checked = selected,
onCheckedChange = { onToggleSelected() },
modifier = Modifier.semantics {
contentDescription = "Select ${file.path}"
},
)
Column(Modifier.weight(1f)) {
Text(file.path.substringAfterLast('/'), style = MaterialTheme.typography.bodyMedium, maxLines = 1, overflow = TextOverflow.Ellipsis)
file.path.substringBeforeLast('/', "").takeIf { it.isNotEmpty() }?.let {
Text(it, style = MaterialTheme.typography.labelSmall, color = MaterialTheme.colorScheme.onSurfaceVariant, maxLines = 1, overflow = TextOverflow.Ellipsis)
}
if (file.filter == FileFilter.Untracked) {
Text("Preview unavailable until staged", style = MaterialTheme.typography.labelSmall, color = MaterialTheme.colorScheme.onSurfaceVariant)
}
}
file.additions?.let { additions ->
Text("+$additions", color = Color(0xFF2E7D32), style = MaterialTheme.typography.labelSmall)
Spacer(Modifier.width(5.dp))
}
file.deletions?.let { deletions ->
Text("−$deletions", color = MaterialTheme.colorScheme.error, style = MaterialTheme.typography.labelSmall)
Spacer(Modifier.width(5.dp))
}
StatusBadge(file.filter)
if (file.filter != FileFilter.Untracked) {
Icon(if (expanded) Icons.Filled.ExpandLess else Icons.Filled.ExpandMore, if (expanded) "Collapse" else "Expand")
}
}
if (expanded && file.filter != FileFilter.Untracked) {
Row(Modifier.padding(start = 56.dp, end = 16.dp), horizontalArrangement = Arrangement.spacedBy(6.dp)) {
if (file.filter != FileFilter.Untracked) FilterChip(mode == ContentMode.Diff, { onOpen(ContentMode.Diff) }, label = { Text("Diff") })
FilterChip(mode == ContentMode.File, { onOpen(ContentMode.File) }, label = { Text("File") })
}
InlineContent(contentState, Modifier.padding(start = 16.dp, end = 16.dp, bottom = 10.dp))
}
HorizontalDivider(Modifier.padding(start = 56.dp))
}
}
@Composable
private fun StatusBadge(filter: FileFilter) {
val label = when (filter) { FileFilter.Staged -> "S"; FileFilter.Modified -> "M"; FileFilter.Untracked -> "U"; else -> "" }
val color = when (filter) { FileFilter.Staged -> MaterialTheme.colorScheme.primary; FileFilter.Modified -> MaterialTheme.colorScheme.tertiary; else -> MaterialTheme.colorScheme.secondary }
Surface(shape = CircleShape, color = color.copy(alpha = 0.14f), modifier = Modifier.padding(horizontal = 8.dp)) {
Text(label, color = color, style = MaterialTheme.typography.labelSmall, fontWeight = FontWeight.Bold, modifier = Modifier.padding(horizontal = 7.dp, vertical = 3.dp))
}
}
@Composable
private fun InlineContent(state: GitContentViewState, modifier: Modifier) {
Surface(modifier.fillMaxWidth(), shape = RoundedCornerShape(10.dp), color = MaterialTheme.colorScheme.surfaceContainerLow) {
when (state) {
GitContentViewState.Idle, GitContentViewState.Loading -> Box(Modifier.fillMaxWidth().height(100.dp), contentAlignment = Alignment.Center) { CircularProgressIndicator(Modifier.size(24.dp), strokeWidth = 2.dp) }
is GitContentViewState.Error -> Text(state.message, Modifier.padding(12.dp), color = MaterialTheme.colorScheme.error, style = MaterialTheme.typography.bodySmall)
is GitContentViewState.Diff -> MonospaceContent(state.diff.diff.ifEmpty { stringResource(R.string.git_state_no_changes) }, state.diff.truncated)
is GitContentViewState.File -> MonospaceContent(state.file.content, state.file.truncated)
}
}
}
@Composable
private fun MonospaceContent(text: String, truncated: Boolean) {
Column(Modifier.padding(12.dp)) {
if (truncated) Text(stringResource(R.string.git_state_truncated), color = MaterialTheme.colorScheme.error, style = MaterialTheme.typography.labelSmall)
Text(text, style = MaterialTheme.typography.bodySmall, fontFamily = FontFamily.Monospace, modifier = Modifier.fillMaxWidth().height(220.dp).verticalScroll(rememberScrollState()))
}
}
@Composable
private fun SelectionRail(count: Int, canWrite: Boolean, allStaged: Boolean, onStage: () -> Unit, onDiscard: () -> Unit) {
val canDiscard = canWrite && !allStaged
Surface(
Modifier.fillMaxWidth().padding(horizontal = 16.dp, vertical = 10.dp),
color = MaterialTheme.colorScheme.surfaceContainerHigh,
contentColor = MaterialTheme.colorScheme.onSurface,
shape = RoundedCornerShape(14.dp),
shadowElevation = 6.dp,
) {
Row(Modifier.padding(horizontal = 14.dp, vertical = 8.dp), verticalAlignment = Alignment.CenterVertically) {
Text("$count selected", Modifier.weight(1f), style = MaterialTheme.typography.labelLarge)
TextButton(onClick = onStage, enabled = canWrite) {
Text(
if (allStaged) "Unstage" else "Stage",
color = if (canWrite) Color(0xFF4CAF50) else MaterialTheme.colorScheme.onSurfaceVariant,
)
}
TextButton(onClick = onDiscard, enabled = canDiscard) {
Text(
stringResource(R.string.git_state_discard),
color = if (canDiscard) MaterialTheme.colorScheme.error else MaterialTheme.colorScheme.onSurfaceVariant,
)
}
}
}
}
@Composable
private fun RepositoryPrompt(modifier: Modifier, repos: List<GitRepo>, onSelect: (String) -> Unit) {
Column(modifier.fillMaxSize().padding(24.dp), verticalArrangement = Arrangement.spacedBy(10.dp)) {
Text("Choose a repository", style = MaterialTheme.typography.headlineSmall)
Text("Git actions stay scoped to the repository you select.", color = MaterialTheme.colorScheme.onSurfaceVariant)
repos.forEach { repo -> RepositoryRow(repo, false) { onSelect(repo.id) } }
}
}
@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun RepositorySheet(repos: List<GitRepo>, selectedId: String?, onDismiss: () -> Unit, onSelect: (String) -> Unit) {
ModalBottomSheet(onDismissRequest = onDismiss) {
Column(Modifier.fillMaxWidth().padding(horizontal = 16.dp).padding(bottom = 28.dp), verticalArrangement = Arrangement.spacedBy(8.dp)) {
Text("Repositories", style = MaterialTheme.typography.titleLarge, modifier = Modifier.padding(8.dp))
repos.forEach { repo -> RepositoryRow(repo, repo.id == selectedId) { onSelect(repo.id) } }
}
}
}
@Composable
private fun RepositoryRow(repo: GitRepo, selected: Boolean, onClick: () -> Unit) {
Surface(Modifier.fillMaxWidth().clickable(onClick = onClick), color = if (selected) MaterialTheme.colorScheme.secondaryContainer else Color.Transparent, shape = RoundedCornerShape(12.dp)) {
Row(Modifier.padding(14.dp), verticalAlignment = Alignment.CenterVertically) {
Icon(Icons.Filled.AccountTree, null); Spacer(Modifier.width(12.dp))
Column(Modifier.weight(1f)) {
Text(repo.name, style = MaterialTheme.typography.titleSmall)
Text(repo.currentBranch ?: repo.root, style = MaterialTheme.typography.bodySmall, color = MaterialTheme.colorScheme.onSurfaceVariant, maxLines = 1, overflow = TextOverflow.Ellipsis)
}
if (repo.dirty) Box(Modifier.size(8.dp).background(MaterialTheme.colorScheme.tertiary, CircleShape))
if (selected) { Spacer(Modifier.width(8.dp)); Icon(Icons.Filled.Check, "Selected") }
}
}
}
@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun BranchSheet(
branches: List<GitBranch>,
hasGrant: Boolean,
dirty: Boolean,
onDismiss: () -> Unit,
onSwitch: (String) -> Unit,
onStashSwitch: (String) -> Unit,
onCreate: (String, Boolean) -> Unit,
) {
var newBranch by rememberSaveable { mutableStateOf("") }
var track by rememberSaveable { mutableStateOf(false) }
ModalBottomSheet(onDismissRequest = onDismiss) {
Column(Modifier.fillMaxWidth().verticalScroll(rememberScrollState()).padding(horizontal = 16.dp).padding(bottom = 32.dp), verticalArrangement = Arrangement.spacedBy(10.dp)) {
Text(stringResource(R.string.git_state_branches), style = MaterialTheme.typography.titleLarge)
branches.forEach { branch ->
Surface(shape = RoundedCornerShape(12.dp), color = if (branch.isCurrent) MaterialTheme.colorScheme.secondaryContainer else Color.Transparent) {
Row(Modifier.fillMaxWidth().padding(12.dp), verticalAlignment = Alignment.CenterVertically) {
Column(Modifier.weight(1f)) {
Text(branch.name, fontFamily = FontFamily.Monospace, style = MaterialTheme.typography.bodyMedium)
branch.upstream?.let { Text("$it · ahead ${branch.ahead} · behind ${branch.behind}", style = MaterialTheme.typography.labelSmall, color = MaterialTheme.colorScheme.onSurfaceVariant) }
}
if (branch.isCurrent) Text(stringResource(R.string.git_state_current), color = MaterialTheme.colorScheme.primary)
else {
TextButton(onClick = { onSwitch(branch.name) }, enabled = hasGrant) { Text(stringResource(R.string.git_state_switch)) }
if (dirty) TextButton(onClick = { onStashSwitch(branch.name) }, enabled = hasGrant) { Text(stringResource(R.string.git_state_switch_stash)) }
}
}
}
}
HorizontalDivider(); Text("Create branch", style = MaterialTheme.typography.titleMedium)
OutlinedTextField(newBranch, { newBranch = it }, Modifier.fillMaxWidth(), label = { Text(stringResource(R.string.git_state_new_branch_hint)) }, singleLine = true)
Row(verticalAlignment = Alignment.CenterVertically) { Checkbox(track, { track = it }, enabled = hasGrant); Text(stringResource(R.string.git_state_track_remote)) }
Button(onClick = { onCreate(newBranch.trim(), track) }, enabled = hasGrant && newBranch.isNotBlank(), modifier = Modifier.fillMaxWidth()) { Text(stringResource(R.string.git_state_create_branch)) }
}
}
}
@Composable
private fun CommitDialog(
hasStaged: Boolean,
generating: Boolean,
generatedMessage: String,
generationNotice: String?,
pushAfter: Boolean,
onPushAfterChange: (Boolean) -> Unit,
onGenerate: () -> Unit,
onDismiss: () -> Unit,
onCommit: (String) -> Unit,
) {
var message by rememberSaveable { mutableStateOf("") }
LaunchedEffect(generatedMessage) { if (generatedMessage.isNotBlank()) message = generatedMessage }
AlertDialog(
onDismissRequest = onDismiss,
title = { Text(stringResource(R.string.git_state_commit_title)) },
text = {
Column(verticalArrangement = Arrangement.spacedBy(8.dp)) {
OutlinedTextField(
message, { message = it }, Modifier.fillMaxWidth(),
label = { Text(stringResource(R.string.git_state_commit_message_hint)) }, minLines = 3,
trailingIcon = {
IconButton(onClick = onGenerate, enabled = hasStaged && !generating) {
if (generating) CircularProgressIndicator(Modifier.size(20.dp), strokeWidth = 2.dp) else Icon(Icons.Filled.AutoAwesome, stringResource(R.string.git_state_generate_message))
}
},
)
generationNotice?.takeIf { it.isNotBlank() }?.let { Text(it, color = MaterialTheme.colorScheme.tertiary, style = MaterialTheme.typography.bodySmall) }
Row(verticalAlignment = Alignment.CenterVertically) { Checkbox(pushAfter, onPushAfterChange); Text(stringResource(R.string.git_state_push_after_commit)) }
}
},
confirmButton = { TextButton(onClick = { onCommit(message.trim()) }, enabled = hasStaged && message.isNotBlank()) { Text(stringResource(R.string.git_state_commit_confirm)) } },
dismissButton = { TextButton(onClick = onDismiss) { Text(stringResource(R.string.git_state_cancel)) } },
)
}
private sealed interface ConfirmationRequest {
data class Discard(val paths: List<String>, val deleteUntracked: Boolean, val target: GitTarget) : ConfirmationRequest
data class Push(val target: GitTarget) : ConfirmationRequest
data class DirtyCheckout(val ref: String, val target: GitTarget) : ConfirmationRequest
}
@Composable
private fun ConfirmationDialog(
request: ConfirmationRequest,
onDismiss: () -> Unit,
onDiscard: (List<String>, Boolean, GitTarget) -> Unit,
onPush: (GitTarget) -> Unit,
onCheckout: (String, GitTarget) -> Unit,
) {
val title = stringResource(when (request) {
is ConfirmationRequest.Discard -> R.string.git_state_confirm_discard_title
is ConfirmationRequest.Push -> R.string.git_state_confirm_push_title
is ConfirmationRequest.DirtyCheckout -> R.string.git_state_confirm_checkout_dirty_title
})
val text = stringResource(when (request) {
is ConfirmationRequest.Discard -> R.string.git_state_confirm_discard_text
is ConfirmationRequest.Push -> R.string.git_state_confirm_push_text
is ConfirmationRequest.DirtyCheckout -> R.string.git_state_confirm_checkout_dirty_text
})
val confirm = stringResource(when (request) {
is ConfirmationRequest.Discard -> R.string.git_state_confirm_discard_confirm
is ConfirmationRequest.Push -> R.string.git_state_confirm_push_confirm
is ConfirmationRequest.DirtyCheckout -> R.string.git_state_confirm_checkout_confirm
})
AlertDialog(
onDismissRequest = onDismiss,
title = { Text(title) }, text = { Text(text) },
confirmButton = { TextButton(onClick = {
when (request) {
is ConfirmationRequest.Discard -> onDiscard(request.paths, request.deleteUntracked, request.target)
is ConfirmationRequest.Push -> onPush(request.target)
is ConfirmationRequest.DirtyCheckout -> onCheckout(request.ref, request.target)
}
}) { Text(confirm) } },
dismissButton = { TextButton(onClick = onDismiss) { Text(stringResource(R.string.git_state_cancel)) } },
)
}
@Composable
private fun MutationBanner(mutation: GitMutationState, onClear: () -> Unit) {
when (mutation) {
GitMutationState.Idle -> Unit
is GitMutationState.InProgress -> NoticeCard("${mutation.label} in progress…", loading = true)
is GitMutationState.Success -> NoticeCard("${displayLabel(mutation.label)} completed · ${mutation.head.take(8)}")
is GitMutationState.Error -> Card(
Modifier.fillMaxWidth().padding(horizontal = 16.dp, vertical = 4.dp),
colors = CardDefaults.cardColors(containerColor = MaterialTheme.colorScheme.errorContainer),
) {
Row(Modifier.padding(start = 12.dp, end = 4.dp, top = 4.dp, bottom = 4.dp), verticalAlignment = Alignment.CenterVertically) {
Text(
"${displayLabel(mutation.label)} failed: ${mutation.message}",
modifier = Modifier.weight(1f),
color = MaterialTheme.colorScheme.onErrorContainer,
style = MaterialTheme.typography.bodySmall,
)
IconButton(onClick = onClear) { Icon(Icons.Filled.Close, "Dismiss error") }
}
}
}
}
@Composable
private fun NoticeCard(message: String, error: Boolean = false, loading: Boolean = false) {
Card(
Modifier.fillMaxWidth().padding(horizontal = 16.dp, vertical = 4.dp),
colors = CardDefaults.cardColors(containerColor = if (error) MaterialTheme.colorScheme.errorContainer else MaterialTheme.colorScheme.surfaceContainer),
) {
Row(Modifier.padding(12.dp), verticalAlignment = Alignment.CenterVertically) {
if (loading) { CircularProgressIndicator(Modifier.size(18.dp), strokeWidth = 2.dp); Spacer(Modifier.width(10.dp)) }
Text(message, color = if (error) MaterialTheme.colorScheme.onErrorContainer else MaterialTheme.colorScheme.onSurfaceVariant, style = MaterialTheme.typography.bodySmall)
}
}
}
@Composable private fun WriteGrantNotice() = NoticeCard(stringResource(R.string.git_state_write_grant_required))
@Composable
private fun GroupHeader(label: String, count: Int) {
Row(Modifier.fillMaxWidth().padding(horizontal = 16.dp, vertical = 8.dp), verticalAlignment = Alignment.CenterVertically) {
Text(label, style = MaterialTheme.typography.labelLarge, fontWeight = FontWeight.SemiBold); Spacer(Modifier.width(6.dp))
Text(count.toString(), style = MaterialTheme.typography.labelSmall, color = MaterialTheme.colorScheme.onSurfaceVariant)
}
}
@Composable
private fun EmptyFilterState(filter: FileFilter) {
Box(Modifier.fillMaxWidth().padding(48.dp), contentAlignment = Alignment.Center) {
Text(if (filter == FileFilter.All) "Working tree clean" else "No ${filter.name.lowercase()} files", color = MaterialTheme.colorScheme.onSurfaceVariant)
}
}
@Composable
private fun FullState(modifier: Modifier, loading: Boolean, title: String, detail: String? = null) {
Box(modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
Column(Modifier.padding(32.dp), horizontalAlignment = Alignment.CenterHorizontally, verticalArrangement = Arrangement.spacedBy(12.dp)) {
if (loading) CircularProgressIndicator(); Text(title, style = MaterialTheme.typography.titleMedium)
detail?.let { Text(it, color = MaterialTheme.colorScheme.onSurfaceVariant, style = MaterialTheme.typography.bodyMedium) }
}
}
}
@Composable
private fun UnavailableState(modifier: Modifier, message: String, onRetry: () -> Unit) {
val missingRoute = message.contains("404") || message.contains("No such API endpoint", true)
Box(modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
Column(Modifier.padding(32.dp), horizontalAlignment = Alignment.CenterHorizontally, verticalArrangement = Arrangement.spacedBy(12.dp)) {
Icon(Icons.Filled.Close, null, tint = MaterialTheme.colorScheme.error, modifier = Modifier.size(32.dp))
Text(if (missingRoute) "Git isn't available on this host yet" else "Git workspace unavailable", style = MaterialTheme.typography.titleMedium)
Text(
if (missingRoute) "The host advertised Git, but its API route is not currently reachable. Restart or update the Dashboard, then retry." else message.ifBlank { "The Git service did not return a usable response." },
color = MaterialTheme.colorScheme.onSurfaceVariant,
style = MaterialTheme.typography.bodyMedium,
)
Button(onClick = onRetry) { Icon(Icons.Filled.Refresh, null, Modifier.size(18.dp)); Spacer(Modifier.width(8.dp)); Text("Retry") }
}
}
}
private fun branchSummary(repo: GitRepo, branch: GitBranch?): String {
val name = branch?.name ?: repo.currentBranch ?: "Detached HEAD"
val tracking = buildList {
if ((branch?.ahead ?: 0) > 0) add("ahead ${branch?.ahead}")
if ((branch?.behind ?: 0) > 0) add("behind ${branch?.behind}")
}
return if (tracking.isEmpty()) name else "$name · ${tracking.joinToString(" · ")}"
}
private fun displayLabel(label: String): String = label.replaceFirstChar { if (it.isLowerCase()) it.titlecase() else it.toString() }
@@ -34,6 +34,7 @@ import androidx.compose.material.icons.automirrored.filled.Chat
import androidx.compose.material.icons.automirrored.filled.KeyboardArrowRight
import androidx.compose.material.icons.automirrored.filled.Message
import androidx.compose.material.icons.filled.Analytics
import androidx.compose.material.icons.filled.AccountTree
import androidx.compose.material.icons.filled.Code
import androidx.compose.material.icons.filled.Devices
import androidx.compose.material.icons.filled.Extension
@@ -190,6 +191,7 @@ fun SettingsScreen(
onNavigateToManage: () -> Unit,
onNavigateToProviderUsage: () -> Unit,
onNavigateToPlugins: () -> Unit,
onNavigateToGitWorkspace: () -> Unit,
onNavigateToChatSettings: () -> Unit,
onNavigateToTerminal: () -> Unit,
onNavigateToBridge: () -> Unit,
@@ -603,6 +605,14 @@ fun SettingsScreen(
isDarkTheme = isDarkTheme,
)
SettingsCategoryRow(
icon = Icons.Filled.AccountTree,
title = stringResource(R.string.settings_git_workspace),
subtitle = stringResource(R.string.settings_git_workspace_desc),
onClick = onNavigateToGitWorkspace,
isDarkTheme = isDarkTheme,
)
SettingsCategoryRow(
icon = Icons.AutoMirrored.Filled.Chat,
title = stringResource(R.string.settings_chat),
@@ -2412,6 +2412,16 @@ class ConnectionViewModel(application: Application) : AndroidViewModel(applicati
}
}
val showGitWorkspaceInChat: StateFlow<Boolean> =
chatInputPreferencesRepository.showGitWorkspaceInChat
.stateIn(viewModelScope, SharingStarted.Eagerly, true)
fun setShowGitWorkspaceInChat(enabled: Boolean) {
viewModelScope.launch {
chatInputPreferencesRepository.setShowGitWorkspaceInChat(enabled)
}
}
// Turn-complete notification (default ON). RelayApp mirrors this into
// ChatViewModel.notifyOnTurnComplete; ChatSettingsScreen owns the toggle
// + the POST_NOTIFICATIONS runtime request on first enable.
@@ -0,0 +1,522 @@
package com.hermesandroid.relay.viewmodel
import android.app.Application
import androidx.lifecycle.AndroidViewModel
import androidx.lifecycle.viewModelScope
import com.hermesandroid.relay.data.GitBranch
import com.hermesandroid.relay.data.GitDiff
import com.hermesandroid.relay.data.GitFile
import com.hermesandroid.relay.data.GitRepo
import com.hermesandroid.relay.data.GitStateApiClient
import com.hermesandroid.relay.data.GitStatus
import com.hermesandroid.relay.network.upstream.DashboardApiClient
import kotlinx.coroutines.Job
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.asStateFlow
import kotlinx.coroutines.launch
sealed interface GitStateUiState {
data object Loading : GitStateUiState
data class Unavailable(val message: String) : GitStateUiState
data class Error(val message: String) : GitStateUiState
data class Ready(val repos: List<GitRepo>, val notice: String?) : GitStateUiState
}
sealed interface GitRepoDetailState {
data object Idle : GitRepoDetailState
data object Loading : GitRepoDetailState
data class Error(val message: String) : GitRepoDetailState
data class Ready(
val status: GitStatus,
val branches: List<GitBranch>,
) : GitRepoDetailState
}
sealed interface GitContentViewState {
data object Idle : GitContentViewState
data object Loading : GitContentViewState
data class Error(val message: String) : GitContentViewState
data class Diff(val diff: GitDiff) : GitContentViewState
data class File(val file: GitFile) : GitContentViewState
}
/** A single in-flight or completed write mutation on the selected repo. */
sealed interface GitMutationState {
data object Idle : GitMutationState
data class InProgress(val label: String) : GitMutationState
data class Error(val label: String, val message: String) : GitMutationState
data class Success(val label: String, val head: String) : GitMutationState
}
/** A commit-message generation attempt (AI magic-wand). */
sealed interface GitMessageGenerationState {
data object Idle : GitMessageGenerationState
data object Loading : GitMessageGenerationState
data class Ready(val message: String, val notice: String) : GitMessageGenerationState
}
/** Fixed per-use confirmation tokens matching the plugin's server constants. */
object GitConfirmationStrings {
const val DISCARD = "discard"
const val PUSH = "push"
const val DIRTY_CHECKOUT = "checkout-dirty"
}
data class GitTarget(
val scopeKey: String,
val repoId: String,
val generation: Long,
)
/**
* View model for the Git State Android surface (read + write).
*
* Loads the scanned repo list from the Hermes-Relay plugin and, on selection,
* fetches working-tree status + branches. Mutations (stage/unstage/discard/
* commit/fetch/pull/push/checkout) all require the ``plugin.api.write`` grant:
* ``configure`` binds one connection/profile/Dashboard owner and every mutation
* refuses (surfacing a readable message, never a POST) when that owner's grant
* is absent. Destructive ops
* (discard/push/dirty-checkout) additionally require a per-use confirmation
* string the caller echoes from GitConfirmationStrings.
*/
class GitStateViewModel(application: Application) : AndroidViewModel(application) {
private val _repos = MutableStateFlow<GitStateUiState>(GitStateUiState.Loading)
val repos: StateFlow<GitStateUiState> = _repos.asStateFlow()
private val _detail = MutableStateFlow<GitRepoDetailState>(GitRepoDetailState.Idle)
val detail: StateFlow<GitRepoDetailState> = _detail.asStateFlow()
private val _content = MutableStateFlow<GitContentViewState>(GitContentViewState.Idle)
val content: StateFlow<GitContentViewState> = _content.asStateFlow()
private val _mutation = MutableStateFlow<GitMutationState>(GitMutationState.Idle)
val mutation: StateFlow<GitMutationState> = _mutation.asStateFlow()
private val _messageGeneration =
MutableStateFlow<GitMessageGenerationState>(GitMessageGenerationState.Idle)
val messageGeneration: StateFlow<GitMessageGenerationState> = _messageGeneration.asStateFlow()
private val _pushAfterCommit = MutableStateFlow(false)
val pushAfterCommit: StateFlow<Boolean> = _pushAfterCommit.asStateFlow()
private val _stashNotice = MutableStateFlow<String?>(null)
val stashNotice: StateFlow<String?> = _stashNotice.asStateFlow()
private val _writeGrant = MutableStateFlow(false)
val writeGrant: StateFlow<Boolean> = _writeGrant.asStateFlow()
private val _selectedRepoId = MutableStateFlow<String?>(null)
val selectedRepoId: StateFlow<String?> = _selectedRepoId.asStateFlow()
private var api: GitStateApiClient? = null
private var reposJob: Job? = null
private var detailJob: Job? = null
private var contentJob: Job? = null
private var mutationJob: Job? = null
private var messageJob: Job? = null
private var scopeKey: String? = null
private var targetGeneration: Long = 0
fun selectedRepoIdForDisplay(): String? = _selectedRepoId.value
fun currentTarget(): GitTarget? {
val owner = scopeKey ?: return null
val repo = _selectedRepoId.value ?: return null
return GitTarget(owner, repo, targetGeneration)
}
fun configure(dashboard: DashboardApiClient?, ownerKey: String?) {
reposJob?.cancel()
detailJob?.cancel()
contentJob?.cancel()
mutationJob?.cancel()
messageJob?.cancel()
targetGeneration += 1
scopeKey = ownerKey
_selectedRepoId.value = null
_writeGrant.value = false
_detail.value = GitRepoDetailState.Idle
_content.value = GitContentViewState.Idle
_mutation.value = GitMutationState.Idle
_messageGeneration.value = GitMessageGenerationState.Idle
_stashNotice.value = null
api = dashboard?.let(::GitStateApiClient)
loadRepos()
}
/** Grants the plugin.api.write capability for this connection/profile. */
fun setWriteGrant(ownerKey: String?, granted: Boolean) {
if (ownerKey != scopeKey) return
_writeGrant.value = granted
}
fun hasWriteGrant(): Boolean = _writeGrant.value
fun loadRepos() {
val client = api ?: run {
_repos.value = GitStateUiState.Error("Dashboard connection unavailable")
return
}
val expectedScope = scopeKey
reposJob?.cancel()
reposJob = viewModelScope.launch {
_repos.value = GitStateUiState.Loading
client.repos().fold(
onSuccess = { list ->
if (scopeKey == expectedScope) {
_repos.value = GitStateUiState.Ready(list, null)
}
},
onFailure = { error ->
if (scopeKey == expectedScope) {
val message = error.message.orEmpty()
_repos.value = if (
message.contains("HTTP 404", ignoreCase = true) ||
message.contains("No such API endpoint", ignoreCase = true)
) {
GitStateUiState.Unavailable(
"Git isn't available on this Hermes host yet.",
)
} else {
GitStateUiState.Error(message.ifBlank { "Failed to load repositories" })
}
}
},
)
}
}
fun selectRepo(repoId: String) {
val client = api ?: return
targetGeneration += 1
_selectedRepoId.value = repoId
val target = currentTarget() ?: return
_content.value = GitContentViewState.Idle
_mutation.value = GitMutationState.Idle
detailJob?.cancel()
contentJob?.cancel()
detailJob = viewModelScope.launch {
_detail.value = GitRepoDetailState.Loading
val statusResult = client.status(repoId)
val branchesResult = client.branches(repoId)
if (currentTarget() != target) return@launch
if (statusResult.isFailure) {
_detail.value = GitRepoDetailState.Error(
statusResult.exceptionOrNull()?.message ?: "Failed to load status",
)
return@launch
}
val status: GitStatus = statusResult.getOrThrow()
val branches: List<GitBranch> = branchesResult.getOrDefault(emptyList())
_detail.value = GitRepoDetailState.Ready(status, branches)
}
}
/** Runs one owner/repository-bound mutation without cancelling another mutation. */
private fun runMutation(
label: String,
expectedTarget: GitTarget? = null,
onSuccess: (GitTarget) -> Unit = {},
block: suspend (GitStateApiClient, String) -> Result<GitMutationState>,
) {
val client = api ?: run {
_mutation.value = GitMutationState.Error(label, "Dashboard connection unavailable")
return
}
val target = currentTarget() ?: run {
_mutation.value = GitMutationState.Error(label, "No repository selected")
return
}
if (expectedTarget != null && expectedTarget != target) {
_mutation.value = GitMutationState.Error(label, "Repository context changed; review the action again.")
return
}
if (!_writeGrant.value) {
_mutation.value = GitMutationState.Error(
label,
"Allow plugin changes (plugin.api.write) before using this action.",
)
return
}
if (mutationJob?.isActive == true) {
_mutation.value = GitMutationState.Error(label, "Another Git action is still in progress.")
return
}
detailJob?.cancel()
contentJob?.cancel()
mutationJob = viewModelScope.launch {
_mutation.value = GitMutationState.InProgress(label)
block(client, target.repoId).fold(
onSuccess = {
if (currentTarget() != target) return@fold
_mutation.value = it
_content.value = GitContentViewState.Idle
refreshDetail(client, target)
onSuccess(target)
},
onFailure = { error ->
if (currentTarget() == target) {
_mutation.value = GitMutationState.Error(
label,
error.message ?: "Git action failed",
)
}
},
)
}
}
private suspend fun refreshDetail(client: GitStateApiClient, target: GitTarget) {
val statusResult = client.status(target.repoId)
val branchesResult = client.branches(target.repoId)
if (currentTarget() == target && statusResult.isSuccess) {
_detail.value = GitRepoDetailState.Ready(
statusResult.getOrDefault(GitStatus()),
branchesResult.getOrDefault(emptyList()),
)
}
}
// ── Read operations ────────────────────────────────────────────────────
fun loadDiff(path: String, kind: String) {
val target = currentTarget() ?: return
val client = api ?: return
contentJob?.cancel()
contentJob = viewModelScope.launch {
_content.value = GitContentViewState.Loading
client.diff(target.repoId, path, kind).fold(
onSuccess = { diff ->
if (currentTarget() == target) {
_content.value = GitContentViewState.Diff(diff)
}
},
onFailure = { error ->
if (currentTarget() == target) {
_content.value = GitContentViewState.Error(
error.message ?: "Failed to load diff",
)
}
},
)
}
}
fun loadFile(path: String) {
val target = currentTarget() ?: return
val client = api ?: return
contentJob?.cancel()
contentJob = viewModelScope.launch {
_content.value = GitContentViewState.Loading
client.file(target.repoId, path).fold(
onSuccess = { file ->
if (currentTarget() == target) {
_content.value = GitContentViewState.File(file)
}
},
onFailure = { error ->
if (currentTarget() == target) {
_content.value = GitContentViewState.Error(
error.message ?: "Failed to load file",
)
}
},
)
}
}
// ── Write operations ───────────────────────────────────────────────────
fun stage(paths: List<String>) = runMutation("Stage") { c, r ->
c.stage(r, paths).map { GitMutationState.Success("stage", it.head) }
}
fun unstage(paths: List<String>) = runMutation("Unstage") { c, r ->
c.unstage(r, paths).map { GitMutationState.Success("unstage", it.head) }
}
fun discard(
paths: List<String>,
confirmation: String,
deleteUntracked: Boolean = false,
expectedTarget: GitTarget? = null,
) =
runMutation("Discard", expectedTarget = expectedTarget) { c, r ->
c.discard(r, paths, confirmation, deleteUntracked)
.map { GitMutationState.Success("discard", it.head) }
}
fun commit(message: String, onSuccess: (GitTarget) -> Unit = {}) =
runMutation("Commit", onSuccess = onSuccess) { c, r ->
c.commit(r, message).map {
GitMutationState.Success("commit", it.head)
}
}
fun commitSelected(message: String, paths: List<String>) = runMutation("Commit") { c, r ->
c.commitSelected(r, message, paths).map {
GitMutationState.Success("commit", it.head)
}
}
fun fetch(remote: String = "origin") = runMutation("Fetch") { c, r ->
c.fetch(r, remote).map { GitMutationState.Success("fetch", it.head) }
}
fun pull(remote: String = "origin", branch: String = "") = runMutation("Pull") { c, r ->
c.pull(r, remote, branch).map { GitMutationState.Success("pull", it.head) }
}
fun push(
confirmation: String,
remote: String = "origin",
branch: String = "",
expectedTarget: GitTarget? = null,
) =
runMutation("Push", expectedTarget = expectedTarget) { c, r ->
c.push(r, confirmation, remote, branch).map { GitMutationState.Success("push", it.head) }
}
fun checkout(
ref: String,
confirmation: String? = null,
newBranch: String = "",
track: Boolean = false,
expectedTarget: GitTarget? = null,
) = runMutation("Checkout", expectedTarget = expectedTarget) { c, r ->
c.checkout(r, ref, confirmation, newBranch, track)
.map { GitMutationState.Success("checkout", it.head) }
}
// ── Phase 3 extras ─────────────────────────────────────────────────────
/** Toggle the push-after-commit flow (default OFF; never bypasses confirm). */
fun setPushAfterCommit(enabled: Boolean) {
_pushAfterCommit.value = enabled
}
/**
* Generate a commit-message suggestion from the staged diff (AI magic-wand).
* Empty staged diff / model-unavailable degrade to a notice, never an error.
* Uses the shared write grant gate (a POST is never sent without the grant).
*/
fun generateCommitMessage(paths: List<String>? = null) {
val client = api ?: run {
_messageGeneration.value =
GitMessageGenerationState.Ready("", "Dashboard connection unavailable")
return
}
val target = currentTarget() ?: run {
_messageGeneration.value = GitMessageGenerationState.Ready("", "No repository selected")
return
}
if (!_writeGrant.value) {
_messageGeneration.value = GitMessageGenerationState.Ready(
"",
"Allow plugin changes (plugin.api.write) before using this action.",
)
return
}
messageJob?.cancel()
messageJob = viewModelScope.launch {
_messageGeneration.value = GitMessageGenerationState.Loading
val result = if (paths != null) {
client.commitMessageSelected(target.repoId, paths)
} else {
client.commitMessage(target.repoId)
}
if (currentTarget() != target) return@launch
result.fold(
onSuccess = { msg ->
_messageGeneration.value = GitMessageGenerationState.Ready(msg.message, msg.notice)
},
onFailure = { error ->
_messageGeneration.value = GitMessageGenerationState.Ready(
"",
error.message ?: "Could not generate a commit message.",
)
},
)
}
}
/**
* Checkout that auto-stashes a dirty tree first. No confirmation is needed
* because a stash is recoverable. Surfaces the stash message via [stashNotice].
*/
fun stashCheckout(ref: String, newBranch: String = "", track: Boolean = false) {
val client = api ?: run {
_mutation.value = GitMutationState.Error("Stash Checkout", "Dashboard connection unavailable")
return
}
val target = currentTarget() ?: run {
_mutation.value = GitMutationState.Error("Stash Checkout", "No repository selected")
return
}
if (!_writeGrant.value) {
_mutation.value = GitMutationState.Error(
"Stash Checkout",
"Allow plugin changes (plugin.api.write) before using this action.",
)
return
}
_stashNotice.value = null
if (mutationJob?.isActive == true) {
_mutation.value = GitMutationState.Error(
"Stash Checkout",
"Another Git action is still in progress.",
)
return
}
detailJob?.cancel()
contentJob?.cancel()
mutationJob = viewModelScope.launch {
_mutation.value = GitMutationState.InProgress("Stash Checkout")
client.stashCheckout(target.repoId, ref, newBranch, track).fold(
onSuccess = { result ->
if (currentTarget() != target) return@fold
if (result.stashed) {
_stashNotice.value =
"Stashed changes on $ref as \"${result.stashMessage}\". Use \"git stash pop\" to restore them."
}
_mutation.value = GitMutationState.Success("stash-checkout", result.head)
_content.value = GitContentViewState.Idle
refreshDetail(client, target)
},
onFailure = { error ->
if (currentTarget() == target) {
_mutation.value = GitMutationState.Error(
"Stash Checkout",
error.message ?: "Git action failed",
)
}
},
)
}
}
fun clearStashNotice() {
_stashNotice.value = null
}
/** True when the push-after-commit toggle is currently enabled. */
fun isPushAfterCommitEnabled(): Boolean = _pushAfterCommit.value
/** True when the named destructive op needs a confirmation echo. */
fun requiresConfirmation(op: String): Boolean = op in setOf("discard", "push", "dirty-checkout")
/** Fixed confirmation token for a destructive op (matches the server). */
fun confirmationFor(op: String): String? = when (op) {
"discard" -> GitConfirmationStrings.DISCARD
"push" -> GitConfirmationStrings.PUSH
"dirty-checkout" -> GitConfirmationStrings.DIRTY_CHECKOUT
else -> null
}
fun clearMutationError() {
if (_mutation.value is GitMutationState.Error) {
_mutation.value = GitMutationState.Idle
}
}
}
@@ -49,6 +49,7 @@ sealed interface PluginsHubState {
data object Disconnected : PluginsHubState
data object Loading : PluginsHubState
data class Ready(
val ownerKey: String,
val plugins: List<PluginHubItem>,
val preview: PluginCatalogPreview,
val refreshing: Boolean = false,
@@ -220,6 +221,7 @@ class PluginsViewModel(application: Application) : AndroidViewModel(application)
_hubState.value = result.fold(
onSuccess = { items ->
PluginsHubState.Ready(
ownerKey = expectedKey,
plugins = items,
preview = catalogPreview(items),
)
@@ -3858,6 +3858,48 @@
<string name="plugins_keep">Manter</string>
<string name="plugins_remove">Remover</string>
<string name="plugins_remove_confirm">Remover “%1$s”? Esta página do plugin não aparecerá mais nos dispositivos Android conectados.</string>
<string name="git_state_title">Git</string>
<string name="git_state_back">Voltar</string>
<string name="git_state_staged">Preparados</string>
<string name="git_state_modified">Modificados</string>
<string name="git_state_untracked">Não rastreados</string>
<string name="git_state_branches">Ramos</string>
<string name="git_state_truncated">Resultados truncados — apenas as primeiras entradas são exibidas.</string>
<string name="git_state_no_changes">(sem alterações)</string>
<string name="git_state_write_grant_required">Alterações de gravação exigem a permissão de alterações de plugin. Ative "Permitir alterações de plugins (plugin.api.write)" nas configurações de permissão de Plugins.</string>
<string name="git_state_stage">Preparar</string>
<string name="git_state_unstage">Despreparar</string>
<string name="git_state_discard">Descartar</string>
<string name="git_state_commit">Confirmar</string>
<string name="git_state_commit_title">Confirmar alterações preparadas</string>
<string name="git_state_commit_message_hint">Mensagem do commit</string>
<string name="git_state_commit_confirm">Confirmar</string>
<string name="git_state_cancel">Cancelar</string>
<string name="git_state_fetch">Buscar</string>
<string name="git_state_pull">Puxar</string>
<string name="git_state_push">Enviar</string>
<string name="git_state_new_branch_hint">Nome da nova ramificação</string>
<string name="git_state_create_branch">Criar ramificação</string>
<string name="git_state_track_remote">Rastrear ramificação remota</string>
<string name="git_state_switch">Alternar</string>
<string name="git_state_current">Atual</string>
<string name="git_state_mutation_in_progress">%1$s em andamento…</string>
<string name="git_state_mutation_success">%1$s concluído. HEAD %2$s</string>
<string name="git_state_mutation_failed">%1$s falhou: %2$s</string>
<string name="git_state_confirm_discard_title">Descartar alterações?</string>
<string name="git_state_confirm_discard_text">As alterações locais dos arquivos selecionados serão descartadas e não poderão ser recuperadas.</string>
<string name="git_state_confirm_discard_confirm">Descartar</string>
<string name="git_state_confirm_push_title">Enviar alterações?</string>
<string name="git_state_confirm_push_text">Envia a ramificação atual para o repositório remoto. Isso publica os commits locais no repositório remoto.</string>
<string name="git_state_confirm_push_confirm">Enviar</string>
<string name="git_state_confirm_checkout_dirty_title">Alternar ramificação com alterações locais?</string>
<string name="git_state_confirm_checkout_dirty_text">A árvore de trabalho tem alterações não confirmadas. A alternância pode carregá-las para a ramificação de destino.</string>
<string name="git_state_confirm_checkout_confirm">Alternar</string>
<string name="git_state_generate_message">Gerar mensagem de commit</string>
<string name="git_state_generating_message">Gerando mensagem de commit…</string>
<string name="git_state_push_after_commit">Enviar após o commit</string>
<string name="git_state_switch_stash">Alternar (guardar se houver alterações)</string>
<string name="support_bundle_review">Revisar informações de suporte</string>
<string name="support_bundle_title">Informações de suporte</string>
<string name="support_bundle_privacy">Nada é enviado automaticamente. Revise a exportação local com até %1$d relatórios.</string>
@@ -4223,4 +4265,13 @@
<string name="custom_theme_saved_to">Alterações salvas em %1$s</string>
<string name="custom_theme_modified">Alterações não salvas</string>
<string name="custom_theme_saved_count">%1$d temas salvos</string>
<string name="chat_settings_show_git_workspace">Mostrar o espaço de trabalho Git no chat</string>
<string name="chat_settings_show_git_workspace_desc">Mostra a branch e as alterações acima do campo de mensagem</string>
<string name="chat_git_open_workspace">Abrir o espaço de trabalho Git</string>
<string name="chat_git_branch">Branch %1$s</string>
<string name="chat_git_additions">%1$d adições</string>
<string name="chat_git_deletions">%1$d exclusões</string>
<plurals name="chat_git_change_count"><item quantity="one">%1$d alteração</item><item quantity="other">%1$d alterações</item></plurals>
<string name="settings_git_workspace">Espaço de trabalho Git</string>
<string name="settings_git_workspace_desc">Revise alterações, branches, commits e remotos</string>
</resources>
@@ -3946,6 +3946,48 @@
<string name="plugins_keep">保留</string>
<string name="plugins_remove">移除</string>
<string name="plugins_remove_confirm">要移除“%1$s”吗?此插件页面将不再显示在已连接的 Android 设备上。</string>
<string name="git_state_title">Git</string>
<string name="git_state_back">返回</string>
<string name="git_state_staged">已暂存</string>
<string name="git_state_modified">已修改</string>
<string name="git_state_untracked">未跟踪</string>
<string name="git_state_branches">分支</string>
<string name="git_state_truncated">结果已截断 — 仅显示前几条。</string>
<string name="git_state_no_changes">(无更改)</string>
<string name="git_state_write_grant_required">写入更改需要插件更改权限。请在“插件”的权限设置中启用“允许插件更改 (plugin.api.write)”。</string>
<string name="git_state_stage">暂存</string>
<string name="git_state_unstage">取消暂存</string>
<string name="git_state_discard">丢弃</string>
<string name="git_state_commit">提交</string>
<string name="git_state_commit_title">提交已暂存的更改</string>
<string name="git_state_commit_message_hint">提交消息</string>
<string name="git_state_commit_confirm">提交</string>
<string name="git_state_cancel">取消</string>
<string name="git_state_fetch">获取</string>
<string name="git_state_pull">拉取</string>
<string name="git_state_push">推送</string>
<string name="git_state_new_branch_hint">新分支名称</string>
<string name="git_state_create_branch">创建分支</string>
<string name="git_state_track_remote">跟踪远程分支</string>
<string name="git_state_switch">切换</string>
<string name="git_state_current">当前</string>
<string name="git_state_mutation_in_progress">%1$s 正在进行…</string>
<string name="git_state_mutation_success">%1$s 已完成。HEAD %2$s</string>
<string name="git_state_mutation_failed">%1$s 失败:%2$s</string>
<string name="git_state_confirm_discard_title">丢弃更改?</string>
<string name="git_state_confirm_discard_text">所选文件的本地更改将被丢弃,且无法恢复。</string>
<string name="git_state_confirm_discard_confirm">丢弃</string>
<string name="git_state_confirm_push_title">推送更改?</string>
<string name="git_state_confirm_push_text">将当前分支推送到其远程仓库。这会把本地提交发送到远程仓库。</string>
<string name="git_state_confirm_push_confirm">推送</string>
<string name="git_state_confirm_checkout_dirty_title">切换包含本地更改的分支?</string>
<string name="git_state_confirm_checkout_dirty_text">工作区有未提交的更改。切换后,这些更改可能会被带到目标分支。</string>
<string name="git_state_confirm_checkout_confirm">切换</string>
<string name="git_state_generate_message">生成提交信息</string>
<string name="git_state_generating_message">正在生成提交信息…</string>
<string name="git_state_push_after_commit">提交后推送</string>
<string name="git_state_switch_stash">切换(有更改时暂存)</string>
<string name="support_bundle_review">查看支持信息</string>
<string name="support_bundle_title">支持信息</string>
<string name="support_bundle_privacy">不会自动上传任何内容。请查看最多包含 %1$d 个报告的本地导出。</string>
@@ -4308,4 +4350,13 @@
<string name="custom_theme_saved_to">更改已保存到 %1$s</string>
<string name="custom_theme_modified">未保存的更改</string>
<string name="custom_theme_saved_count">已保存 %1$d 个预设</string>
<string name="chat_settings_show_git_workspace">在聊天中显示 Git 工作区</string>
<string name="chat_settings_show_git_workspace_desc">在输入框上方显示分支和更改</string>
<string name="chat_git_open_workspace">打开 Git 工作区</string>
<string name="chat_git_branch">分支 %1$s</string>
<string name="chat_git_additions">新增 %1$d 行</string>
<string name="chat_git_deletions">删除 %1$d 行</string>
<plurals name="chat_git_change_count"><item quantity="other">%1$d 个更改</item></plurals>
<string name="settings_git_workspace">Git 工作区</string>
<string name="settings_git_workspace_desc">查看更改、分支、提交和远程仓库</string>
</resources>
+51
View File
@@ -4018,6 +4018,48 @@
<string name="plugins_keep">Behalten</string>
<string name="plugins_remove">Entfernen</string>
<string name="plugins_remove_confirm">„%1$s“ entfernen? Diese Plugin-Seite wird auf verbundenen Android-Geräten nicht mehr angezeigt.</string>
<string name="git_state_title">Git</string>
<string name="git_state_back">Zurück</string>
<string name="git_state_staged">Gestaged</string>
<string name="git_state_modified">Geändert</string>
<string name="git_state_untracked">Unverfolgt</string>
<string name="git_state_branches">Branches</string>
<string name="git_state_truncated">Ergebnisse abgeschnitten – nur die ersten Einträge werden angezeigt.</string>
<string name="git_state_no_changes">(keine Änderungen)</string>
<string name="git_state_write_grant_required">Für Schreibvorgänge ist die Plugin-Änderungsberechtigung erforderlich. Aktivieren Sie „Änderungen durch Plugins zulassen (plugin.api.write)“ in den Plugin-Berechtigungseinstellungen.</string>
<string name="git_state_stage">Bereitstellen</string>
<string name="git_state_unstage">Zurücksetzen</string>
<string name="git_state_discard">Verwerfen</string>
<string name="git_state_commit">Committen</string>
<string name="git_state_commit_title">Bereitgestellte Änderungen committen</string>
<string name="git_state_commit_message_hint">Commit-Nachricht</string>
<string name="git_state_commit_confirm">Committen</string>
<string name="git_state_cancel">Abbrechen</string>
<string name="git_state_fetch">Abrufen</string>
<string name="git_state_pull">Pullen</string>
<string name="git_state_push">Pushen</string>
<string name="git_state_new_branch_hint">Name des neuen Branches</string>
<string name="git_state_create_branch">Branch erstellen</string>
<string name="git_state_track_remote">Remote-Branch verfolgen</string>
<string name="git_state_switch">Wechseln</string>
<string name="git_state_current">Aktuell</string>
<string name="git_state_mutation_in_progress">%1$s läuft…</string>
<string name="git_state_mutation_success">%1$s abgeschlossen. HEAD %2$s</string>
<string name="git_state_mutation_failed">%1$s fehlgeschlagen: %2$s</string>
<string name="git_state_confirm_discard_title">Änderungen verwerfen?</string>
<string name="git_state_confirm_discard_text">Lokale Änderungen an den ausgewählten Dateien werden verworfen und können nicht wiederhergestellt werden.</string>
<string name="git_state_confirm_discard_confirm">Verwerfen</string>
<string name="git_state_confirm_push_title">Änderungen pushen?</string>
<string name="git_state_confirm_push_text">Pushen Sie den aktuellen Branch zu seinem Remote. Dabei werden lokale Commits an das Remote-Repository gesendet.</string>
<string name="git_state_confirm_push_confirm">Pushen</string>
<string name="git_state_confirm_checkout_dirty_title">Branch mit lokalen Änderungen wechseln?</string>
<string name="git_state_confirm_checkout_dirty_text">Der Arbeitsbaum enthält nicht committete Änderungen. Beim Wechseln werden sie möglicherweise auf den Zielbranch übertragen.</string>
<string name="git_state_confirm_checkout_confirm">Wechseln</string>
<string name="git_state_generate_message">Commit-Nachricht generieren</string>
<string name="git_state_generating_message">Commit-Nachricht wird generiert…</string>
<string name="git_state_push_after_commit">Nach Commit pushen</string>
<string name="git_state_switch_stash">Wechseln (bei Änderungen stashen)</string>
<string name="support_bundle_review">Supportinformationen prüfen</string>
<string name="support_bundle_title">Supportinformationen</string>
<string name="support_bundle_privacy">Nichts wird automatisch hochgeladen. Prüfen Sie den lokalen Export mit bis zu %1$d Berichten.</string>
@@ -4383,4 +4425,13 @@
<string name="custom_theme_saved_to">Änderungen in %1$s gespeichert</string>
<string name="custom_theme_modified">Nicht gespeicherte Änderungen</string>
<string name="custom_theme_saved_count">%1$d gespeicherte Presets</string>
<string name="chat_settings_show_git_workspace">Git-Arbeitsbereich im Chat anzeigen</string>
<string name="chat_settings_show_git_workspace_desc">Zeigt Branch und Änderungen über dem Eingabefeld an</string>
<string name="chat_git_open_workspace">Git-Arbeitsbereich öffnen</string>
<string name="chat_git_branch">Branch %1$s</string>
<string name="chat_git_additions">%1$d Hinzufügungen</string>
<string name="chat_git_deletions">%1$d Löschungen</string>
<plurals name="chat_git_change_count"><item quantity="one">%1$d Änderung</item><item quantity="other">%1$d Änderungen</item></plurals>
<string name="settings_git_workspace">Git-Arbeitsbereich</string>
<string name="settings_git_workspace_desc">Änderungen, Branches, Commits und Remotes prüfen</string>
</resources>
+51
View File
@@ -3703,6 +3703,48 @@
<string name="plugins_keep">Conservar</string>
<string name="plugins_remove">Eliminar</string>
<string name="plugins_remove_confirm">¿Eliminar «%1$s»? Esta página del plugin dejará de aparecer en los dispositivos Android conectados.</string>
<string name="git_state_title">Git</string>
<string name="git_state_back">Atrás</string>
<string name="git_state_staged">Preparados</string>
<string name="git_state_modified">Modificados</string>
<string name="git_state_untracked">Sin seguimiento</string>
<string name="git_state_branches">Ramas</string>
<string name="git_state_truncated">Resultados truncados: solo se muestran las primeras entradas.</string>
<string name="git_state_no_changes">(sin cambios)</string>
<string name="git_state_write_grant_required">Los cambios de escritura requieren el permiso de cambios de plugin. Activa «Permitir cambios de plugins (plugin.api.write)» en la configuración de permisos de Plugins.</string>
<string name="git_state_stage">Preparar</string>
<string name="git_state_unstage">Quitar de preparados</string>
<string name="git_state_discard">Descartar</string>
<string name="git_state_commit">Confirmar</string>
<string name="git_state_commit_title">Confirmar cambios preparados</string>
<string name="git_state_commit_message_hint">Mensaje de confirmación</string>
<string name="git_state_commit_confirm">Confirmar</string>
<string name="git_state_cancel">Cancelar</string>
<string name="git_state_fetch">Obtener</string>
<string name="git_state_pull">Traer</string>
<string name="git_state_push">Enviar</string>
<string name="git_state_new_branch_hint">Nombre de la nueva rama</string>
<string name="git_state_create_branch">Crear rama</string>
<string name="git_state_track_remote">Seguir rama remota</string>
<string name="git_state_switch">Cambiar</string>
<string name="git_state_current">Actual</string>
<string name="git_state_mutation_in_progress">%1$s en curso…</string>
<string name="git_state_mutation_success">%1$s completado. HEAD %2$s</string>
<string name="git_state_mutation_failed">%1$s falló: %2$s</string>
<string name="git_state_confirm_discard_title">¿Descartar cambios?</string>
<string name="git_state_confirm_discard_text">Los cambios locales de los archivos seleccionados se descartarán y no podrán recuperarse.</string>
<string name="git_state_confirm_discard_confirm">Descartar</string>
<string name="git_state_confirm_push_title">¿Enviar cambios?</string>
<string name="git_state_confirm_push_text">Envía la rama actual a su remoto. Esto sube los commits locales al repositorio remoto.</string>
<string name="git_state_confirm_push_confirm">Enviar</string>
<string name="git_state_confirm_checkout_dirty_title">¿Cambiar de rama con cambios locales?</string>
<string name="git_state_confirm_checkout_dirty_text">El árbol de trabajo tiene cambios sin confirmar. Cambiar puede trasladarlos a la rama de destino.</string>
<string name="git_state_confirm_checkout_confirm">Cambiar</string>
<string name="git_state_generate_message">Generar mensaje de confirmación</string>
<string name="git_state_generating_message">Generando mensaje de confirmación…</string>
<string name="git_state_push_after_commit">Enviar después de confirmar</string>
<string name="git_state_switch_stash">Cambiar (guardar en stash si hay cambios)</string>
<string name="support_bundle_review">Revisar información de soporte</string>
<string name="support_bundle_title">Información de soporte</string>
<string name="support_bundle_privacy">Nada se sube automáticamente. Revisa la exportación local con hasta %1$d informes.</string>
@@ -4068,4 +4110,13 @@
<string name="custom_theme_saved_to">Cambios guardados en %1$s</string>
<string name="custom_theme_modified">Cambios sin guardar</string>
<string name="custom_theme_saved_count">%1$d preajustes guardados</string>
<string name="chat_settings_show_git_workspace">Mostrar el espacio de Git en el chat</string>
<string name="chat_settings_show_git_workspace_desc">Muestra la rama y los cambios encima del cuadro de texto</string>
<string name="chat_git_open_workspace">Abrir el espacio de Git</string>
<string name="chat_git_branch">Rama %1$s</string>
<string name="chat_git_additions">%1$d adiciones</string>
<string name="chat_git_deletions">%1$d eliminaciones</string>
<plurals name="chat_git_change_count"><item quantity="one">%1$d cambio</item><item quantity="other">%1$d cambios</item></plurals>
<string name="settings_git_workspace">Espacio de Git</string>
<string name="settings_git_workspace_desc">Revisa cambios, ramas, commits y remotos</string>
</resources>
+51
View File
@@ -4017,6 +4017,48 @@
<string name="plugins_keep">保持</string>
<string name="plugins_remove">削除</string>
<string name="plugins_remove_confirm">「%1$s」を削除しますか?接続された Android 端末にこのプラグインページは表示されなくなります。</string>
<string name="git_state_title">Git</string>
<string name="git_state_back">戻る</string>
<string name="git_state_staged">ステージ済み</string>
<string name="git_state_modified">変更</string>
<string name="git_state_untracked">未追跡</string>
<string name="git_state_branches">ブランチ</string>
<string name="git_state_truncated">結果は切り詰められています。最初の項目のみ表示されます。</string>
<string name="git_state_no_changes">(変更なし)</string>
<string name="git_state_write_grant_required">書き込み変更にはプラグイン変更権限が必要です。Plugins の権限設定で「プラグインの変更を許可する(plugin.api.write)」を有効にしてください。</string>
<string name="git_state_stage">ステージ</string>
<string name="git_state_unstage">ステージ解除</string>
<string name="git_state_discard">破棄</string>
<string name="git_state_commit">コミット</string>
<string name="git_state_commit_title">ステージ済みの変更をコミット</string>
<string name="git_state_commit_message_hint">コミットメッセージ</string>
<string name="git_state_commit_confirm">コミット</string>
<string name="git_state_cancel">キャンセル</string>
<string name="git_state_fetch">フェッチ</string>
<string name="git_state_pull">プル</string>
<string name="git_state_push">プッシュ</string>
<string name="git_state_new_branch_hint">新しいブランチ名</string>
<string name="git_state_create_branch">ブランチを作成</string>
<string name="git_state_track_remote">リモートブランチを追跡</string>
<string name="git_state_switch">切り替え</string>
<string name="git_state_current">現在</string>
<string name="git_state_mutation_in_progress">%1$s を実行中…</string>
<string name="git_state_mutation_success">%1$s が完了しました。HEAD %2$s</string>
<string name="git_state_mutation_failed">%1$s に失敗しました: %2$s</string>
<string name="git_state_confirm_discard_title">変更を破棄しますか?</string>
<string name="git_state_confirm_discard_text">選択したファイルへのローカル変更は破棄され、元に戻せません。</string>
<string name="git_state_confirm_discard_confirm">破棄</string>
<string name="git_state_confirm_push_title">変更をプッシュしますか?</string>
<string name="git_state_confirm_push_text">現在のブランチをリモートにプッシュします。ローカルのコミットがリモートリポジトリに送信されます。</string>
<string name="git_state_confirm_push_confirm">プッシュ</string>
<string name="git_state_confirm_checkout_dirty_title">ローカル変更のあるブランチに切り替えますか?</string>
<string name="git_state_confirm_checkout_dirty_text">作業ツリーに未コミットの変更があります。切り替えると、それらが対象ブランチへ引き継がれる可能性があります。</string>
<string name="git_state_confirm_checkout_confirm">切り替え</string>
<string name="git_state_generate_message">コミットメッセージを生成</string>
<string name="git_state_generating_message">コミットメッセージを生成中…</string>
<string name="git_state_push_after_commit">コミット後にプッシュ</string>
<string name="git_state_switch_stash">切り替え(変更があればスタッシュ)</string>
<string name="support_bundle_review">サポート情報を確認</string>
<string name="support_bundle_title">サポート情報</string>
<string name="support_bundle_privacy">自動アップロードはありません。最大 %1$d 件のレポートを含む端末内エクスポートを確認してください。</string>
@@ -4381,4 +4423,13 @@
<string name="custom_theme_saved_to">変更を %1$s に保存しました</string>
<string name="custom_theme_modified">未保存の変更</string>
<string name="custom_theme_saved_count">保存済み %1$d 件</string>
<string name="chat_settings_show_git_workspace">チャットに Git ワークスペースを表示</string>
<string name="chat_settings_show_git_workspace_desc">入力欄の上にブランチと変更内容を表示します</string>
<string name="chat_git_open_workspace">Git ワークスペースを開く</string>
<string name="chat_git_branch">ブランチ %1$s</string>
<string name="chat_git_additions">%1$d 件の追加</string>
<string name="chat_git_deletions">%1$d 件の削除</string>
<plurals name="chat_git_change_count"><item quantity="other">%1$d 件の変更</item></plurals>
<string name="settings_git_workspace">Git ワークスペース</string>
<string name="settings_git_workspace_desc">変更、ブランチ、コミット、リモートを確認</string>
</resources>
+51
View File
@@ -3739,6 +3739,48 @@
<string name="plugins_keep">Оставить</string>
<string name="plugins_remove">Удалить</string>
<string name="plugins_remove_confirm">Удалить «%1$s»? Эта страница плагина больше не будет отображаться на подключённых устройствах Android.</string>
<string name="git_state_title">Git</string>
<string name="git_state_back">Назад</string>
<string name="git_state_staged">В индексе</string>
<string name="git_state_modified">Изменённые</string>
<string name="git_state_untracked">Неотслеживаемые</string>
<string name="git_state_branches">Ветки</string>
<string name="git_state_truncated">Результаты усечены — показаны только первые записи.</string>
<string name="git_state_no_changes">(без изменений)</string>
<string name="git_state_write_grant_required">Для записи изменений требуется разрешение на изменение плагина. Включите «Разрешить изменения плагинов (plugin.api.write)» в настройках разрешений Plugins.</string>
<string name="git_state_stage">Добавить в индекс</string>
<string name="git_state_unstage">Убрать из индекса</string>
<string name="git_state_discard">Отменить</string>
<string name="git_state_commit">Коммит</string>
<string name="git_state_commit_title">Зафиксировать индексированные изменения</string>
<string name="git_state_commit_message_hint">Сообщение коммита</string>
<string name="git_state_commit_confirm">Коммит</string>
<string name="git_state_cancel">Отмена</string>
<string name="git_state_fetch">Обновить</string>
<string name="git_state_pull">Вытянуть</string>
<string name="git_state_push">Отправить</string>
<string name="git_state_new_branch_hint">Имя новой ветки</string>
<string name="git_state_create_branch">Создать ветку</string>
<string name="git_state_track_remote">Отслеживать удалённую ветку</string>
<string name="git_state_switch">Переключить</string>
<string name="git_state_current">Текущая</string>
<string name="git_state_mutation_in_progress">%1$s выполняется…</string>
<string name="git_state_mutation_success">%1$s завершено. HEAD %2$s</string>
<string name="git_state_mutation_failed">%1$s не удалось: %2$s</string>
<string name="git_state_confirm_discard_title">Отменить изменения?</string>
<string name="git_state_confirm_discard_text">Локальные изменения выбранных файлов будут отменены и их нельзя будет восстановить.</string>
<string name="git_state_confirm_discard_confirm">Отменить</string>
<string name="git_state_confirm_push_title">Отправить изменения?</string>
<string name="git_state_confirm_push_text">Отправить текущую ветку в её удалённый репозиторий. Это передаст локальные коммиты в удалённый репозиторий.</string>
<string name="git_state_confirm_push_confirm">Отправить</string>
<string name="git_state_confirm_checkout_dirty_title">Переключить ветку с локальными изменениями?</string>
<string name="git_state_confirm_checkout_dirty_text">В рабочем дереве есть незакоммиченные изменения. Переключение может перенести их в целевую ветку.</string>
<string name="git_state_confirm_checkout_confirm">Переключить</string>
<string name="git_state_generate_message">Создать сообщение коммита</string>
<string name="git_state_generating_message">Создание сообщения коммита…</string>
<string name="git_state_push_after_commit">Отправить после коммита</string>
<string name="git_state_switch_stash">Переключить (сохранить изменения, если есть)</string>
<string name="support_bundle_review">Проверить сведения для поддержки</string>
<string name="support_bundle_title">Сведения для поддержки</string>
<string name="support_bundle_privacy">Ничего не загружается автоматически. Проверьте локальный экспорт с не более чем %1$d отчётами.</string>
@@ -4110,4 +4152,13 @@
<string name="custom_theme_saved_to">Изменения сохранены в %1$s</string>
<string name="custom_theme_modified">Несохраненные изменения</string>
<string name="custom_theme_saved_count">Сохранено тем: %1$d</string>
<string name="chat_settings_show_git_workspace">Показывать рабочую область Git в чате</string>
<string name="chat_settings_show_git_workspace_desc">Показывает ветку и изменения над полем ввода</string>
<string name="chat_git_open_workspace">Открыть рабочую область Git</string>
<string name="chat_git_branch">Ветка %1$s</string>
<string name="chat_git_additions">Добавлено строк: %1$d</string>
<string name="chat_git_deletions">Удалено строк: %1$d</string>
<plurals name="chat_git_change_count"><item quantity="one">%1$d изменение</item><item quantity="few">%1$d изменения</item><item quantity="many">%1$d изменений</item><item quantity="other">%1$d изменения</item></plurals>
<string name="settings_git_workspace">Рабочая область Git</string>
<string name="settings_git_workspace_desc">Изменения, ветки, коммиты и удалённые репозитории</string>
</resources>
+57
View File
@@ -791,6 +791,16 @@
<string name="chat_settings_keep_keyboard_open_desc">Stay in the composer after sending. Turn off to dismiss the keyboard after each sent message.</string>
<string name="chat_settings_large_pastes">Convert large pastes to attachments</string>
<string name="chat_settings_large_pastes_desc">Turn pastes of 5,000 or more characters into reviewable text attachments. On by default.</string>
<string name="chat_settings_show_git_workspace">Show Git workspace in Chat</string>
<string name="chat_settings_show_git_workspace_desc">Show the Git status entry and changes rail in Chat. The full Git workspace remains available when this is off.</string>
<string name="chat_git_open_workspace">Open Git workspace</string>
<string name="chat_git_branch">Git branch %1$s</string>
<string name="chat_git_additions">%1$d additions</string>
<string name="chat_git_deletions">%1$d deletions</string>
<plurals name="chat_git_change_count">
<item quantity="one">%1$d change</item>
<item quantity="other">%1$d changes</item>
</plurals>
<string name="chat_large_paste_attached">Large paste added as a text attachment</string>
<string name="chat_large_paste_too_large">Pasted text exceeds the %1$d MB attachment limit</string>
<string name="chat_settings_physical_keyboard_enter">Physical keyboard Enter key</string>
@@ -4214,6 +4224,51 @@
<string name="plugins_keep">Keep</string>
<string name="plugins_remove">Remove</string>
<string name="plugins_remove_confirm">Remove “%1$s”? This plugin page will no longer appear on connected Android devices.</string>
<string name="git_state_title">Git</string>
<string name="git_state_back">Back</string>
<string name="git_state_staged">Staged</string>
<string name="git_state_modified">Modified</string>
<string name="git_state_untracked">Untracked</string>
<string name="git_state_branches">Branches</string>
<string name="git_state_truncated">Results truncated — showing the first entries only.</string>
<string name="git_state_no_changes">(no changes)</string>
<!-- Git write surface (Phase 2). All mutations require the plugin.api.write grant. -->
<string name="git_state_write_grant_required">Write changes require the plugin change permission. Enable “Allow plugin changes (plugin.api.write)” in the Plugins grant settings.</string>
<string name="git_state_stage">Stage</string>
<string name="git_state_unstage">Unstage</string>
<string name="git_state_discard">Discard</string>
<string name="git_state_commit">Commit</string>
<string name="git_state_commit_title">Commit staged changes</string>
<string name="git_state_commit_message_hint">Commit message</string>
<string name="git_state_commit_confirm">Commit</string>
<string name="git_state_cancel">Cancel</string>
<string name="git_state_fetch">Fetch</string>
<string name="git_state_pull">Pull</string>
<string name="git_state_push">Push</string>
<string name="git_state_new_branch_hint">New branch name</string>
<string name="git_state_create_branch">Create branch</string>
<string name="git_state_track_remote">Track remote branch</string>
<string name="git_state_switch">Switch</string>
<string name="git_state_current">Current</string>
<string name="git_state_mutation_in_progress">%1$s in progress…</string>
<string name="git_state_mutation_success">%1$s completed. HEAD %2$s</string>
<string name="git_state_mutation_failed">%1$s failed: %2$s</string>
<!-- Destructive-op confirmations (token is sent only on explicit user confirmation). -->
<string name="git_state_confirm_discard_title">Discard changes?</string>
<string name="git_state_confirm_discard_text">Local changes to the selected file(s) will be discarded and cannot be recovered.</string>
<string name="git_state_confirm_discard_confirm">Discard</string>
<string name="git_state_confirm_push_title">Push changes?</string>
<string name="git_state_confirm_push_text">Push the current branch to its remote. This sends local commits to the remote repository.</string>
<string name="git_state_confirm_push_confirm">Push</string>
<string name="git_state_confirm_checkout_dirty_title">Switch branch with local changes?</string>
<string name="git_state_confirm_checkout_dirty_text">The working tree has uncommitted changes. Switching may carry them onto the target branch.</string>
<string name="git_state_confirm_checkout_confirm">Switch</string>
<string name="git_state_generate_message">Generate commit message</string>
<string name="git_state_generating_message">Generating commit message…</string>
<string name="git_state_push_after_commit">Push after commit</string>
<string name="git_state_switch_stash">Switch (stash if dirty)</string>
<string name="support_bundle_review">Review support information</string>
<string name="support_bundle_title">Support information</string>
<string name="support_bundle_privacy">Nothing is uploaded automatically. Review the exact local export below. It contains up to %1$d recent reports.</string>
@@ -4390,4 +4445,6 @@
<string name="provider_usage_capability_relay_body">Credential pools, structured Nous balances, and OpenCode Go are provided by the Relay plugin.</string>
<string name="provider_usage_capability_basic_title">Basic usage from Hermes</string>
<string name="provider_usage_capability_basic_body">Install or update the Relay plugin for credential pools, structured Nous balances, and OpenCode Go.</string>
<string name="settings_git_workspace">Git workspace</string>
<string name="settings_git_workspace_desc">Review changes, branches, commits, and remotes</string>
</resources>
@@ -29,6 +29,25 @@ class ChatInputPreferencesTest {
assertEquals(true, repository.convertLargePastesToAttachments.first())
}
@Test
fun `Git workspace in Chat defaults on and round trips without replacing other settings`() = runTest {
val unrelatedKey = stringPreferencesKey("unrelated_git_chat_test")
val store = InMemoryChatInputDataStore(
mutablePreferencesOf(unrelatedKey to "keep-me"),
)
val repository = ChatInputPreferencesRepository(store)
assertEquals(true, repository.showGitWorkspaceInChat.first())
repository.setShowGitWorkspaceInChat(false)
assertEquals(false, repository.showGitWorkspaceInChat.first())
assertEquals("keep-me", store.data.first()[unrelatedKey])
repository.setShowGitWorkspaceInChat(true)
assertEquals(true, repository.showGitWorkspaceInChat.first())
assertEquals("keep-me", store.data.first()[unrelatedKey])
}
@Test
fun `enter defaults to send and unknown values fall back safely`() = runTest {
assertEquals(
@@ -0,0 +1,130 @@
package com.hermesandroid.relay.screenshots
import android.app.Application
import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.test.junit4.v2.createComposeRule
import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.onNodeWithContentDescription
import androidx.compose.ui.test.onRoot
import androidx.compose.ui.test.performClick
import androidx.compose.ui.unit.dp
import androidx.test.core.app.ApplicationProvider
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.github.takahirom.roborazzi.captureRoboImage
import com.hermesandroid.relay.network.upstream.DashboardApiClient
import com.hermesandroid.relay.ui.components.ChatGitContextButton
import com.hermesandroid.relay.ui.components.ChatGitWorkspaceRail
import com.hermesandroid.relay.ui.components.ChatGitWorkspaceSummary
import com.hermesandroid.relay.ui.screens.GitStateScreen
import com.hermesandroid.relay.ui.theme.HermesRelayTheme
import com.hermesandroid.relay.viewmodel.GitStateViewModel
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer
import org.junit.After
import org.junit.Before
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.annotation.Config
import org.robolectric.annotation.GraphicsMode
@RunWith(AndroidJUnit4::class)
@GraphicsMode(GraphicsMode.Mode.NATIVE)
@Config(qualifiers = "w400dp-h800dp-432dpi")
class GitWorkspaceScreenshotTest {
@get:Rule
val compose = createComposeRule()
private lateinit var server: MockWebServer
@Before
fun setUp() {
server = MockWebServer().apply { start() }
}
@After
fun tearDown() {
server.shutdown()
}
@Test
fun detailWorkspaceMatchesApprovedInformationHierarchy() {
enqueue("""{"repos":[{"id":"hermes-relay","name":"hermes-relay","root":"/srv/projects/hermes-relay","current_branch":"main","dirty":true}]}""")
enqueue(
"""{"counts":{"staged":1,"modified":1,"untracked":1,"changes":3,"additions":24,"deletions":7},"staged":[{"path":"app/src/main/kotlin/RelayApp.kt","additions":12,"deletions":3}],"modified":[{"path":"plugin/git_state.py","additions":8,"deletions":4}],"untracked":[{"path":"docs/git-workspace.md","additions":null,"deletions":null}],"truncated":false}""",
)
enqueue("""{"branches":[{"name":"main","upstream":"origin/main","ahead":1,"behind":0,"is_current":true},{"name":"dev","upstream":"origin/dev","ahead":0,"behind":0,"is_current":false}]}""")
enqueue(
"""{"path":"plugin/git_state.py","kind":"unstaged","diff":"@@ repository containment @@\n+ def is_within_repo(path):\n- return false\n+ return path.startswith(repo_root)","truncated":false}""",
)
val app = ApplicationProvider.getApplicationContext<Application>()
val viewModel = GitStateViewModel(app)
val owner = "visual-owner"
viewModel.configure(DashboardApiClient(server.url("/").toString()), owner)
viewModel.setWriteGrant(owner, true)
compose.setContent {
HermesRelayTheme(appThemeId = "hermes-relay", themePreference = "dark") {
GitStateScreen(viewModel = viewModel, onBack = {})
}
}
compose.waitUntil(5_000) {
runCatching { compose.onNodeWithText("3 changes").assertExists() }.isSuccess
}
compose.onNodeWithContentDescription("Select plugin/git_state.py").performClick()
compose.onNodeWithText("git_state.py").performClick()
compose.waitUntil(5_000) {
runCatching { compose.onNodeWithText("@@ repository containment @@", substring = true).assertExists() }.isSuccess
}
compose.onRoot().captureRoboImage("build/store-shots/15_git_workspace.png")
}
@Test
fun chatRailMatchesApprovedCompactTreatment() {
compose.setContent {
HermesRelayTheme(appThemeId = "hermes-relay", themePreference = "dark") {
Box(
Modifier.fillMaxSize().background(androidx.compose.material3.MaterialTheme.colorScheme.background),
) {
ChatGitContextButton(
onClick = {},
modifier = Modifier.align(Alignment.TopEnd).padding(16.dp),
)
Column(
Modifier.fillMaxWidth().align(Alignment.BottomCenter).padding(16.dp),
verticalArrangement = Arrangement.spacedBy(5.dp),
) {
ChatGitWorkspaceRail(
summary = ChatGitWorkspaceSummary("main", 3, 24, 7),
onClick = {},
)
Box(
Modifier.fillMaxWidth().background(
androidx.compose.material3.MaterialTheme.colorScheme.surfaceContainer,
androidx.compose.foundation.shape.RoundedCornerShape(18.dp),
).padding(vertical = 28.dp),
)
}
}
}
}
compose.onRoot().captureRoboImage("build/ui-evidence/chat-git-workspace-rail.png")
}
private fun enqueue(body: String) {
server.enqueue(
MockResponse()
.setHeader("Content-Type", "application/json")
.setBody(body),
)
}
}
@@ -0,0 +1,61 @@
package com.hermesandroid.relay.ui
import com.hermesandroid.relay.data.GitBranch
import com.hermesandroid.relay.data.GitRepo
import com.hermesandroid.relay.data.GitStatus
import com.hermesandroid.relay.data.GitStatusCounts
import com.hermesandroid.relay.data.GitStatusEntry
import com.hermesandroid.relay.viewmodel.GitRepoDetailState
import org.junit.Assert.assertEquals
import org.junit.Assert.assertNull
import org.junit.Test
class GitWorkspaceProjectionTest {
private val parent = GitRepo("parent", "projects", "/srv/projects")
private val nested = GitRepo("nested", "relay", "/srv/projects/hermes-relay")
@Test
fun exactSessionRootWinsAndCwdUsesLongestSegmentMatch() {
assertEquals(
nested,
selectGitRepoForWorkspace(listOf(parent, nested), null, nested.root, null),
)
assertEquals(
nested,
selectGitRepoForWorkspace(
listOf(parent, nested),
null,
null,
"/srv/projects/hermes-relay/app/src",
),
)
}
@Test
fun ambiguousCatalogDoesNotInventASelection() {
assertNull(selectGitRepoForWorkspace(listOf(parent, nested), null, null, null))
assertNull(selectGitRepoForWorkspace(listOf(parent, nested), nested.id, null, null))
assertEquals(parent, selectGitRepoForWorkspace(listOf(parent), null, null, null))
}
@Test
fun summaryCountsEachChangedPathOnce() {
val summary = buildChatGitWorkspaceSummary(
nested,
GitRepoDetailState.Ready(
status = GitStatus(
counts = GitStatusCounts(additions = 24, deletions = 7),
staged = listOf(GitStatusEntry("shared.kt")),
modified = listOf(GitStatusEntry("shared.kt"), GitStatusEntry("other.kt")),
untracked = listOf(GitStatusEntry("new.kt")),
),
branches = listOf(GitBranch("dev", isCurrent = true)),
),
)
assertEquals("dev", summary?.branch)
assertEquals(3, summary?.changeCount)
assertEquals(24, summary?.additions)
assertEquals(7, summary?.deletions)
}
}
@@ -5,12 +5,10 @@ import org.junit.Test
class MorphingSphereMotionPolicyTest {
@Test
fun `visible idle sphere uses lightweight ambient motion`() {
fun `every visible sphere uses smooth procedural motion`() {
assertEquals(
SphereMotionMode.AmbientLayer,
SphereMotionMode.Procedural,
sphereMotionMode(
state = SphereState.Idle,
voiceMode = false,
motionVisible = true,
fixedTime = null,
fixedColorPhase = null,
@@ -19,26 +17,14 @@ class MorphingSphereMotionPolicyTest {
}
@Test
fun `hidden or paused idle sphere is still`() {
fun `hidden or paused sphere is still`() {
assertEquals(
SphereMotionMode.Still,
sphereMotionMode(SphereState.Idle, false, false, null, null),
sphereMotionMode(false, null, null),
)
assertEquals(
SphereMotionMode.Still,
sphereMotionMode(SphereState.Idle, false, true, 0f, 0f),
)
}
@Test
fun `visible active and voice states keep procedural motion`() {
assertEquals(
SphereMotionMode.Procedural,
sphereMotionMode(SphereState.Thinking, false, true, null, null),
)
assertEquals(
SphereMotionMode.Procedural,
sphereMotionMode(SphereState.Idle, true, true, null, null),
sphereMotionMode(true, 0f, 0f),
)
}
}
@@ -0,0 +1,174 @@
package com.hermesandroid.relay.viewmodel
import android.app.Application
import androidx.test.core.app.ApplicationProvider
import com.hermesandroid.relay.network.upstream.DashboardApiClient
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.filterIsInstance
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.test.UnconfinedTestDispatcher
import kotlinx.coroutines.test.resetMain
import kotlinx.coroutines.test.setMain
import kotlinx.coroutines.withTimeout
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config
@OptIn(ExperimentalCoroutinesApi::class)
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [35])
class GitStateExtrasViewModelTest {
private val ownerKey = "connection-a\u0000default\u0000dashboard"
private val mainDispatcher = UnconfinedTestDispatcher()
private lateinit var application: Application
private lateinit var server: MockWebServer
@Before
fun setUp() {
Dispatchers.setMain(mainDispatcher)
application = ApplicationProvider.getApplicationContext()
server = MockWebServer().apply { start() }
}
@After
fun tearDown() {
server.shutdown()
Dispatchers.resetMain()
}
private fun viewModel(grant: Boolean = true): GitStateViewModel {
val vm = GitStateViewModel(application)
vm.configure(DashboardApiClient(server.url("/").toString()), ownerKey)
vm.setWriteGrant(ownerKey, grant)
return vm
}
private fun enqueueJson(body: String) {
server.enqueue(
MockResponse().setHeader("Content-Type", "application/json").setBody(body),
)
}
private fun selectAlpha(vm: GitStateViewModel) {
enqueueJson("""{"repos":[{"id":"alpha","name":"alpha","root":"/p/alpha","current_branch":"main","dirty":true}]}""")
enqueueJson("""{"counts":{"staged":1,"modified":0,"untracked":0},"staged":[{"path":"a.txt"}],"modified":[],"untracked":[],"truncated":false}""")
enqueueJson("""{"branches":[{"name":"main","upstream":"origin/main","ahead":0,"behind":0,"is_current":true}]}""")
runBlocking { withTimeout(5_000) { vm.repos.filterIsInstance<GitStateUiState.Ready>().first() } }
vm.selectRepo("alpha")
runBlocking { withTimeout(5_000) { vm.detail.filterIsInstance<GitRepoDetailState.Ready>().first() } }
repeat(3) { server.takeRequest() }
}
// ── AI commit message (magic-wand) ─────────────────────────────────────
@Test
fun `generate commit message pre-fills the suggestion via selected paths`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueueJson("""{"message":"feat: add feature","notice":""}""")
vm.generateCommitMessage(listOf("a.txt"))
val state = withTimeout(5_000) {
vm.messageGeneration.filterIsInstance<GitMessageGenerationState.Ready>().first()
}
assertEquals("feat: add feature", state.message)
assertEquals("", state.notice)
val req = server.takeRequest()
assertTrue(req.path!!.contains("/git/commit_message_selected"))
assertTrue(req.body.readUtf8().contains("a.txt"))
}
@Test
fun `generate message without grant is refused before any POST`() = runBlocking {
val vm = viewModel(grant = false)
selectAlpha(vm)
vm.generateCommitMessage(null)
val state = withTimeout(5_000) {
vm.messageGeneration.filterIsInstance<GitMessageGenerationState.Ready>().first()
}
assertTrue(state.notice.contains("plugin.api.write"))
assertEquals(3, server.requestCount)
}
@Test
fun `empty staged diff surfaces notice without error`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueueJson("""{"message":"","notice":"nothing staged"}""")
vm.generateCommitMessage(listOf("a.txt"))
val state = withTimeout(5_000) {
vm.messageGeneration.filterIsInstance<GitMessageGenerationState.Ready>().first()
}
assertEquals("", state.message)
assertEquals("nothing staged", state.notice)
}
// ── Push-after-commit toggle ───────────────────────────────────────────
@Test
fun `push after commit defaults off and toggles`() {
val vm = viewModel()
assertTrue(!vm.isPushAfterCommitEnabled())
vm.setPushAfterCommit(true)
assertTrue(vm.isPushAfterCommitEnabled())
vm.setPushAfterCommit(false)
assertTrue(!vm.isPushAfterCommitEnabled())
}
// ── Stash-checkout ─────────────────────────────────────────────────────
@Test
fun `stash checkout surfaces the stash notice on success`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueueJson(
"""{"head":"abc","stashed":true,"stash_message":"git-state: feature","status":{"counts":{"staged":0,"modified":0,"untracked":0},"staged":[],"modified":[],"untracked":[],"truncated":false},"branches":[]}""",
)
// refreshDetail fires two reads (status + branches).
enqueueJson("""{"counts":{"staged":0,"modified":0,"untracked":0},"staged":[],"modified":[],"untracked":[],"truncated":false}""")
enqueueJson("""{"branches":[]}""")
vm.stashCheckout("feature")
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Success>().first() }
val notice = withTimeout(5_000) { vm.stashNotice.first { it != null } }!!
assertTrue(notice.contains("git-state: feature"))
assertTrue(notice.contains("git stash pop"))
val req = server.takeRequest()
assertTrue(req.path!!.contains("/git/stash_checkout"))
assertTrue(req.body.readUtf8().contains("feature"))
}
@Test
fun `stash checkout without grant is refused before any POST`() = runBlocking {
val vm = viewModel(grant = false)
selectAlpha(vm)
vm.stashCheckout("feature")
val state = withTimeout(5_000) {
vm.mutation.filterIsInstance<GitMutationState.Error>().first()
}
assertTrue(state.message.contains("plugin.api.write"))
assertEquals(3, server.requestCount)
}
@Test
fun `clean stash checkout yields no stash notice`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueueJson(
"""{"head":"abc","stashed":false,"stash_message":"","status":{"counts":{"staged":0,"modified":0,"untracked":0},"staged":[],"modified":[],"untracked":[],"truncated":false},"branches":[]}""",
)
enqueueJson("""{"counts":{"staged":0,"modified":0,"untracked":0},"staged":[],"modified":[],"untracked":[],"truncated":false}""")
enqueueJson("""{"branches":[]}""")
vm.stashCheckout("feature")
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Success>().first() }
// No stash notice for a clean checkout.
assertEquals(null, vm.stashNotice.value)
}
}
@@ -0,0 +1,186 @@
package com.hermesandroid.relay.viewmodel
import android.app.Application
import androidx.test.core.app.ApplicationProvider
import com.hermesandroid.relay.network.upstream.DashboardApiClient
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.flow.filterIsInstance
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.test.UnconfinedTestDispatcher
import kotlinx.coroutines.test.resetMain
import kotlinx.coroutines.test.setMain
import kotlinx.coroutines.withTimeout
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertNotNull
import org.junit.Assert.assertNull
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config
@OptIn(ExperimentalCoroutinesApi::class)
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [35])
class GitStateViewModelTest {
private val ownerKey = "connection-a\u0000default\u0000dashboard"
private val mainDispatcher = UnconfinedTestDispatcher()
private lateinit var application: Application
private lateinit var server: MockWebServer
@Before
fun setUp() {
Dispatchers.setMain(mainDispatcher)
application = ApplicationProvider.getApplicationContext()
server = MockWebServer().apply { start() }
}
@After
fun tearDown() {
server.shutdown()
Dispatchers.resetMain()
}
private fun viewModel(): GitStateViewModel {
val vm = GitStateViewModel(application)
vm.configure(DashboardApiClient(server.url("/").toString()), ownerKey)
return vm
}
private fun enqueueJson(body: String) {
server.enqueue(
MockResponse()
.setHeader("Content-Type", "application/json")
.setBody(body),
)
}
@Test
fun `loadRepos maps repo list and notice`() = runBlocking {
enqueueJson(
"""{"repos":[{"id":"alpha","name":"alpha","root":"/p/alpha","current_branch":"main","dirty":false}],"notice":null}""",
)
val vm = viewModel()
val state = withTimeout(5_000) {
vm.repos.filterIsInstance<GitStateUiState.Ready>().first()
}
assertEquals(1, state.repos.size)
assertEquals("alpha", state.repos.single().name)
assertNotNull(vm.repos.value)
}
@Test
fun `loadRepos surfaces server error`() = runBlocking {
server.enqueue(MockResponse().setResponseCode(400).setBody("""{"detail":"unknown repository"}"""))
val vm = viewModel()
val state = withTimeout(5_000) {
vm.repos.filterIsInstance<GitStateUiState.Error>().first()
}
assertTrue(state.message.isNotBlank())
}
@Test
fun `loadRepos maps missing plugin route to friendly unavailable state`() = runBlocking {
server.enqueue(
MockResponse()
.setResponseCode(404)
.setBody("""{"detail":"No such API endpoint"}"""),
)
val vm = viewModel()
val state = withTimeout(5_000) {
vm.repos.filterIsInstance<GitStateUiState.Unavailable>().first()
}
assertEquals("Git isn't available on this Hermes host yet.", state.message)
}
@Test
fun `selectRepo loads status and branches and preserves truncation flag`() = runBlocking {
enqueueJson(
"""{"repos":[{"id":"alpha","name":"alpha","root":"/p/alpha","current_branch":"main","dirty":true}]}""",
)
// status
enqueueJson(
"""{"counts":{"staged":1,"modified":2,"untracked":3},"staged":[{"path":"a.txt"}],"modified":[],"untracked":[],"truncated":true}""",
)
// branches
enqueueJson(
"""{"branches":[{"name":"main","upstream":"origin/main","ahead":1,"behind":0,"is_current":true}]}""",
)
val vm = viewModel()
withTimeout(5_000) { vm.repos.filterIsInstance<GitStateUiState.Ready>().first() }
vm.selectRepo("alpha")
val ready = withTimeout(5_000) {
vm.detail.filterIsInstance<GitRepoDetailState.Ready>().first()
}
assertEquals(1, ready.status.counts.staged)
assertEquals(2, ready.status.counts.modified)
assertEquals(3, ready.status.counts.untracked)
assertEquals(-1, ready.status.counts.changes)
assertEquals(0, ready.status.counts.additions)
assertEquals(0, ready.status.counts.deletions)
assertNull(ready.status.staged.single().additions)
assertTrue(ready.status.truncated)
assertEquals("main", ready.branches.single().name)
assertTrue(ready.branches.single().isCurrent)
}
@Test
fun `loadDiff surfaces truncated diff`() = runBlocking {
enqueueJson("""{"repos":[{"id":"alpha","name":"alpha","root":"/p/alpha"}]}""")
enqueueJson("""{"counts":{"staged":0,"modified":1,"untracked":0},"staged":[],"modified":[{"path":"a.txt"}],"untracked":[],"truncated":false}""")
enqueueJson("""{"branches":[]}""")
enqueueJson("""{"path":"a.txt","kind":"unstaged","diff":"+change","truncated":true}""")
val vm = viewModel()
withTimeout(5_000) { vm.repos.filterIsInstance<GitStateUiState.Ready>().first() }
vm.selectRepo("alpha")
withTimeout(5_000) { vm.detail.filterIsInstance<GitRepoDetailState.Ready>().first() }
vm.loadDiff("a.txt", "unstaged")
val content = withTimeout(5_000) {
vm.content.filterIsInstance<GitContentViewState.Diff>().first()
}
assertEquals("a.txt", content.diff.path)
assertTrue(content.diff.truncated)
assertTrue(content.diff.diff.contains("change"))
}
@Test
fun `loadFile surfaces content and truncation`() = runBlocking {
enqueueJson("""{"repos":[{"id":"alpha","name":"alpha","root":"/p/alpha"}]}""")
enqueueJson("""{"counts":{"staged":0,"modified":0,"untracked":1},"staged":[],"modified":[],"untracked":[{"path":"new.txt"}],"truncated":false}""")
enqueueJson("""{"branches":[]}""")
enqueueJson("""{"path":"new.txt","content":"hello world","truncated":false}""")
val vm = viewModel()
withTimeout(5_000) { vm.repos.filterIsInstance<GitStateUiState.Ready>().first() }
vm.selectRepo("alpha")
withTimeout(5_000) { vm.detail.filterIsInstance<GitRepoDetailState.Ready>().first() }
vm.loadFile("new.txt")
val content = withTimeout(5_000) {
vm.content.filterIsInstance<GitContentViewState.File>().first()
}
assertEquals("hello world", content.file.content)
assertFalse(content.file.truncated)
}
@Test
fun `selectRepo surfaces status error for unknown repo`() = runBlocking {
enqueueJson("""{"repos":[{"id":"alpha","name":"alpha","root":"/p/alpha"}]}""")
server.enqueue(MockResponse().setResponseCode(400).setBody("""{"detail":"unknown repository: bogus"}"""))
enqueueJson("""{"branches":[]}""")
val vm = viewModel()
withTimeout(5_000) { vm.repos.filterIsInstance<GitStateUiState.Ready>().first() }
vm.selectRepo("bogus")
val error = withTimeout(5_000) {
vm.detail.filterIsInstance<GitRepoDetailState.Error>().first()
}
assertTrue(error.message.contains("unknown repository"))
}
}
@@ -0,0 +1,272 @@
package com.hermesandroid.relay.viewmodel
import android.app.Application
import androidx.test.core.app.ApplicationProvider
import com.hermesandroid.relay.network.upstream.DashboardApiClient
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.filterIsInstance
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.test.UnconfinedTestDispatcher
import kotlinx.coroutines.test.resetMain
import kotlinx.coroutines.test.setMain
import kotlinx.coroutines.withTimeout
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer
import org.junit.After
import org.junit.Assert.assertEquals
import org.junit.Assert.assertFalse
import org.junit.Assert.assertTrue
import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.annotation.Config
@OptIn(ExperimentalCoroutinesApi::class)
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [35])
class GitStateWriteViewModelTest {
private val ownerKey = "connection-a\u0000default\u0000dashboard"
private val mainDispatcher = UnconfinedTestDispatcher()
private lateinit var application: Application
private lateinit var server: MockWebServer
@Before
fun setUp() {
Dispatchers.setMain(mainDispatcher)
application = ApplicationProvider.getApplicationContext()
server = MockWebServer().apply { start() }
}
@After
fun tearDown() {
server.shutdown()
Dispatchers.resetMain()
}
private fun viewModel(grant: Boolean = true): GitStateViewModel {
val vm = GitStateViewModel(application)
vm.configure(DashboardApiClient(server.url("/").toString()), ownerKey)
vm.setWriteGrant(ownerKey, grant)
return vm
}
private fun enqueueJson(body: String) {
server.enqueue(
MockResponse()
.setHeader("Content-Type", "application/json")
.setBody(body),
)
}
/** Loads the repo list + selects ``alpha`` so a mutation has a target. */
private fun selectAlpha(vm: GitStateViewModel) {
enqueueJson("""{"repos":[{"id":"alpha","name":"alpha","root":"/p/alpha","current_branch":"main","dirty":true}]}""")
enqueueJson("""{"counts":{"staged":1,"modified":0,"untracked":0},"staged":[{"path":"a.txt"}],"modified":[],"untracked":[],"truncated":false}""")
enqueueJson("""{"branches":[{"name":"main","upstream":"origin/main","ahead":0,"behind":0,"is_current":true}]}""")
runBlocking { withTimeout(5_000) { vm.repos.filterIsInstance<GitStateUiState.Ready>().first() } }
vm.selectRepo("alpha")
runBlocking { withTimeout(5_000) { vm.detail.filterIsInstance<GitRepoDetailState.Ready>().first() } }
// Drain the three read requests (repos/status/branches) so the next
// takeRequest() returns the mutation POST we actually assert on.
repeat(3) { server.takeRequest() }
}
private fun enqueuePostSuccess(head: String) {
enqueueJson("""{"head":"$head","status":{"counts":{"staged":0,"modified":0,"untracked":0},"staged":[],"modified":[],"untracked":[],"truncated":false}}""")
// refreshDetail fires two more requests (status + branches).
enqueueJson("""{"counts":{"staged":0,"modified":0,"untracked":0},"staged":[],"modified":[],"untracked":[],"truncated":false}""")
enqueueJson("""{"branches":[]}""")
}
// ── Grant gating (security first) ──────────────────────────────────────
@Test
fun `stage without write grant is refused before any POST`() = runBlocking {
val vm = viewModel(grant = false)
selectAlpha(vm)
vm.stage(listOf("a.txt"))
val state = withTimeout(5_000) {
vm.mutation.filterIsInstance<GitMutationState.Error>().first()
}
assertTrue(state.message.contains("plugin.api.write"))
// No write POST was sent (only the 3 read requests for load/select).
assertEquals(3, server.requestCount)
}
@Test
fun `discard without write grant is refused`() = runBlocking {
val vm = viewModel(grant = false)
selectAlpha(vm)
vm.discard(listOf("a.txt"), GitConfirmationStrings.DISCARD)
val state = withTimeout(5_000) {
vm.mutation.filterIsInstance<GitMutationState.Error>().first()
}
assertTrue(state.message.contains("plugin.api.write"))
assertEquals(3, server.requestCount)
}
// ── Happy paths ────────────────────────────────────────────────────────
@Test
fun `stage sends POST and surfaces success + fresh status`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueuePostSuccess("abc123")
vm.stage(listOf("a.txt"))
val state = withTimeout(5_000) {
vm.mutation.filterIsInstance<GitMutationState.Success>().first()
}
assertEquals("stage", state.label)
assertEquals("abc123", state.head)
val req = server.takeRequest()
assertTrue(req.path!!.contains("/git/stage"))
assertTrue(req.body.readUtf8().contains("a.txt"))
}
@Test
fun `commit sends message and returns head`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueuePostSuccess("deadbeef")
vm.commit("add feature")
val state = withTimeout(5_000) {
vm.mutation.filterIsInstance<GitMutationState.Success>().first()
}
assertEquals("commit", state.label)
val req = server.takeRequest()
assertTrue(req.path!!.contains("/git/commit"))
assertTrue(req.body.readUtf8().contains("add feature"))
}
@Test
fun `commit success callback fires only after successful response`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueuePostSuccess("abc")
var committedTarget: GitTarget? = null
vm.commit("add feature") { committedTarget = it }
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Success>().first() }
assertEquals("alpha", committedTarget?.repoId)
}
@Test
fun `commit failure never invokes success callback`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
server.enqueue(MockResponse().setResponseCode(400).setBody("""{"detail":"failed"}"""))
var callbackCalled = false
vm.commit("add feature") { callbackCalled = true }
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Error>().first() }
assertFalse(callbackCalled)
}
@Test
fun `connection change revokes grant and rejects prior target`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
val priorTarget = vm.currentTarget()!!
enqueueJson("""{"repos":[]}""")
vm.configure(DashboardApiClient(server.url("/").toString()), "connection-b")
vm.setWriteGrant(ownerKey, true)
withTimeout(5_000) { vm.repos.filterIsInstance<GitStateUiState.Ready>().first() }
vm.push(GitConfirmationStrings.PUSH, expectedTarget = priorTarget)
assertFalse(vm.hasWriteGrant())
assertEquals(null, vm.currentTarget())
assertTrue(vm.mutation.value is GitMutationState.Error)
}
@Test
fun `discard echoes the fixed confirmation token`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueuePostSuccess("abc")
vm.discard(listOf("a.txt"), GitConfirmationStrings.DISCARD)
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Success>().first() }
val req = server.takeRequest()
assertTrue(req.path!!.contains("/git/discard"))
assertTrue(req.body.readUtf8().contains(GitConfirmationStrings.DISCARD))
}
@Test
fun `push echoes the confirmation token`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueuePostSuccess("abc")
vm.push(GitConfirmationStrings.PUSH)
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Success>().first() }
val req = server.takeRequest()
assertTrue(req.path!!.contains("/git/push"))
assertTrue(req.body.readUtf8().contains(GitConfirmationStrings.PUSH))
}
@Test
fun `fetch and pull send their endpoints`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
enqueuePostSuccess("abc")
vm.fetch()
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Success>().first() }
assertTrue(server.takeRequest().path!!.contains("/git/fetch"))
// Drain the two refreshDetail reads (status + branches) so the next
// takeRequest() sees only the pull POST.
repeat(2) { server.takeRequest() }
enqueuePostSuccess("xyz")
vm.pull("origin", "main")
withTimeout(5_000) { vm.mutation.filterIsInstance<GitMutationState.Success>().first() }
assertTrue(server.takeRequest().path!!.contains("/git/pull"))
}
// ── Error branches ─────────────────────────────────────────────────────
@Test
fun `commit surfaces server error as readable message`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
server.enqueue(
MockResponse().setResponseCode(400).setBody("""{"detail":"commit message must not be empty"}"""),
)
vm.commit(" ")
val state = withTimeout(5_000) {
vm.mutation.filterIsInstance<GitMutationState.Error>().first()
}
assertTrue(state.message.contains("must not be empty"))
}
@Test
fun `discard wrong confirmation surfaces server 403`() = runBlocking {
val vm = viewModel()
selectAlpha(vm)
server.enqueue(
MockResponse().setResponseCode(403).setBody("""{"detail":"confirmation did not match"}"""),
)
vm.discard(listOf("a.txt"), "wrong")
val state = withTimeout(5_000) {
vm.mutation.filterIsInstance<GitMutationState.Error>().first()
}
assertTrue(state.message.contains("confirmation") || state.message.contains("403"))
}
// ── Confirmation gating helpers ────────────────────────────────────────
@Test
fun `requiresConfirmation and confirmationFor match destructive ops`() {
val vm = viewModel()
assertTrue(vm.requiresConfirmation("discard"))
assertTrue(vm.requiresConfirmation("push"))
assertTrue(vm.requiresConfirmation("dirty-checkout"))
assertEquals(GitConfirmationStrings.DISCARD, vm.confirmationFor("discard"))
assertEquals(GitConfirmationStrings.PUSH, vm.confirmationFor("push"))
assertEquals(GitConfirmationStrings.DIRTY_CHECKOUT, vm.confirmationFor("dirty-checkout"))
assertEquals(null, vm.confirmationFor("commit"))
}
}
Binary file not shown.

After

Width:  |  Height:  |  Size: 127 KiB

+13
View File
@@ -91,6 +91,19 @@ the `relay_plugin_draft` tool to create or replace a generated declarative page.
tool accepts the same bounded schema as Android, stores JSON atomically below
`HERMES_HOME/mobile-plugins`, and rejects every `action.request`. Generated previews
therefore cannot reach Relay management APIs or acquire executable backend behavior.
The contribution ID `git` is reserved for the Relay plugin's native Git workspace;
generated drafts cannot shadow or duplicate that route.
Android presents that reserved contribution as a first-class native surface rather
than a generic declarative page. When the live plugin API confirms Git is available,
Chat can show a compact branch/change rail and a dot-only context action; **Chat →
Show Git workspace in Chat** hides those two Chat affordances without disabling the
workspace. The full native workspace remains reachable from Settings and Plugins and
owns repository/branch selection, diffs, staging, confirmed destructive actions,
commits, and remotes. Session `git_repo_root`/`cwd` metadata selects an exact matching
repository when possible; ambiguous catalogs require an explicit user choice. Mobile
discovery alone is not treated as runtime readiness: a missing Git API route renders a
retryable unavailable state instead of exposing the raw Dashboard error.
The Relay mobile manifest exposes drafts as preview pages under the authenticated
`hermes-relay` plugin namespace. Android polls the catalog every five seconds while
+16 -16
View File
@@ -13,7 +13,7 @@
"verification": "ai-translated",
"review_refs": [],
"source_sha256": {
"main": "f34c3772ee5a6b73514f4ce891cc2b5cbedcfc941798dcdf563682c725ef7bf0",
"main": "098132a6a5c94d038fd44f4768e7f9287561f5970b420c034d1c05c6232ac4ab",
"sideload": "4abff4f1069091ec2de735c3037a7ec7d77699cb4321e8511a622437bceaf7c2"
},
"surfaces": {
@@ -30,7 +30,7 @@
"guide/release-tracks.md": "1e793410f433b12f503ac1649afec8820a712aff74b38202693aa9a0d6ad0a26",
"guide/troubleshooting.md": "43677454b94dd7810adc9b685266598353b851b549b151de31cfa053cf74f6c1"
},
"website_source_sha256": "2de54aed7fd3c4e02ecbf57a4e9069ce64a3fd8d2874dc41b63732924fb354e1"
"website_source_sha256": "d2d244b8b4f51dbec1503e134acdbc5252574b38511fe1fcda1b7b0a63e5f9a3"
},
"en": {
"native_name": "English",
@@ -44,11 +44,11 @@
}
},
"es": {
"native_name": "Español",
"native_name": "Espa\u00f1ol",
"verification": "ai-translated",
"review_refs": [],
"source_sha256": {
"main": "f34c3772ee5a6b73514f4ce891cc2b5cbedcfc941798dcdf563682c725ef7bf0",
"main": "098132a6a5c94d038fd44f4768e7f9287561f5970b420c034d1c05c6232ac4ab",
"sideload": "4abff4f1069091ec2de735c3037a7ec7d77699cb4321e8511a622437bceaf7c2"
},
"surfaces": {
@@ -65,14 +65,14 @@
"guide/release-tracks.md": "1e793410f433b12f503ac1649afec8820a712aff74b38202693aa9a0d6ad0a26",
"guide/troubleshooting.md": "43677454b94dd7810adc9b685266598353b851b549b151de31cfa053cf74f6c1"
},
"website_source_sha256": "2de54aed7fd3c4e02ecbf57a4e9069ce64a3fd8d2874dc41b63732924fb354e1"
"website_source_sha256": "d2d244b8b4f51dbec1503e134acdbc5252574b38511fe1fcda1b7b0a63e5f9a3"
},
"ja": {
"native_name": "日本語",
"native_name": "\u65e5\u672c\u8a9e",
"verification": "ai-translated",
"review_refs": [],
"source_sha256": {
"main": "f34c3772ee5a6b73514f4ce891cc2b5cbedcfc941798dcdf563682c725ef7bf0",
"main": "098132a6a5c94d038fd44f4768e7f9287561f5970b420c034d1c05c6232ac4ab",
"sideload": "4abff4f1069091ec2de735c3037a7ec7d77699cb4321e8511a622437bceaf7c2"
},
"surfaces": {
@@ -89,14 +89,14 @@
"guide/release-tracks.md": "1e793410f433b12f503ac1649afec8820a712aff74b38202693aa9a0d6ad0a26",
"guide/troubleshooting.md": "43677454b94dd7810adc9b685266598353b851b549b151de31cfa053cf74f6c1"
},
"website_source_sha256": "2de54aed7fd3c4e02ecbf57a4e9069ce64a3fd8d2874dc41b63732924fb354e1"
"website_source_sha256": "d2d244b8b4f51dbec1503e134acdbc5252574b38511fe1fcda1b7b0a63e5f9a3"
},
"pt-BR": {
"native_name": "Português (Brasil)",
"native_name": "Portugu\u00eas (Brasil)",
"verification": "ai-translated",
"review_refs": [],
"source_sha256": {
"main": "f34c3772ee5a6b73514f4ce891cc2b5cbedcfc941798dcdf563682c725ef7bf0",
"main": "098132a6a5c94d038fd44f4768e7f9287561f5970b420c034d1c05c6232ac4ab",
"sideload": "4abff4f1069091ec2de735c3037a7ec7d77699cb4321e8511a622437bceaf7c2"
},
"surfaces": {
@@ -113,14 +113,14 @@
"guide/release-tracks.md": "1e793410f433b12f503ac1649afec8820a712aff74b38202693aa9a0d6ad0a26",
"guide/troubleshooting.md": "43677454b94dd7810adc9b685266598353b851b549b151de31cfa053cf74f6c1"
},
"website_source_sha256": "2de54aed7fd3c4e02ecbf57a4e9069ce64a3fd8d2874dc41b63732924fb354e1"
"website_source_sha256": "d2d244b8b4f51dbec1503e134acdbc5252574b38511fe1fcda1b7b0a63e5f9a3"
},
"ru": {
"native_name": "Русский",
"native_name": "\u0420\u0443\u0441\u0441\u043a\u0438\u0439",
"verification": "ai-translated",
"review_refs": [],
"source_sha256": {
"main": "f34c3772ee5a6b73514f4ce891cc2b5cbedcfc941798dcdf563682c725ef7bf0",
"main": "098132a6a5c94d038fd44f4768e7f9287561f5970b420c034d1c05c6232ac4ab",
"sideload": "4abff4f1069091ec2de735c3037a7ec7d77699cb4321e8511a622437bceaf7c2"
},
"surfaces": {
@@ -131,11 +131,11 @@
}
},
"zh-Hans": {
"native_name": "简体中文",
"native_name": "\u7b80\u4f53\u4e2d\u6587",
"verification": "ai-translated",
"review_refs": [],
"source_sha256": {
"main": "f34c3772ee5a6b73514f4ce891cc2b5cbedcfc941798dcdf563682c725ef7bf0",
"main": "098132a6a5c94d038fd44f4768e7f9287561f5970b420c034d1c05c6232ac4ab",
"sideload": "4abff4f1069091ec2de735c3037a7ec7d77699cb4321e8511a622437bceaf7c2"
},
"surfaces": {
@@ -152,7 +152,7 @@
"guide/release-tracks.md": "1e793410f433b12f503ac1649afec8820a712aff74b38202693aa9a0d6ad0a26",
"guide/troubleshooting.md": "43677454b94dd7810adc9b685266598353b851b549b151de31cfa053cf74f6c1"
},
"website_source_sha256": "2de54aed7fd3c4e02ecbf57a4e9069ce64a3fd8d2874dc41b63732924fb354e1"
"website_source_sha256": "d2d244b8b4f51dbec1503e134acdbc5252574b38511fe1fcda1b7b0a63e5f9a3"
}
}
}
+6
View File
@@ -108,6 +108,12 @@
"title": "Start a conversation",
"source": "assets/screenshots/supplemental/14_startup.png",
"captureNote": "Current empty-chat chrome, idle visualization, model and effort controls, and public-safe suggestions."
},
{
"id": "15_git_workspace",
"title": "Native Git workspace",
"source": "assets/screenshots/supplemental/15_git_workspace.png",
"captureNote": "Real native Git workspace with public-safe repository status, line totals, filters, selection, inline diff, branch controls, commit action, and no live host data."
}
]
}
+4 -1
View File
@@ -119,7 +119,7 @@ Play 2:1 clipping), and only mock public-safe data.
### Run
```bash
./gradlew :app:testGooglePlayDebugUnitTest --tests "*StoreScreenshotTest*"
./gradlew :app:testGooglePlayDebugUnitTest --tests "*StoreScreenshotTest*" --tests "*GitWorkspaceScreenshotTest*"
# Output: app/build/store-shots/<scene>.png (1080x2160, exactly 2:1)
```
@@ -149,6 +149,9 @@ The canonical marketing lineup intentionally exercises current product seams:
coverage beyond the two Play-listing frames.
- Supplemental `14_startup` preserves the lower-information empty-chat frame
outside the eight-slot Play lineup.
- Supplemental `15_git_workspace` renders the real native Git screen from a
deterministic plugin API fixture. It is used by README, user docs, and the
website but intentionally remains outside the eight-slot Play lineup.
### Render any view going forward
+8 -8
View File
File diff suppressed because one or more lines are too long
+337
View File
@@ -0,0 +1,337 @@
"""Read and write Git state endpoints for the Hermes-Relay dashboard plugin.
Mounted by hermes-agent at ``/api/plugins/hermes-relay/git/*``. These routes
power both the dashboard tab and the Android mobile page.
Route map
---------
Read (GET, no grant):
- ``GET /git/repos`` → scanned repo list under the configured base path
- ``GET /git/status`` → grouped working-tree status for one repo
- ``GET /git/branches`` → branch list (name, upstream, ahead/behind, current)
- ``GET /git/diff`` → per-file diff (kind=staged|unstaged)
- ``GET /git/file`` → read a tracked file
Write (POST, require the plugin's ``plugin.api.write`` grant, which the app
enforces client-side before ever sending the request — the same gate used for
every mutating plugin action in PluginsViewModel.invokeAction):
- ``POST /git/stage`` — stage path list → fresh status
- ``POST /git/unstage`` — unstage path list → fresh status
- ``POST /git/discard`` — discard paths (confirmation) → fresh status
- ``POST /git/commit`` — commit staged index (message) → {head,status}
- ``POST /git/commit_selected``— commit selected paths (message+paths)
- ``POST /git/fetch`` — fetch a remote → {branches,status}
- ``POST /git/pull`` — pull remote/branch → fresh status
- ``POST /git/push`` — push (confirmation) → {branches,status}
- ``POST /git/checkout`` — switch branch (new_branch/track; dirty→confirmation)
Destructive writes (discard, push, dirty checkout) enforce a per-use
confirmation string server-side: missing/wrong → 403. Dirty/conflict trees →
409. The HTTP mapping keeps raw stack traces and JSON dumps out of the UI.
Security
--------
- ``repo`` is an opaque id validated against the scanned allowlist; unknown
ids → 400.
- File paths are validated to reject traversal and absolute escapes.
- Remote URLs are scrubbed of embedded userinfo.
- No ``shell=True`` anywhere: every git invocation uses argument lists.
"""
from __future__ import annotations
from typing import Any
from fastapi import APIRouter, Body, HTTPException, Query
from .. import git_state
router = APIRouter(prefix="/git")
def _bad_request(exc: Exception) -> HTTPException:
return HTTPException(status_code=400, detail=str(exc))
# Structured error taxonomy → HTTP status. The UI renders ``detail`` (a
# human-readable message) plus ``code`` for styling; no raw traces/JSON dumps.
_GIT_ERROR_STATUS = {
"non-repo": 400,
"dirty": 409,
"conflict": 409,
"auth": 502,
"network": 502,
"invalid-input": 400,
"missing-confirmation": 403,
"wrong-confirmation": 403,
}
def _write_error(exc: git_state.GitError) -> HTTPException:
status = _GIT_ERROR_STATUS.get(exc.code, 400)
return HTTPException(status_code=status, detail=str(exc))
def _resolve(repo: str) -> Any:
return git_state.resolve_repo(git_state.base_path(), repo)
@router.get("/repos")
async def get_repos() -> dict[str, Any]:
"""Return the scanned repo list plus a notice when the base path is missing."""
base = git_state.base_path()
repos = git_state.scan_repos(base)
notice = None
if not base.is_dir():
notice = f"Git base path not found: {base}"
return {"repos": repos, "base_path": str(base), "notice": notice}
@router.get("/status")
async def get_status(repo: str = Query(...)) -> dict[str, Any]:
try:
return git_state.repo_status(_resolve(repo))
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.get("/branches")
async def get_branches(repo: str = Query(...)) -> dict[str, Any]:
try:
return {"branches": git_state.repo_branches(_resolve(repo))}
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.get("/diff")
async def get_diff(
repo: str = Query(...),
path: str = Query(...),
kind: str = Query("unstaged"),
) -> dict[str, Any]:
try:
return git_state.repo_diff(_resolve(repo), path, kind)
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.get("/file")
async def get_file(repo: str = Query(...), path: str = Query(...)) -> dict[str, Any]:
try:
return git_state.read_file(_resolve(repo), path)
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
# ── Write endpoints ────────────────────────────────────────────────────────
# Every write requires the plugin.api.write grant (enforced client-side). The
# router re-validates repo + paths against the allowlist/traversal rules and
# classifies git failures into a structured error the UI can render.
def _require_repo(body: dict[str, Any]) -> Any:
repo = body.get("repo")
if not isinstance(repo, str) or not repo:
raise git_state.GitStateError("repo is required")
return git_state.resolve_repo(git_state.base_path(), repo)
@router.post("/stage")
async def post_stage(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.stage(_require_repo(body), _paths(body))
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/unstage")
async def post_unstage(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.unstage(_require_repo(body), _paths(body))
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/discard")
async def post_discard(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.discard(
_require_repo(body),
_paths(body),
confirmation=body.get("confirmation"),
delete_untracked=bool(body.get("delete_untracked", False)),
)
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/commit")
async def post_commit(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.commit(_require_repo(body), _message(body))
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/commit_selected")
async def post_commit_selected(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.commit_selected(_require_repo(body), _message(body), _paths(body))
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/fetch")
async def post_fetch(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.fetch(_require_repo(body), _remote(body))
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/pull")
async def post_pull(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.pull(_require_repo(body), _remote(body), _branch(body))
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/push")
async def post_push(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
return git_state.push(
_require_repo(body),
_remote(body),
_branch(body),
confirmation=body.get("confirmation"),
)
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/checkout")
async def post_checkout(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
try:
new_branch = _str_opt(body, "new_branch")
return git_state.checkout(
_require_repo(body),
_ref(body, allow_empty=bool(new_branch)),
confirmation=body.get("confirmation"),
new_branch=new_branch,
track=bool(body.get("track", False)),
)
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/stash_checkout")
async def post_stash_checkout(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
"""Checkout that auto-stashes a dirty tree first.
Unlike a plain dirty checkout, no confirmation is required: a stash is
recoverable (``git stash pop``), so this is not a data-loss path. The
response carries ``stashed`` + ``stash_message`` so the UI can surface the
stash after a successful switch.
"""
try:
new_branch = _str_opt(body, "new_branch")
return git_state.stash_checkout(
_require_repo(body),
_ref(body, allow_empty=bool(new_branch)),
new_branch=new_branch,
track=bool(body.get("track", False)),
)
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/commit_message")
async def post_commit_message(body: dict[str, Any] = Body(...)) -> dict[str, Any]:
"""Generate a conventional-style commit message from the staged diff.
Empty staged diff → ``{message:"", notice:"nothing staged"}`` without calling
the model. A missing/failed model degrades to an empty message + a
``model unavailable`` notice — never a 500. Only staged content is sent.
"""
try:
return await git_state.commit_message(_require_repo(body))
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
@router.post("/commit_message_selected")
async def post_commit_message_selected(
body: dict[str, Any] = Body(...),
) -> dict[str, Any]:
"""Generate a message from the staged diff of the given ``paths`` only."""
try:
return await git_state.commit_message_selected(
_require_repo(body), _paths(body)
)
except git_state.GitError as exc:
raise _write_error(exc) from exc
except git_state.GitStateError as exc:
raise _bad_request(exc) from exc
def _paths(body: dict[str, Any]) -> list[str]:
paths = body.get("paths")
if not isinstance(paths, list) or not paths or not all(isinstance(p, str) for p in paths):
raise git_state.GitStateError("paths must be a non-empty list of strings")
return paths
def _message(body: dict[str, Any]) -> str:
message = body.get("message")
if not isinstance(message, str):
raise git_state.GitStateError("message is required")
return message
def _remote(body: dict[str, Any]) -> str:
remote = body.get("remote", "origin")
if not isinstance(remote, str):
raise git_state.GitStateError("remote must be a string")
return remote or "origin"
def _branch(body: dict[str, Any]) -> str:
branch = body.get("branch", "")
if not isinstance(branch, str):
raise git_state.GitStateError("branch must be a string")
return branch
def _ref(body: dict[str, Any], *, allow_empty: bool = False) -> str:
ref = body.get("ref", "" if allow_empty else None)
if not isinstance(ref, str) or (not ref and not allow_empty):
raise git_state.GitStateError("ref is required")
return ref
def _str_opt(body: dict[str, Any], key: str) -> str:
value = body.get(key)
return value if isinstance(value, str) else ""
__all__ = ["router"]
+9
View File
@@ -32,6 +32,15 @@ async def get_mobile_manifest() -> dict[str, Any]:
@router.get("/pages/{plugin_id}")
async def get_mobile_page(plugin_id: str = Path(...)) -> dict[str, Any]:
# The static read-only Git page is served directly from the git_state
# module (not the generated-page store). It carries no filesystem paths
# per the android-plugins.md document contract.
if plugin_id == "git":
from .. import git_state
document = git_state.build_git_document(git_state.base_path())
document["host_revision"] = 1
return document
try:
entry = _store().get(plugin_id)
document = dict(entry["document"])
+1
View File
@@ -142,6 +142,7 @@ def _validate_public_url(url: str) -> str:
router = APIRouter()
router.include_router(_plugin_module("dashboard.mobile_plugin_api").router)
router.include_router(_plugin_module("dashboard.git_api").router)
def _relay_unreachable(err: Exception) -> HTTPException:
+3
View File
@@ -6,6 +6,7 @@ import RelayManagement from "./tabs/RelayManagement.jsx";
import BridgeActivity from "./tabs/BridgeActivity.jsx";
import MediaInspector from "./tabs/MediaInspector.jsx";
import RemoteAccess from "./tabs/RemoteAccess.jsx";
import GitState from "./tabs/GitState.jsx";
import RelayStatusSlot from "./components/RelayStatusSlot.jsx";
import MobileConnectDialog from "./components/MobileConnectDialog.jsx";
import { Button, Switch } from "./lib/ui-shims.jsx";
@@ -19,6 +20,7 @@ const TABS = [
{ key: "activity", label: "Activity" },
{ key: "media", label: "Media" },
{ key: "remote", label: "Remote Access" },
{ key: "git", label: "Git" },
];
function readAutoRefresh() {
@@ -113,6 +115,7 @@ function RelayPluginRoot() {
{tab === "activity" && <BridgeActivity autoRefresh={autoRefresh} />}
{tab === "media" && <MediaInspector autoRefresh={autoRefresh} />}
{tab === "remote" && <RemoteAccess autoRefresh={autoRefresh} />}
{tab === "git" && <GitState autoRefresh={autoRefresh} />}
</div>
<MobileConnectDialog
open={mobileConnectOpen}
+104
View File
@@ -139,3 +139,107 @@ export function mintPairingWithMode({ mode, publicUrl, prefer, ...rest } = {}) {
body: JSON.stringify(body),
});
}
// ── Git State tab ───────────────────────────────────────────────────────────
export function getGitRepos() {
return fetchJSON("/git/repos");
}
export function getGitStatus(repo) {
return fetchJSON(`/git/status?repo=${encodeURIComponent(repo)}`);
}
export function getGitBranches(repo) {
return fetchJSON(`/git/branches?repo=${encodeURIComponent(repo)}`);
}
export function getGitDiff(repo, path, kind = "unstaged") {
return fetchJSON(
`/git/diff?repo=${encodeURIComponent(repo)}&path=${encodeURIComponent(path)}&kind=${encodeURIComponent(kind)}`,
);
}
export function getGitFile(repo, path) {
return fetchJSON(
`/git/file?repo=${encodeURIComponent(repo)}&path=${encodeURIComponent(path)}`,
);
}
// ── Git State write operations ────────────────────────────────────────────
// Every write POST goes through the authenticated Dashboard plugin namespace.
// Android separately enforces its local plugin.api.write preference before it
// calls this namespace. Destructive ops pass a per-use confirmation token.
function postGit(path, body) {
return fetchJSON(path, {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify(body),
});
}
export function gitStage(repo, paths) {
return postGit("/git/stage", { repo, paths });
}
export function gitUnstage(repo, paths) {
return postGit("/git/unstage", { repo, paths });
}
export function gitDiscard(repo, paths, confirmation, deleteUntracked = false) {
return postGit("/git/discard", {
repo,
paths,
confirmation,
delete_untracked: deleteUntracked,
});
}
export function gitCommit(repo, message) {
return postGit("/git/commit", { repo, message });
}
export function gitFetch(repo, remote = "origin") {
return postGit("/git/fetch", { repo, remote });
}
export function gitPull(repo, remote = "origin", branch = "") {
return postGit("/git/pull", { repo, remote, branch });
}
export function gitPush(repo, confirmation, remote = "origin", branch = "") {
return postGit("/git/push", { repo, remote, branch, confirmation });
}
export function gitCheckout(repo, ref, opts = {}) {
const body = {
repo,
ref,
confirmation: opts.confirmation,
new_branch: opts.newBranch || "",
track: !!opts.track,
};
return postGit("/git/checkout", body);
}
// ── Git State Phase 3 extras ───────────────────────────────────────────────
// AI commit-message suggestions + auto-stashing checkout.
export function gitCommitMessage(repo) {
return postGit("/git/commit_message", { repo });
}
export function gitCommitMessageSelected(repo, paths) {
return postGit("/git/commit_message_selected", { repo, paths });
}
export function gitStashCheckout(repo, ref, opts = {}) {
const body = {
repo,
ref,
new_branch: opts.newBranch || "",
track: !!opts.track,
};
return postGit("/git/stash_checkout", body);
}
+148
View File
@@ -0,0 +1,148 @@
// Pure data-mapping helpers for the Git State dashboard tab.
// Kept free of React/DOM so they are unit-testable with node:test.
/**
* Normalize a /git/repos response into a stable repo list.
* Accepts {repos:[...]} or a bare array.
*/
export function normalizeRepos(data) {
const list = Array.isArray(data) ? data : (data && data.repos) || [];
return list.filter((r) => r && typeof r.id === "string");
}
/**
* Normalize a /git/status response into {counts, staged, modified, untracked,
* truncated}. Missing groups become empty arrays.
*/
export function normalizeStatus(data) {
const src = data && typeof data === "object" ? data : {};
return {
counts: {
staged: Number(src.counts && src.counts.staged) || 0,
modified: Number(src.counts && src.counts.modified) || 0,
untracked: Number(src.counts && src.counts.untracked) || 0,
},
staged: Array.isArray(src.staged) ? src.staged : [],
modified: Array.isArray(src.modified) ? src.modified : [],
untracked: Array.isArray(src.untracked) ? src.untracked : [],
truncated: !!src.truncated,
};
}
/**
* Normalize a /git/branches response into a branch list.
* Accepts {branches:[...]} or a bare array.
*/
export function normalizeBranches(data) {
const list = Array.isArray(data) ? data : (data && data.branches) || [];
return list.filter((b) => b && typeof b.name === "string");
}
/**
* Build a human-readable branch label, e.g. "main → origin/main (ahead 1)".
*/
export function branchLabel(branch) {
if (!branch) return "";
const base = branch.name || "";
if (!branch.upstream) return base;
const track =
branch.ahead > 0 || branch.behind > 0
? ` (ahead ${branch.ahead}, behind ${branch.behind})`
: "";
return `${base} → ${branch.upstream}${track}`;
}
/**
* True when a status response is truncated (over the server cap).
*/
export function isTruncated(status) {
return !!(status && status.truncated);
}
/**
* Fixed per-use confirmation tokens for destructive git mutations. These
* mirror the plugin's server-side constants (plugin/git_state.py) and are
* sent in the POST body so the server can enforce the destructive gate.
* The dashboard tab shows a human-readable description before echoing these.
*/
export const CONFIRMATIONS = {
discard: "discard",
push: "push",
dirtyCheckout: "checkout-dirty",
};
/** Ops that require a per-use confirmation string before the POST is sent. */
const DESTRUCTIVE_OPS = new Set(["discard", "push", "dirty-checkout"]);
/**
* True when the named mutation requires a per-use confirmation string.
* The tab must not send the POST without it (matches the server gate).
*/
export function requiresConfirmation(op) {
return DESTRUCTIVE_OPS.has(op);
}
/**
* Return the fixed confirmation token for a destructive op, or null when the
* op is non-destructive (no confirmation needed).
*/
export function confirmationFor(op) {
if (!requiresConfirmation(op)) return null;
if (op === "discard") return CONFIRMATIONS.discard;
if (op === "push") return CONFIRMATIONS.push;
return CONFIRMATIONS.dirtyCheckout;
}
/**
* Normalize a mutation response ({head, status, branches}) into a stable
* shape, filling missing groups so the tab can render without defensive
* branching.
*/
export function normalizeMutationResult(data) {
const src = data && typeof data === "object" ? data : {};
return {
head: typeof src.head === "string" ? src.head : "",
status: normalizeStatus(src.status),
branches: normalizeBranches(src.branches),
};
}
/**
* Normalize a /git/commit_message response into {message, notice, stashed}.
* Missing fields degrade safely so the tab can render without branching.
*/
export function normalizeCommitMessage(data) {
const src = data && typeof data === "object" ? data : {};
return {
message: typeof src.message === "string" ? src.message : "",
notice: typeof src.notice === "string" ? src.notice : "",
};
}
/**
* True when a commit-message suggestion is usable (non-empty message).
*/
export function hasCommitSuggestion(result) {
return !!(result && result.message && result.message.trim());
}
export function isCurrentRepoRequest(currentRepo, currentGeneration, repo, generation) {
return currentRepo === repo && currentGeneration === generation;
}
export function shouldOfferPushAfterCommit(commitSucceeded, pushAfterCommit) {
return commitSucceeded === true && pushAfterCommit === true;
}
/**
* Normalize a /git/stash_checkout response: the standard mutation shape plus
* {stashed, stash_message}.
*/
export function normalizeStashCheckout(data) {
const src = data && typeof data === "object" ? data : {};
return {
...normalizeMutationResult(data),
stashed: !!src.stashed,
stashMessage: typeof src.stash_message === "string" ? src.stash_message : "",
};
}
+760
View File
@@ -0,0 +1,760 @@
const SDK = window.__HERMES_PLUGIN_SDK__;
const { React } = SDK;
const { useState, useEffect, useCallback, useRef } = SDK.hooks;
import {
getGitRepos,
getGitStatus,
getGitBranches,
getGitDiff,
getGitFile,
gitStage,
gitUnstage,
gitDiscard,
gitCommit,
gitCommitMessage,
gitCommitMessageSelected,
gitStashCheckout,
gitFetch,
gitPull,
gitPush,
gitCheckout,
} from "../lib/api.js";
import {
normalizeMutationResult,
normalizeCommitMessage,
normalizeStashCheckout,
hasCommitSuggestion,
requiresConfirmation,
confirmationFor,
isCurrentRepoRequest,
shouldOfferPushAfterCommit,
} from "../lib/git-state.mjs";
import {
Alert,
AlertTitle,
AlertDescription,
CardDescription,
Button,
Badge,
Table,
TableHeader,
TableBody,
TableRow,
TableHead,
TableCell,
} from "../lib/ui-shims.jsx";
const {
Card,
CardHeader,
CardTitle,
CardContent,
Label,
} = SDK.components;
function TruncationNotice({ truncated }) {
if (!truncated) return null;
return (
<div className="rounded-md border border-amber-500/40 bg-amber-500/10 p-2 text-xs text-amber-600">
Results truncated — showing the first entries only.
</div>
);
}
function StatusRow({ status }) {
if (!status) return null;
const counts = status.counts || {};
return (
<div className="space-y-2">
<div className="flex flex-wrap gap-2">
<Badge variant="outline" className="text-xs">
{counts.staged || 0} staged
</Badge>
<Badge variant="outline" className="text-xs">
{counts.modified || 0} modified
</Badge>
<Badge variant="outline" className="text-xs">
{counts.untracked || 0} untracked
</Badge>
</div>
<TruncationNotice truncated={status.truncated} />
{["staged", "modified", "untracked"].map((group) => {
const items = status[group] || [];
if (items.length === 0) return null;
return (
<div key={group}>
<div className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
{group}
</div>
<ul className="mt-1 space-y-0.5">
{items.map((item) => (
<li key={`${group}-${item.path}`} className="font-mono text-xs">
{item.path}
</li>
))}
</ul>
</div>
);
})}
</div>
);
}
function BranchesRow({ branches }) {
if (!branches || branches.length === 0) return null;
return (
<div className="space-y-1">
{branches.map((b) => (
<div key={b.name} className="flex items-center gap-2 text-xs">
<span className="font-mono">{b.name}</span>
{b.is_current ? <Badge className="text-xs">current</Badge> : null}
{b.upstream ? (
<span className="text-muted-foreground">
→ {b.upstream}
{b.ahead > 0 || b.behind > 0
? ` (ahead ${b.ahead}, behind ${b.behind})`
: ""}
</span>
) : null}
</div>
))}
</div>
);
}
/**
* Write controls for the authenticated Dashboard Git tab. Destructive ops
* (discard/push/dirty-checkout) are confirmed via the per-use confirmation
* mechanics before the POST is sent.
*/
function WriteControls({
status,
selected,
commitMessage,
onCommitMessageChange,
generatingMessage,
onGenerateMessage,
commitNotice,
newBranch,
onNewBranchChange,
branchRef,
onBranchRefChange,
mutating,
pushAfterCommit,
onPushAfterCommitChange,
onStageAll,
onUnstageAll,
onDiscardAll,
onStage,
onUnstage,
onDiscard,
onCommit,
onFetch,
onPull,
onPush,
onCheckout,
onStashCheckout,
}) {
const staged = (status && status.staged || []).map((e) => e.path);
const modified = (status && status.modified || []).map((e) => e.path);
return (
<div className="space-y-3 rounded-md border p-3">
<div className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
Write controls
</div>
<div className="flex flex-wrap gap-2">
<Button size="sm" variant="outline" disabled={mutating || modified.length === 0} onClick={onStageAll}>
Stage modified
</Button>
<Button size="sm" variant="outline" disabled={mutating || staged.length === 0} onClick={onUnstageAll}>
Unstage staged
</Button>
<Button size="sm" variant="outline" disabled={mutating || staged.length === 0} onClick={onDiscardAll}>
Discard staged
</Button>
</div>
<div className="space-y-2">
<div className="flex items-center gap-2">
<input
type="text"
value={commitMessage}
onChange={(e) => onCommitMessageChange(e.target.value)}
placeholder="Commit message"
className="w-full rounded-md border px-2 py-1 text-xs"
/>
<Button
size="sm"
variant="outline"
disabled={mutating || generatingMessage || staged.length === 0}
onClick={onGenerateMessage}
title="Generate a commit message from the staged diff"
>
{generatingMessage ? "Generating…" : "Generate"}
</Button>
</div>
{commitNotice ? (
<div className="text-xs text-amber-600">{commitNotice}</div>
) : null}
<div className="flex items-center gap-2">
<label className="flex items-center gap-2 text-xs">
<input
type="checkbox"
checked={pushAfterCommit}
onChange={(e) => onPushAfterCommitChange(e.target.checked)}
/>
Push after commit
</label>
<Button size="sm" disabled={mutating || !commitMessage.trim()} onClick={onCommit}>
Commit
</Button>
</div>
</div>
<div className="flex flex-wrap items-center gap-2">
<input
type="text"
value={branchRef}
onChange={(e) => onBranchRefChange(e.target.value)}
placeholder="Branch to switch to"
className="w-40 rounded-md border px-2 py-1 text-xs"
/>
<input
type="text"
value={newBranch}
onChange={(e) => onNewBranchChange(e.target.value)}
placeholder="New branch name"
className="w-40 rounded-md border px-2 py-1 text-xs"
/>
<Button size="sm" variant="outline" disabled={mutating || !branchRef.trim()} onClick={onCheckout}>
Checkout
</Button>
<Button
size="sm"
variant="outline"
disabled={mutating || !branchRef.trim()}
onClick={onStashCheckout}
title="Switch branches, auto-stashing a dirty tree first"
>
Stash-checkout
</Button>
</div>
<div className="flex flex-wrap gap-2">
<Button size="sm" variant="outline" disabled={mutating} onClick={onFetch}>
Fetch
</Button>
<Button size="sm" variant="outline" disabled={mutating} onClick={onPull}>
Pull
</Button>
<Button size="sm" variant="destructive" disabled={mutating} onClick={onPush}>
Push
</Button>
</div>
</div>
);
}
export default function GitState({ autoRefresh }) {
const [repos, setRepos] = useState(null);
const [selected, setSelected] = useState(null);
const [status, setStatus] = useState(null);
const [branches, setBranches] = useState(null);
const [diff, setDiff] = useState(null);
const [file, setFile] = useState(null);
const [loading, setLoading] = useState(true);
const [error, setError] = useState(null);
const [notice, setNotice] = useState(null);
const selectedRef = useRef(null);
const requestGenerationRef = useRef(0);
const mutationActiveRef = useRef(false);
const loadRepos = useCallback(async () => {
setError(null);
try {
const data = await getGitRepos();
const list = (data && data.repos) || [];
setRepos(list);
setNotice((data && data.notice) || null);
const currentSelected = selectedRef.current;
if (currentSelected && !list.some((r) => r.id === currentSelected)) {
selectedRef.current = null;
requestGenerationRef.current += 1;
setSelected(null);
setStatus(null);
setBranches(null);
setDiff(null);
setFile(null);
setGeneratingMessage(false);
setCommitNotice(null);
}
} catch (err) {
setError(err && err.message ? err.message : String(err));
} finally {
setLoading(false);
}
}, []);
useEffect(() => {
loadRepos();
}, [loadRepos]);
useEffect(() => {
if (!autoRefresh) return undefined;
const id = setInterval(loadRepos, 15000);
return () => clearInterval(id);
}, [autoRefresh, loadRepos]);
const selectRepo = useCallback(async (repoId) => {
const generation = requestGenerationRef.current + 1;
requestGenerationRef.current = generation;
selectedRef.current = repoId;
setSelected(repoId);
setStatus(null);
setBranches(null);
setDiff(null);
setFile(null);
setGeneratingMessage(false);
setCommitNotice(null);
setError(null);
try {
const [st, br] = await Promise.all([
getGitStatus(repoId),
getGitBranches(repoId),
]);
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setStatus(st);
setBranches(br && br.branches);
} catch (err) {
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setError(err && err.message ? err.message : String(err));
}
}, []);
const showDiff = useCallback(async (path, kind) => {
const repoId = selectedRef.current;
if (!repoId) return;
const generation = requestGenerationRef.current;
setFile(null);
setError(null);
try {
const nextDiff = await getGitDiff(repoId, path, kind);
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setDiff(nextDiff);
} catch (err) {
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setError(err && err.message ? err.message : String(err));
}
}, []);
const showFile = useCallback(async (path) => {
const repoId = selectedRef.current;
if (!repoId) return;
const generation = requestGenerationRef.current;
setDiff(null);
setError(null);
try {
const nextFile = await getGitFile(repoId, path);
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setFile(nextFile);
} catch (err) {
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setError(err && err.message ? err.message : String(err));
}
}, []);
// ── Authenticated Dashboard write controls + confirmations ──────────────
const [commitMessage, setCommitMessage] = useState("");
const [newBranch, setNewBranch] = useState("");
const [branchRef, setBranchRef] = useState("");
const [mutating, setMutating] = useState(false);
const [mutationError, setMutationError] = useState(null);
const [generatingMessage, setGeneratingMessage] = useState(false);
const [commitNotice, setCommitNotice] = useState(null);
const [pushAfterCommit, setPushAfterCommit] = useState(false);
const refreshDetail = useCallback(async (repoId, generation) => {
const [st, br] = await Promise.all([
getGitStatus(repoId),
getGitBranches(repoId),
]);
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setStatus(st);
setBranches(br && br.branches);
}, []);
const applyMutation = useCallback(
async (op, paths, opts) => {
const repoId = selectedRef.current;
const generation = requestGenerationRef.current;
if (!repoId || mutationActiveRef.current) return false;
mutationActiveRef.current = true;
setMutationError(null);
setMutating(true);
try {
if (op === "stage") await gitStage(repoId, paths);
else if (op === "unstage") await gitUnstage(repoId, paths);
else if (op === "fetch") await gitFetch(repoId, opts?.remote || "origin");
else if (op === "pull") await gitPull(repoId, opts?.remote || "origin", opts?.branch || "");
else if (op === "commit") await gitCommit(repoId, opts?.message);
else if (op === "discard") await gitDiscard(repoId, paths, opts?.confirmation, opts?.deleteUntracked);
else if (op === "push") await gitPush(repoId, opts?.confirmation, opts?.remote || "origin", opts?.branch || "");
else if (op === "checkout" || op === "dirty-checkout") {
await gitCheckout(repoId, opts.ref, {
confirmation: opts.confirmation,
newBranch: opts.newBranch,
track: opts.track,
});
} else throw new Error(`Unknown Git operation: ${op}`);
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) {
return false;
}
await refreshDetail(repoId, generation);
return true;
} catch (err) {
if (isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) {
setMutationError(err && err.message ? err.message : String(err));
}
return false;
} finally {
mutationActiveRef.current = false;
setMutating(false);
}
},
[refreshDetail],
);
/**
* Generate a commit-message suggestion from the staged diff (AI). Empty
* staged diff / model-unavailable degrade to a notice, never an error.
*/
const generateMessage = useCallback(async () => {
const repoId = selectedRef.current;
if (!repoId) return;
const generation = requestGenerationRef.current;
setGeneratingMessage(true);
setCommitNotice(null);
try {
const stagedPaths = (status && status.staged || []).map((e) => e.path);
const data = stagedPaths.length > 0 && !status?.truncated
? await gitCommitMessageSelected(repoId, stagedPaths)
: await gitCommitMessage(repoId);
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
const result = normalizeCommitMessage(data);
if (hasCommitSuggestion(result)) {
setCommitMessage(result.message);
setCommitNotice(result.notice || null);
} else {
setCommitNotice(result.notice || "Nothing staged to generate a message from.");
}
} catch (err) {
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
setCommitNotice(err && err.message ? err.message : String(err));
} finally {
if (isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) {
setGeneratingMessage(false);
}
}
}, [status]);
/**
* Stash-checkout: switch branches, auto-stashing a dirty tree first. No
* confirmation is needed because a stash is recoverable (git stash pop).
* On success, surface the stash message so the user can pop it later.
*/
const doStashCheckout = useCallback(async () => {
const ref = branchRef.trim();
const repoId = selectedRef.current;
const generation = requestGenerationRef.current;
if (!ref || !repoId || mutationActiveRef.current) return;
mutationActiveRef.current = true;
setMutationError(null);
setCommitNotice(null);
setMutating(true);
try {
const data = await gitStashCheckout(repoId, ref, {
newBranch: newBranch.trim(),
track: false,
});
if (!isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) return;
const result = normalizeStashCheckout(data);
if (result.stashed) {
setCommitNotice(
`Stashed changes on ${ref} as “${result.stashMessage}”. Use “git stash pop” to restore them.`,
);
}
await refreshDetail(repoId, generation);
} catch (err) {
if (isCurrentRepoRequest(selectedRef.current, requestGenerationRef.current, repoId, generation)) {
setMutationError(err && err.message ? err.message : String(err));
}
} finally {
mutationActiveRef.current = false;
setMutating(false);
setBranchRef("");
setNewBranch("");
}
}, [branchRef, newBranch, refreshDetail]);
/**
* Destructive ops (discard, push, dirty-checkout) gate on a per-use
* confirmation echoed back to the server. Matches the dashboard's existing
* confirm-before-destructive pattern (see RelayManagement onRevoke) and the
* plugin's confirmation-string mechanics.
*/
const requestMutation = useCallback((op, opts) => {
if (requiresConfirmation(op)) {
const description =
op === "discard"
? "Discard local changes? This cannot be undone."
: op === "push"
? "Push local commits to the remote repository?"
: "Working tree has uncommitted changes. Switch branches anyway?";
if (!window.confirm(description)) return;
const token = confirmationFor(op);
if (op === "discard") applyMutation("discard", opts?.paths, { confirmation: token, deleteUntracked: opts?.deleteUntracked });
else if (op === "push") applyMutation("push", [], { confirmation: token, remote: opts?.remote, branch: opts?.branch });
else if (op === "dirty-checkout") applyMutation("dirty-checkout", [], { ...opts, confirmation: token });
return;
}
applyMutation(op, opts?.paths, opts);
}, [applyMutation]);
const doCommit = useCallback(async () => {
const message = commitMessage.trim();
if (!message) {
setMutationError("Commit message must not be empty.");
return;
}
const succeeded = await applyMutation("commit", [], { message });
if (!succeeded) return;
setCommitMessage("");
// Push-after-commit: when the toggle is ON, immediately start the existing
// push confirmation flow. Confirmation is still required (never bypassed);
// the toggle only auto-starts it after a successful commit.
if (shouldOfferPushAfterCommit(succeeded, pushAfterCommit)) {
requestMutation("push", {});
}
}, [commitMessage, status, applyMutation, pushAfterCommit, requestMutation]);
const doCheckout = useCallback(async () => {
const ref = branchRef.trim();
if (!ref) return;
const dirty = status && (status.counts.modified + status.counts.staged + status.counts.untracked) > 0;
const opts = { ref, newBranch: newBranch.trim(), track: false };
if (dirty && !opts.newBranch) {
requestMutation("dirty-checkout", opts);
setBranchRef("");
setNewBranch("");
return;
}
await applyMutation("checkout", [], opts);
setBranchRef("");
setNewBranch("");
}, [branchRef, newBranch, status, applyMutation, requestMutation]);
if (loading && repos === null) {
return <div className="text-sm text-muted-foreground">Loading repositories…</div>;
}
if (error) {
return (
<Alert variant="destructive">
<AlertTitle>Git state unavailable</AlertTitle>
<AlertDescription>
<pre className="whitespace-pre-wrap text-xs">{error}</pre>
<Button className="mt-2" size="sm" variant="outline" onClick={loadRepos}>
Retry
</Button>
</AlertDescription>
</Alert>
);
}
const list = repos || [];
return (
<div className="space-y-4">
<Card>
<CardHeader>
<CardTitle>Repositories</CardTitle>
<CardDescription>
Repositories scanned from the configured Git base path.
</CardDescription>
</CardHeader>
<CardContent>
{notice ? (
<div className="mb-3 rounded-md border border-amber-500/40 bg-amber-500/10 p-2 text-xs text-amber-600">
{notice}
</div>
) : null}
{list.length === 0 ? (
<div className="text-sm text-muted-foreground">
No repositories found.
</div>
) : (
<div className="flex flex-wrap gap-2">
{list.map((repo) => (
<Button
key={repo.id}
size="sm"
variant={selected === repo.id ? "default" : "outline"}
onClick={() => selectRepo(repo.id)}
>
{repo.name}
{repo.dirty ? " •" : ""}
</Button>
))}
</div>
)}
</CardContent>
</Card>
{selected ? (
<Card>
<CardHeader>
<CardTitle>{selected}</CardTitle>
<CardDescription>
Working tree and branches. Tap a changed file to view its diff or
content.
</CardDescription>
</CardHeader>
<CardContent className="space-y-4">
{mutationError ? (
<Alert variant="destructive">
<AlertTitle>Git mutation failed</AlertTitle>
<AlertDescription>
<pre className="whitespace-pre-wrap text-xs">{mutationError}</pre>
</AlertDescription>
</Alert>
) : null}
<StatusRow status={status} />
<BranchesRow branches={branches} />
<WriteControls
status={status}
branches={branches}
selected={selected}
commitMessage={commitMessage}
onCommitMessageChange={setCommitMessage}
generatingMessage={generatingMessage}
onGenerateMessage={generateMessage}
commitNotice={commitNotice}
newBranch={newBranch}
onNewBranchChange={setNewBranch}
branchRef={branchRef}
onBranchRefChange={setBranchRef}
mutating={mutating}
pushAfterCommit={pushAfterCommit}
onPushAfterCommitChange={setPushAfterCommit}
onStageAll={() => requestMutation("stage", { paths: (status && status.modified || []).map((e) => e.path) })}
onUnstageAll={() => requestMutation("unstage", { paths: (status && status.staged || []).map((e) => e.path) })}
onDiscardAll={() => requestMutation("discard", { paths: (status && status.staged || []).map((e) => e.path), deleteUntracked: false })}
onStage={(path) => requestMutation("stage", { paths: [path] })}
onUnstage={(path) => requestMutation("unstage", { paths: [path] })}
onDiscard={(path) => requestMutation("discard", { paths: [path], deleteUntracked: false })}
onCommit={doCommit}
onFetch={() => requestMutation("fetch", {})}
onPull={() => requestMutation("pull", {})}
onPush={() => requestMutation("push", {})}
onCheckout={doCheckout}
onStashCheckout={doStashCheckout}
/>
{status && (status.staged || []).length > 0 ? (
<div>
<div className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
Staged diffs
</div>
<ul className="mt-1 space-y-0.5">
{(status.staged || []).map((item) => (
<li key={`sd-${item.path}`}>
<button
type="button"
className="font-mono text-xs text-primary underline"
onClick={() => showDiff(item.path, "staged")}
>
{item.path}
</button>
</li>
))}
</ul>
</div>
) : null}
{status && (status.modified || []).length > 0 ? (
<div>
<div className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
Unstaged diffs
</div>
<ul className="mt-1 space-y-0.5">
{(status.modified || []).map((item) => (
<li key={`ud-${item.path}`}>
<button
type="button"
className="font-mono text-xs text-primary underline"
onClick={() => showDiff(item.path, "unstaged")}
>
{item.path}
</button>
</li>
))}
</ul>
</div>
) : null}
{status && (status.untracked || []).length > 0 ? (
<div>
<div className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
Untracked files
</div>
<ul className="mt-1 space-y-0.5">
{(status.untracked || []).map((item) => (
<li key={`uf-${item.path}`}>
<button
type="button"
className="font-mono text-xs text-primary underline"
onClick={() => showFile(item.path)}
>
{item.path}
</button>
</li>
))}
</ul>
</div>
) : null}
{diff ? (
<div>
<div className="flex items-center justify-between">
<div className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
Diff — {diff.path} ({diff.kind})
</div>
<TruncationNotice truncated={diff.truncated} />
</div>
<pre className="mt-1 max-h-96 overflow-auto whitespace-pre-wrap rounded-md bg-muted/40 p-2 font-mono text-xs">
{diff.diff || "(no changes)"}
</pre>
</div>
) : null}
{file ? (
<div>
<div className="flex items-center justify-between">
<div className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
File — {file.path}
</div>
<TruncationNotice truncated={file.truncated} />
</div>
<pre className="mt-1 max-h-96 overflow-auto whitespace-pre-wrap rounded-md bg-muted/40 p-2 font-mono text-xs">
{file.content}
</pre>
</div>
) : null}
</CardContent>
</Card>
) : null}
</div>
);
}
@@ -0,0 +1,126 @@
import test from "node:test";
import assert from "node:assert/strict";
import { readFileSync } from "node:fs";
import {
normalizeMutationResult,
confirmationFor,
requiresConfirmation,
CONFIRMATIONS,
isCurrentRepoRequest,
shouldOfferPushAfterCommit,
} from "../src/lib/git-state.mjs";
test("normalizeMutationResult maps head/status/branches safely", () => {
const r = normalizeMutationResult({
head: "abc123",
status: { counts: { staged: 1 } },
branches: [{ name: "main" }],
});
assert.equal(r.head, "abc123");
assert.equal(r.status.counts.staged, 1);
assert.equal(r.branches.length, 1);
});
test("normalizeMutationResult tolerates missing fields", () => {
const r = normalizeMutationResult(null);
assert.equal(r.head, "");
assert.deepEqual(r.status.counts, { staged: 0, modified: 0, untracked: 0 });
assert.deepEqual(r.branches, []);
});
test("CONFIRMATIONS holds the fixed confirmation tokens", () => {
assert.equal(CONFIRMATIONS.discard, "discard");
assert.equal(CONFIRMATIONS.push, "push");
assert.equal(CONFIRMATIONS.dirtyCheckout, "checkout-dirty");
});
test("confirmationFor returns the token only for destructive ops", () => {
assert.equal(confirmationFor("discard"), CONFIRMATIONS.discard);
assert.equal(confirmationFor("push"), CONFIRMATIONS.push);
assert.equal(confirmationFor("dirty-checkout"), CONFIRMATIONS.dirtyCheckout);
assert.equal(confirmationFor("commit"), null);
assert.equal(confirmationFor("stage"), null);
});
test("requiresConfirmation gates only destructive ops", () => {
assert.equal(requiresConfirmation("discard"), true);
assert.equal(requiresConfirmation("push"), true);
assert.equal(requiresConfirmation("dirty-checkout"), true);
assert.equal(requiresConfirmation("stage"), false);
assert.equal(requiresConfirmation("commit"), false);
assert.equal(requiresConfirmation("fetch"), false);
});
test("repository request ownership rejects stale repo or generation", () => {
assert.equal(isCurrentRepoRequest("a", 2, "a", 2), true);
assert.equal(isCurrentRepoRequest("b", 2, "a", 2), false);
assert.equal(isCurrentRepoRequest("a", 3, "a", 2), false);
});
test("push-after-commit requires the exact commit to succeed", () => {
assert.equal(shouldOfferPushAfterCommit(true, true), true);
assert.equal(shouldOfferPushAfterCommit(false, true), false);
assert.equal(shouldOfferPushAfterCommit(true, false), false);
});
test("GitState commits the complete index and dispatches clean checkout", () => {
const source = readFileSync(new URL("../src/tabs/GitState.jsx", import.meta.url), "utf8");
assert.match(source, /applyMutation\("commit", \[\], \{ message \}\)/);
assert.doesNotMatch(source, /applyMutation\("commitSelected"/);
assert.match(source, /op === "checkout" \|\| op === "dirty-checkout"/);
});
test("GitState bulk actions dispatch one bounded path array", () => {
const source = readFileSync(new URL("../src/tabs/GitState.jsx", import.meta.url), "utf8");
assert.match(source, /onClick=\{onStageAll\}/);
assert.match(source, /onClick=\{onUnstageAll\}/);
assert.match(source, /onClick=\{onDiscardAll\}/);
assert.doesNotMatch(source, /forEach\(onStage\)|forEach\(onUnstage\)|forEach\(onDiscard\)/);
});
// ── Phase 3 extras ─────────────────────────────────────────────────────────
import {
normalizeCommitMessage,
hasCommitSuggestion,
normalizeStashCheckout,
} from "../src/lib/git-state.mjs";
test("normalizeCommitMessage maps message/notice safely", () => {
const r = normalizeCommitMessage({ message: "feat: add x", notice: "" });
assert.equal(r.message, "feat: add x");
assert.equal(r.notice, "");
});
test("normalizeCommitMessage tolerates missing/empty fields", () => {
assert.deepEqual(normalizeCommitMessage(null), { message: "", notice: "" });
assert.deepEqual(normalizeCommitMessage({}), { message: "", notice: "" });
});
test("hasCommitSuggestion is false for empty/whitespace messages", () => {
assert.equal(hasCommitSuggestion({ message: "feat: add x" }), true);
assert.equal(hasCommitSuggestion({ message: "" }), false);
assert.equal(hasCommitSuggestion({ message: " " }), false);
assert.equal(hasCommitSuggestion(null), false);
});
test("normalizeStashCheckout carries stashed + stash_message", () => {
const r = normalizeStashCheckout({
head: "abc",
stashed: true,
stash_message: "git-state: feature",
status: { counts: { staged: 0 } },
branches: [],
});
assert.equal(r.head, "abc");
assert.equal(r.stashed, true);
assert.equal(r.stashMessage, "git-state: feature");
assert.equal(r.status.counts.staged, 0);
});
test("normalizeStashCheckout defaults stashed false when absent", () => {
const r = normalizeStashCheckout({});
assert.equal(r.stashed, false);
assert.equal(r.stashMessage, "");
});
+60
View File
@@ -0,0 +1,60 @@
import test from "node:test";
import assert from "node:assert/strict";
import {
normalizeRepos,
normalizeStatus,
normalizeBranches,
branchLabel,
isTruncated,
} from "../src/lib/git-state.mjs";
test("normalizeRepos accepts object and bare-array shapes", () => {
assert.deepEqual(
normalizeRepos({ repos: [{ id: "a", name: "A" }] }),
[{ id: "a", name: "A" }],
);
assert.deepEqual(normalizeRepos([{ id: "b", name: "B" }]), [
{ id: "b", name: "B" },
]);
assert.deepEqual(normalizeRepos(null), []);
assert.deepEqual(normalizeRepos({ repos: [{ id: 1 }, null] }), []);
});
test("normalizeStatus fills missing groups and preserves truncation", () => {
const status = normalizeStatus({
counts: { staged: 1, modified: 2, untracked: 3 },
staged: [{ path: "a" }],
truncated: true,
});
assert.equal(status.counts.staged, 1);
assert.equal(status.counts.modified, 2);
assert.equal(status.counts.untracked, 3);
assert.deepEqual(status.staged, [{ path: "a" }]);
assert.deepEqual(status.modified, []);
assert.deepEqual(status.untracked, []);
assert.equal(status.truncated, true);
assert.equal(isTruncated(status), true);
assert.equal(isTruncated(normalizeStatus({})), false);
});
test("normalizeBranches accepts object and bare-array shapes", () => {
assert.deepEqual(normalizeBranches({ branches: [{ name: "main" }] }), [
{ name: "main" },
]);
assert.deepEqual(normalizeBranches([{ name: "dev" }]), [{ name: "dev" }]);
assert.deepEqual(normalizeBranches(null), []);
});
test("branchLabel renders upstream and ahead/behind", () => {
assert.equal(branchLabel({ name: "main" }), "main");
assert.equal(
branchLabel({ name: "main", upstream: "origin/main" }),
"main → origin/main",
);
assert.equal(
branchLabel({ name: "feature", upstream: "origin/feature", ahead: 1, behind: 2 }),
"feature → origin/feature (ahead 1, behind 2)",
);
assert.equal(branchLabel(null), "");
});
+559
View File
@@ -0,0 +1,559 @@
"""Tests for the write (POST) Git State endpoints in plugin/dashboard/git_api.py.
Write endpoints are POST and rely on the plugin's ``plugin.api.write`` grant
which the app enforces client-side (see PluginsViewModel.invokeAction — the
precedent gate). Server-side, destructive operations are additionally enforced
by a required confirmation string; missing/wrong confirmation maps to 403 and
dirty/conflict trees map to 409, so the UI can render a readable message.
"""
from __future__ import annotations
import os
import subprocess
import tempfile
import unittest
from pathlib import Path
from unittest.mock import AsyncMock, patch
from fastapi import FastAPI
from fastapi.testclient import TestClient
from plugin.dashboard import git_api
from plugin import git_state
def _run(cmd: list[str], cwd: Path) -> str:
return subprocess.run(
cmd, cwd=cwd, capture_output=True, text=True, check=True
).stdout.strip()
def _git(repo: Path, *args: str) -> str:
return _run(["git", "-C", str(repo), *args], repo)
def _init_repo(root: Path, name: str) -> Path:
repo = root / name
repo.mkdir(parents=True)
_run(["git", "init", "-q", "-b", "main"], repo)
_run(["git", "config", "user.email", "test@example.com"], repo)
_run(["git", "config", "user.name", "Test User"], repo)
(repo / "README.md").write_text("# Hello\n", encoding="utf-8")
_git(repo, "add", "README.md")
_git(repo, "commit", "-q", "-m", "initial commit")
return repo
def _init_bare_remote(root: Path, name: str) -> Path:
remote = root / name
remote.mkdir(parents=True, exist_ok=True)
_run(["git", "init", "-q", "--bare", "-b", "main"], remote)
return remote
class GitWriteApiTests(unittest.TestCase):
def setUp(self) -> None:
self.temp = tempfile.TemporaryDirectory()
self.addCleanup(self.temp.cleanup)
self.base = Path(self.temp.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "alpha")
self.env = patch.dict(
os.environ,
{"HERMES_HOME": self.temp.name, "GIT_STATE_BASE_PATH": str(self.base)},
)
self.env.start()
self.addCleanup(self.env.stop)
app = FastAPI()
app.include_router(git_api.router)
self.client = TestClient(app)
def _stage(self, path: str) -> None:
(self.repo / path).write_text("x", encoding="utf-8")
self.client.post("/git/stage", json={"repo": "alpha", "paths": [path]})
def test_stage_returns_fresh_status(self) -> None:
(self.repo / "new.txt").write_text("x", encoding="utf-8")
response = self.client.post(
"/git/stage", json={"repo": "alpha", "paths": ["new.txt"]}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertEqual(1, body["status"]["counts"]["staged"])
def test_unknown_repo_rejected(self) -> None:
response = self.client.post(
"/git/stage", json={"repo": "bogus", "paths": ["x"]}
)
self.assertEqual(400, response.status_code, response.text)
def test_remote_operations_reject_urls_options_and_wrong_types(self) -> None:
for path, payload in (
("/git/fetch", {"remote": "https://example.invalid/repo.git"}),
("/git/fetch", {"remote": "--all"}),
("/git/pull", {"remote": ["origin"], "branch": "main"}),
("/git/push", {"remote": "origin", "branch": "--mirror", "confirmation": "push"}),
):
with self.subTest(path=path, payload=payload):
response = self.client.post(path, json={"repo": "alpha", **payload})
self.assertEqual(400, response.status_code, response.text)
def test_commit_creates_commit(self) -> None:
self._stage("feature.txt")
before = _git(self.repo, "rev-parse", "HEAD")
response = self.client.post(
"/git/commit", json={"repo": "alpha", "message": "add feature"}
)
self.assertEqual(200, response.status_code, response.text)
after = _git(self.repo, "rev-parse", "HEAD")
self.assertNotEqual(before, after)
def test_commit_empty_message_rejected(self) -> None:
self._stage("feature.txt")
response = self.client.post(
"/git/commit", json={"repo": "alpha", "message": " "}
)
self.assertEqual(400, response.status_code, response.text)
def test_discard_without_confirmation_is_403(self) -> None:
(self.repo / "tracked.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
response = self.client.post(
"/git/discard", json={"repo": "alpha", "paths": ["tracked.txt"]}
)
self.assertEqual(403, response.status_code, response.text)
def test_discard_wrong_confirmation_is_403(self) -> None:
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
response = self.client.post(
"/git/discard",
json={
"repo": "alpha",
"paths": ["tracked.txt"],
"confirmation": "wrong",
},
)
self.assertEqual(403, response.status_code, response.text)
def test_discard_with_confirmation_succeeds(self) -> None:
(self.repo / "tracked.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
response = self.client.post(
"/git/discard",
json={
"repo": "alpha",
"paths": ["tracked.txt"],
"confirmation": git_state.CONFIRM_DISCARD,
},
)
self.assertEqual(200, response.status_code, response.text)
self.assertEqual("v1", (self.repo / "tracked.txt").read_text(encoding="utf-8"))
def test_push_requires_confirmation(self) -> None:
remote = _init_bare_remote(self.base, "origin-bare")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
self._stage("feature.txt")
self.client.post("/git/commit", json={"repo": "alpha", "message": "f"})
response = self.client.post(
"/git/push", json={"repo": "alpha", "remote": "origin", "branch": "main"}
)
self.assertEqual(403, response.status_code, response.text)
def test_push_with_confirmation_succeeds(self) -> None:
remote = _init_bare_remote(self.base, "remote-bare")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
self._stage("feature.txt")
self.client.post("/git/commit", json={"repo": "alpha", "message": "f"})
response = self.client.post(
"/git/push",
json={
"repo": "alpha",
"remote": "origin",
"branch": "main",
"confirmation": git_state.CONFIRM_PUSH,
},
)
self.assertEqual(200, response.status_code, response.text)
def test_checkout_dirty_requires_confirmation(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
(self.repo / "tracked.txt").write_text("dirty", encoding="utf-8")
response = self.client.post(
"/git/checkout", json={"repo": "alpha", "ref": "feature"}
)
# Missing confirmation on a dirty-tree switch is the destructive gate.
self.assertEqual(403, response.status_code, response.text)
# Confirming proceeds (git still refuses to overwrite conflicting work).
response = self.client.post(
"/git/checkout",
json={
"repo": "alpha",
"ref": "feature",
"confirmation": git_state.CONFIRM_DIRTY_CHECKOUT,
},
)
self.assertEqual(200, response.status_code, response.text)
def test_pull_dirty_returns_409_never_clobbers(self) -> None:
remote = _init_bare_remote(self.base, "remote-bare2")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
# Advance the remote from a descendant clone.
other = self.base / "other"
_run(["git", "clone", "-q", str(remote), str(other)], self.base)
_git(other, "config", "user.email", "t@e.c")
_git(other, "config", "user.name", "T")
(other / "tracked.txt").write_text("remote", encoding="utf-8")
_git(other, "add", "tracked.txt")
_git(other, "commit", "-q", "-m", "remote")
_git(other, "push", "-q", "origin", "main")
(self.repo / "tracked.txt").write_text("local-uncommitted", encoding="utf-8")
response = self.client.post(
"/git/pull", json={"repo": "alpha", "remote": "origin", "branch": "main"}
)
self.assertEqual(409, response.status_code, response.text)
self.assertEqual("local-uncommitted", (self.repo / "tracked.txt").read_text(encoding="utf-8"))
def test_fetch_returns_branches(self) -> None:
remote = _init_bare_remote(self.base, "remote-bare3")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
response = self.client.post(
"/git/fetch", json={"repo": "alpha", "remote": "origin"}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("branches", body)
def test_structured_error_taxonomy_is_readable(self) -> None:
# Unknown repo → 400 with a readable detail, never a stack trace.
response = self.client.post(
"/git/stage", json={"repo": "missing", "paths": ["x"]}
)
self.assertEqual(400, response.status_code, response.text)
self.assertNotIn("Traceback", response.text)
self.assertNotIn("subprocess", response.text.lower())
def test_push_wrong_confirmation_is_403(self) -> None:
remote = _init_bare_remote(self.base, "push-wrong-bare")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
self._stage("feature.txt")
self.client.post("/git/commit", json={"repo": "alpha", "message": "f"})
response = self.client.post(
"/git/push",
json={
"repo": "alpha",
"remote": "origin",
"branch": "main",
"confirmation": "nope",
},
)
self.assertEqual(403, response.status_code, response.text)
def test_push_with_confirmation_updates_remote_and_returns_branches(self) -> None:
remote = _init_bare_remote(self.base, "push-ok-bare")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
_git(self.repo, "branch", "-q", "--set-upstream-to=origin/main", "main")
self._stage("feature.txt")
r = self.client.post("/git/commit", json={"repo": "alpha", "message": "f"})
self.assertEqual(200, r.status_code, r.text)
head = r.json()["head"]
response = self.client.post(
"/git/push",
json={
"repo": "alpha",
"remote": "origin",
"branch": "main",
"confirmation": git_state.CONFIRM_PUSH,
},
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("branches", body)
self.assertIn("status", body)
remote_head = _run(
["git", "ls-remote", str(remote), "refs/heads/main"], self.base
)
self.assertIn(head, remote_head)
def test_checkout_dirty_tree_wrong_confirmation_is_403(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
(self.repo / "tracked.txt").write_text("dirty", encoding="utf-8")
response = self.client.post(
"/git/checkout",
json={"repo": "alpha", "ref": "feature", "confirmation": "wrong"},
)
self.assertEqual(403, response.status_code, response.text)
def test_checkout_clean_tree_works_without_confirmation(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
response = self.client.post(
"/git/checkout", json={"repo": "alpha", "ref": "feature"}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("branches", body)
self.assertIn("status", body)
self.assertEqual(
"feature", _git(self.repo, "symbolic-ref", "--short", "HEAD")
)
def test_checkout_new_branch_with_track_sets_upstream(self) -> None:
remote = _init_bare_remote(self.base, "newbranch-bare")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
_git(self.repo, "branch", "-q", "--set-upstream-to=origin/main", "main")
response = self.client.post(
"/git/checkout",
json={
"repo": "alpha",
"ref": "main",
"new_branch": "exp",
"track": True,
},
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("branches", body)
self.assertIn("status", body)
self.assertEqual("exp", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
# Upstream is set — rev-parse resolves to a commit, not an error.
self.assertTrue(_git(self.repo, "rev-parse", "exp@{upstream}"))
def test_fetch_updates_remote_tracking_ref(self) -> None:
remote = _init_bare_remote(self.base, "fetch-adv-bare")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
other = self.base / "other"
_run(["git", "clone", "-q", str(remote), str(other)], self.base)
_git(other, "config", "user.email", "t@e.c")
_git(other, "config", "user.name", "T")
(other / "remote.txt").write_text("rc fetch", encoding="utf-8")
_git(other, "add", "remote.txt")
_git(other, "commit", "-q", "-m", "rc fetch")
_git(other, "push", "-q", "origin", "main")
response = self.client.post(
"/git/fetch", json={"repo": "alpha", "remote": "origin"}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("branches", body)
self.assertIn("status", body)
remote_main = _git(self.repo, "rev-parse", "origin/main")
self.assertNotEqual(remote_main, _git(self.repo, "rev-parse", "HEAD"))
def test_pull_returns_200_with_remote_commit(self) -> None:
remote = _init_bare_remote(self.base, "pull-ok-bare")
_git(self.repo, "remote", "add", "origin", str(remote))
_git(self.repo, "push", "-q", "origin", "main")
_git(self.repo, "branch", "-q", "--set-upstream-to=origin/main", "main")
other = self.base / "other"
_run(["git", "clone", "-q", str(remote), str(other)], self.base)
_git(other, "config", "user.email", "t@e.c")
_git(other, "config", "user.name", "T")
(other / "remote.txt").write_text("rc pull", encoding="utf-8")
_git(other, "add", "remote.txt")
_git(other, "commit", "-q", "-m", "rc pull")
_git(other, "push", "-q", "origin", "main")
response = self.client.post(
"/git/pull",
json={"repo": "alpha", "remote": "origin", "branch": "main"},
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("status", body)
head_files = _git(self.repo, "ls-tree", "-r", "--name-only", "HEAD")
self.assertIn("remote.txt", head_files)
def test_commit_selected_commits_only_given_paths(self) -> None:
(self.repo / "kept.txt").write_text("keep", encoding="utf-8")
(self.repo / "skip.txt").write_text("skip", encoding="utf-8")
_git(self.repo, "add", "kept.txt", "skip.txt")
response = self.client.post(
"/git/commit_selected",
json={"repo": "alpha", "message": "commit kept", "paths": ["kept.txt"]},
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("head", body)
self.assertIn("status", body)
head_files = _git(self.repo, "ls-tree", "-r", "--name-only", "HEAD")
self.assertIn("kept.txt", head_files)
self.assertNotIn("skip.txt", head_files)
def test_commit_response_includes_head_and_fresh_status(self) -> None:
self._stage("feature.txt")
response = self.client.post(
"/git/commit", json={"repo": "alpha", "message": "add feature"}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("head", body)
self.assertEqual(body["head"], _git(self.repo, "rev-parse", "HEAD"))
self.assertIn("status", body)
self.assertEqual(0, body["status"]["counts"]["staged"])
self.assertEqual(0, body["status"]["counts"]["modified"])
def test_unstage_returns_fresh_status(self) -> None:
(self.repo / "tracked.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
r = self.client.post(
"/git/stage", json={"repo": "alpha", "paths": ["tracked.txt"]}
)
self.assertEqual(200, r.status_code, r.text)
response = self.client.post(
"/git/unstage", json={"repo": "alpha", "paths": ["tracked.txt"]}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertIn("status", body)
status = body["status"]
self.assertNotIn(
"tracked.txt", [e["path"] for e in status["staged"]]
)
self.assertIn(
"tracked.txt", [e["path"] for e in status["modified"]]
)
def test_stage_missing_repo_in_body_is_400(self) -> None:
response = self.client.post("/git/stage", json={"paths": ["x"]})
self.assertEqual(400, response.status_code, response.text)
def test_stage_traversal_path_is_400(self) -> None:
response = self.client.post(
"/git/stage", json={"repo": "alpha", "paths": ["../escape"]}
)
self.assertEqual(400, response.status_code, response.text)
def test_stage_too_many_paths_is_400(self) -> None:
paths = [f"f{i}.txt" for i in range(201)]
response = self.client.post(
"/git/stage", json={"repo": "alpha", "paths": paths}
)
self.assertEqual(400, response.status_code, response.text)
class GitExtrasApiTests(unittest.TestCase):
"""Endpoints for the Phase 3 extras surface (AI messages + stash-checkout)."""
def setUp(self) -> None:
self.temp = tempfile.TemporaryDirectory()
self.addCleanup(self.temp.cleanup)
self.base = Path(self.temp.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "alpha")
self.env = patch.dict(
os.environ,
{"HERMES_HOME": self.temp.name, "GIT_STATE_BASE_PATH": str(self.base)},
)
self.env.start()
self.addCleanup(self.env.stop)
app = FastAPI()
app.include_router(git_api.router)
self.client = TestClient(app)
def _staged(self, path: str, content: str) -> None:
(self.repo / path).write_text(content, encoding="utf-8")
self.client.post("/git/stage", json={"repo": "alpha", "paths": [path]})
def test_commit_message_empty_staged_returns_notice_without_model(self) -> None:
# Clean tree → nothing staged → no model needed, no 500.
response = self.client.post("/git/commit_message", json={"repo": "alpha"})
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertEqual("", body["message"])
self.assertEqual("nothing staged", body["notice"])
def test_commit_message_with_staged_diff_generates_message(self) -> None:
self._staged("feature.txt", "new feature\n")
with patch.object(git_state, "_llm_call", new=AsyncMock(return_value="resp")), patch.object(
git_state, "_llm_extract", return_value="feat: add feature"
):
response = self.client.post(
"/git/commit_message", json={"repo": "alpha"}
)
self.assertEqual(200, response.status_code, response.text)
self.assertEqual("feat: add feature", response.json()["message"])
def test_commit_message_model_failure_degrades_gracefully(self) -> None:
self._staged("a.txt", "x\n")
with patch.object(
git_state, "_llm_call", new=AsyncMock(side_effect=RuntimeError("no model"))
):
response = self.client.post(
"/git/commit_message", json={"repo": "alpha"}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertEqual("", body["message"])
self.assertIn("model", body["notice"].lower())
def test_commit_message_selected_honors_only_given_paths(self) -> None:
self._staged("kept.txt", "kept\n")
self._staged("skip.txt", "skip\n")
with patch.object(git_state, "_llm_call", new=AsyncMock(return_value="ok")), patch.object(
git_state, "_llm_extract", return_value="add kept"
):
response = self.client.post(
"/git/commit_message_selected",
json={"repo": "alpha", "paths": ["kept.txt"]},
)
self.assertEqual(200, response.status_code, response.text)
self.assertEqual("add kept", response.json()["message"])
def test_commit_message_unknown_repo_is_400(self) -> None:
response = self.client.post(
"/git/commit_message", json={"repo": "bogus"}
)
self.assertEqual(400, response.status_code, response.text)
def test_stash_checkout_dirty_tree_returns_stash_notice(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
(self.repo / "README.md").write_text("dirty", encoding="utf-8")
response = self.client.post(
"/git/stash_checkout", json={"repo": "alpha", "ref": "feature"}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertTrue(body["stashed"])
self.assertEqual("git-state: feature", body["stash_message"])
self.assertEqual("feature", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
self.assertIn("git-state: feature", _git(self.repo, "stash", "list"))
def test_stash_checkout_clean_tree_plain_checkout(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
response = self.client.post(
"/git/stash_checkout", json={"repo": "alpha", "ref": "feature"}
)
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertFalse(body["stashed"])
self.assertEqual("", body["stash_message"])
self.assertEqual("feature", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
def test_stash_checkout_bad_ref_is_400(self) -> None:
response = self.client.post(
"/git/stash_checkout", json={"repo": "alpha", "ref": "nope"}
)
self.assertEqual(400, response.status_code, response.text)
if __name__ == "__main__":
unittest.main()
+31 -2
View File
@@ -50,7 +50,8 @@ class MobilePluginApiTests(unittest.TestCase):
manifest = self.client.get("/mobile/manifest").json()
self.assertEqual("hermes-relay", manifest["id"])
self.assertEqual("draft", manifest["contributions"][0]["status"])
draft = next(c for c in manifest["contributions"] if c["id"] == "system-status")
self.assertEqual("draft", draft["status"])
loaded_document = self.client.get("/mobile/pages/system-status").json()
self.assertEqual(1, loaded_document.pop("host_revision"))
self.assertEqual(_document(), loaded_document)
@@ -70,7 +71,35 @@ class MobilePluginApiTests(unittest.TestCase):
json={"expected_digest": published_digest},
)
self.assertEqual({"ok": True, "id": "system-status"}, removed.json())
self.assertEqual([], self.client.get("/mobile/manifest").json()["contributions"])
remaining = self.client.get("/mobile/manifest").json()["contributions"]
self.assertEqual(["git"], [c["id"] for c in remaining])
def test_manifest_exposes_static_git_page(self) -> None:
manifest = self.client.get("/mobile/manifest").json()
git = next(c for c in manifest["contributions"] if c["id"] == "git")
self.assertEqual("page", git["surface"])
self.assertEqual("mobile/pages/git", git["document"]["path"])
# The Git page document is a GET-only read surface; it must not carry
# any action.request (which would require the write grant).
page = self.client.get("/mobile/pages/git").json()
self.assertNotIn("action", str(page))
def test_git_page_document_is_served(self) -> None:
response = self.client.get("/mobile/pages/git")
self.assertEqual(200, response.status_code, response.text)
body = response.json()
self.assertEqual(1, body["schemaVersion"])
self.assertEqual("git", body["pages"][0]["id"])
self.assertEqual(1, body["host_revision"])
def test_reserved_git_plugin_id_is_rejected(self) -> None:
response = self.client.put(
"/mobile/plugins/git/draft",
json={"title": "Shadow", "document": _document()},
)
self.assertEqual(400, response.status_code, response.text)
manifest = self.client.get("/mobile/manifest").json()
self.assertEqual(["git"], [item["id"] for item in manifest["contributions"]])
def test_traversal_and_bad_document_are_rejected(self) -> None:
traversal = self.client.put(
+1110
View File
File diff suppressed because it is too large Load Diff
+27
View File
@@ -17,6 +17,7 @@ from typing import Any, Optional
PLUGIN_ID_RE = re.compile(r"^[a-z0-9][a-z0-9._-]{0,63}$")
RESERVED_PLUGIN_IDS = frozenset({"git"})
MAX_DOCUMENT_BYTES = 512 * 1024
ALLOWED_LIFECYCLES = frozenset({"session", "persistent"})
ALLOWED_ELEMENT_TYPES = frozenset(
@@ -132,6 +133,8 @@ class MobilePluginStore:
for path in sorted(self.root.glob("*.json")):
if not PLUGIN_ID_RE.fullmatch(path.stem):
continue
if path.stem in RESERVED_PLUGIN_IDS:
continue
entry = self._read(path.stem, required=False)
if entry:
entries.append({k: v for k, v in entry.items() if k != "document"})
@@ -139,6 +142,26 @@ class MobilePluginStore:
def manifest(self) -> dict[str, Any]:
contributions = []
# Static read-only Git page contributed by the relay plugin itself.
# It carries no filesystem paths (per the android-plugins.md document
# contract); repo data flows through the /git/* API responses and is
# rendered as plain text by the host. No plugin.api.write grant is
# required for the read-only Git surface.
contributions.append(
{
"id": "git",
"surface": "page",
"title": "Git",
"description": "Browse repositories on this Hermes host",
"status": "published",
"lifecycle": "persistent",
"revision": 1,
"document": {
"method": "GET",
"path": "mobile/pages/git",
},
}
)
for summary in self.list():
is_draft = summary["status"] == "draft"
contributions.append(
@@ -180,6 +203,8 @@ class MobilePluginStore:
normalized = str(plugin_id).strip().lower()
if not PLUGIN_ID_RE.fullmatch(normalized):
raise MobilePluginStoreError("invalid plugin id")
if normalized in RESERVED_PLUGIN_IDS:
raise MobilePluginStoreError("plugin id is reserved")
return normalized
@staticmethod
@@ -311,6 +336,8 @@ class MobilePluginStore:
if required:
raise MobilePluginNotFoundError(plugin_id)
return {}
except MobilePluginStoreError:
raise
except (OSError, ValueError, json.JSONDecodeError):
if required:
raise MobilePluginNotFoundError(plugin_id)
+439
View File
@@ -0,0 +1,439 @@
"""Tests for the read-only Git state surface (plugin/git_state.py).
Fixtures create REAL throwaway git repositories in tmp_path — init, config
user, commits, branches, and bare remotes. Git itself is never mocked.
"""
from __future__ import annotations
import os
import subprocess
import unittest
from pathlib import Path
from unittest.mock import patch
from plugin import git_state
def _run(cmd: list[str], cwd: Path) -> str:
result = subprocess.run(
cmd,
cwd=cwd,
capture_output=True,
text=True,
check=True,
)
return result.stdout.strip()
def _git(repo: Path, *args: str) -> str:
return _run(["git", "-C", str(repo), *args], repo)
def _init_repo(root: Path, name: str) -> Path:
repo = root / name
repo.mkdir(parents=True)
_run(["git", "init", "-q", "-b", "main"], repo)
_run(["git", "config", "user.email", "test@example.com"], repo)
_run(["git", "config", "user.name", "Test User"], repo)
(repo / "README.md").write_text("# Hello\n", encoding="utf-8")
_git(repo, "add", "README.md")
_git(repo, "commit", "-q", "-m", "initial commit")
return repo
def _add_remote(repo: Path, remote_url: str, name: str = "origin") -> None:
_git(repo, "remote", "add", name, remote_url)
def _link_directory(link: Path, target: Path) -> None:
try:
link.symlink_to(target, target_is_directory=True)
except OSError:
if os.name != "nt":
raise
_run(["cmd", "/c", "mklink", "/J", str(link), str(target)], link.parent)
class GitStateScanTests(unittest.TestCase):
def setUp(self) -> None:
self.tmp = Path(self.tempdir())
def tempdir(self) -> str:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
return self._td.name
def test_scan_finds_nested_repos_and_ignores_non_repos(self) -> None:
base = self.tmp / "projects"
base.mkdir(parents=True)
_init_repo(base, "alpha")
_init_repo(base / "nested", "beta")
# A plain directory with no .git must be ignored.
(base / "plain").mkdir()
(base / "plain" / "file.txt").write_text("x", encoding="utf-8")
repos = git_state.scan_repos(base)
names = {r["name"] for r in repos}
self.assertEqual({"alpha", "beta"}, names)
for repo in repos:
self.assertEqual("main", repo["current_branch"])
self.assertFalse(repo["dirty"])
def test_scan_missing_base_path_returns_empty(self) -> None:
missing = self.tmp / "does-not-exist"
self.assertEqual([], git_state.scan_repos(missing))
def test_scan_excludes_git_internals(self) -> None:
base = self.tmp / "projects"
base.mkdir(parents=True)
_init_repo(base, "alpha")
# A .git directory itself must never be reported as a repo.
repos = git_state.scan_repos(base)
self.assertTrue(all(".git" not in r["name"] for r in repos))
def test_scan_marks_dirty_repo(self) -> None:
base = self.tmp / "projects"
base.mkdir(parents=True)
repo = _init_repo(base, "dirty")
(repo / "new.txt").write_text("untracked", encoding="utf-8")
repos = git_state.scan_repos(base)
dirty = next(r for r in repos if r["name"] == "dirty")
self.assertTrue(dirty["dirty"])
def test_nested_same_name_repos_have_distinct_round_trip_ids(self) -> None:
base = self.tmp / "projects"
base.mkdir(parents=True)
first = _init_repo(base / "team-a", "service")
second = _init_repo(base / "team-b", "service")
repos = git_state.scan_repos(base)
self.assertEqual({"team-a/service", "team-b/service"}, {repo["id"] for repo in repos})
self.assertEqual(first.resolve(), git_state.resolve_repo(base, "team-a/service"))
self.assertEqual(second.resolve(), git_state.resolve_repo(base, "team-b/service"))
def test_scan_rejects_linked_repo_outside_base(self) -> None:
base = self.tmp / "projects"
base.mkdir(parents=True)
outside = _init_repo(self.tmp, "outside")
link = base / "linked"
_link_directory(link, outside)
self.assertEqual([], git_state.scan_repos(base))
class GitStateStatusTests(unittest.TestCase):
def setUp(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
self.base = Path(self._td.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "status-repo")
def test_status_groups_modified_untracked_and_staged(self) -> None:
(self.repo / "tracked.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
# staged change
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
# unstaged change
(self.repo / "README.md").write_text("# Changed\n", encoding="utf-8")
# untracked
(self.repo / "untracked.txt").write_text("new", encoding="utf-8")
status = git_state.repo_status(self.repo)
self.assertEqual(1, status["counts"]["staged"])
self.assertEqual(1, status["counts"]["modified"])
self.assertEqual(1, status["counts"]["untracked"])
self.assertEqual(3, status["counts"]["changes"])
self.assertEqual(2, status["counts"]["additions"])
self.assertEqual(2, status["counts"]["deletions"])
self.assertEqual("tracked.txt", status["staged"][0]["path"])
self.assertEqual(1, status["staged"][0]["additions"])
self.assertEqual(1, status["staged"][0]["deletions"])
self.assertEqual("README.md", status["modified"][0]["path"])
self.assertEqual(1, status["modified"][0]["additions"])
self.assertEqual(1, status["modified"][0]["deletions"])
self.assertEqual("untracked.txt", status["untracked"][0]["path"])
self.assertIsNone(status["untracked"][0]["additions"])
self.assertIsNone(status["untracked"][0]["deletions"])
self.assertFalse(status["truncated"])
def test_status_truncates_when_over_cap(self) -> None:
for i in range(git_state.MAX_STATUS_ENTRIES + 5):
(self.repo / f"file-{i}.txt").write_text("x", encoding="utf-8")
status = git_state.repo_status(self.repo)
self.assertTrue(status["truncated"])
self.assertEqual(git_state.MAX_STATUS_ENTRIES + 5, status["counts"]["changes"])
self.assertLessEqual(
len(status["untracked"]),
git_state.MAX_STATUS_ENTRIES,
)
def test_status_lists_staged_and_modified_same_file(self) -> None:
# A file staged AND then modified again ("MM" in porcelain) must appear
# in BOTH the staged and modified groups (independent checks, not elif).
(self.repo / "mm.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "mm.txt")
_git(self.repo, "commit", "-q", "-m", "add mm")
(self.repo / "mm.txt").write_text("v2", encoding="utf-8")
_git(self.repo, "add", "mm.txt")
(self.repo / "mm.txt").write_text("v3", encoding="utf-8")
status = git_state.repo_status(self.repo)
staged_paths = {e["path"] for e in status["staged"]}
modified_paths = {e["path"] for e in status["modified"]}
self.assertIn("mm.txt", staged_paths)
self.assertIn("mm.txt", modified_paths)
def test_status_rename_emits_single_staged_entry(self) -> None:
# `git mv` produces two NUL-separated porcelain records ("R new\0old\0");
# the bare source-path record must be skipped, not misparsed as an XY
# record. Use a source name starting with "M" so a naive parser would
# misclassify the bare source record as staged with a truncated path.
(self.repo / "Moved.txt").write_text("content", encoding="utf-8")
_git(self.repo, "add", "Moved.txt")
_git(self.repo, "commit", "-q", "-m", "add Moved")
_git(self.repo, "mv", "Moved.txt", "new.txt")
status = git_state.repo_status(self.repo)
self.assertEqual(["new.txt"], [e["path"] for e in status["staged"]])
self.assertEqual(0, status["staged"][0]["additions"])
self.assertEqual(0, status["staged"][0]["deletions"])
self.assertEqual([], status["modified"])
self.assertEqual([], status["untracked"])
def test_status_unstaged_rename_shows_delete_and_untracked(self) -> None:
# Rename on disk only (no `git mv`): delete + create → D + ??.
(self.repo / "old.txt").write_text("content", encoding="utf-8")
_git(self.repo, "add", "old.txt")
_git(self.repo, "commit", "-q", "-m", "add old")
(self.repo / "old.txt").unlink()
(self.repo / "new.txt").write_text("content", encoding="utf-8")
status = git_state.repo_status(self.repo)
self.assertEqual([], status["staged"])
self.assertEqual(["old.txt"], [e["path"] for e in status["modified"]])
self.assertEqual(["new.txt"], [e["path"] for e in status["untracked"]])
class GitStateBranchesTests(unittest.TestCase):
def setUp(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
self.base = Path(self._td.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "branch-repo")
def test_branches_reports_current_upstream_ahead_behind(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
(self.repo / "feature.txt").write_text("f", encoding="utf-8")
_git(self.repo, "add", "feature.txt")
_git(self.repo, "commit", "-q", "-m", "feature work")
branches = git_state.repo_branches(self.repo)
by_name = {b["name"]: b for b in branches}
self.assertIn("main", by_name)
self.assertIn("feature", by_name)
self.assertTrue(by_name["feature"]["is_current"])
self.assertFalse(by_name["main"]["is_current"])
class GitStateDiffTests(unittest.TestCase):
def setUp(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
self.base = Path(self._td.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "diff-repo")
def test_diff_unstaged_and_staged_kinds(self) -> None:
(self.repo / "a.txt").write_text("one\n", encoding="utf-8")
_git(self.repo, "add", "a.txt")
_git(self.repo, "commit", "-q", "-m", "add a")
# staged change
(self.repo / "a.txt").write_text("two\n", encoding="utf-8")
_git(self.repo, "add", "a.txt")
# unstaged change
(self.repo / "a.txt").write_text("three\n", encoding="utf-8")
staged = git_state.repo_diff(self.repo, "a.txt", kind="staged")
self.assertIn("+two", staged["diff"])
unstaged = git_state.repo_diff(self.repo, "a.txt", kind="unstaged")
self.assertIn("+three", unstaged["diff"])
def test_diff_invalid_kind_raises(self) -> None:
with self.assertRaises(ValueError):
git_state.repo_diff(self.repo, "a.txt", kind="bogus")
def test_diff_truncates_large_output(self) -> None:
big = "x" * 200_000
(self.repo / "big.txt").write_text(big + "\n", encoding="utf-8")
_git(self.repo, "add", "big.txt")
_git(self.repo, "commit", "-q", "-m", "add big")
(self.repo / "big.txt").write_text(big + "y\n", encoding="utf-8")
result = git_state.repo_diff(self.repo, "big.txt", kind="unstaged")
self.assertTrue(result["truncated"])
self.assertLessEqual(len(result["diff"]), git_state.MAX_DIFF_BYTES)
class GitStateFileTests(unittest.TestCase):
def setUp(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
self.base = Path(self._td.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "file-repo")
def test_read_tracked_file(self) -> None:
content = git_state.read_file(self.repo, "README.md")
self.assertIn("Hello", content["content"])
def test_read_tracked_file_returns_working_tree_not_committed(self) -> None:
# A modified-but-uncommitted tracked file must return the on-disk
# (working-tree) content, not the last committed version.
(self.repo / "README.md").write_text("# Working Tree\n", encoding="utf-8")
content = git_state.read_file(self.repo, "README.md")
self.assertIn("Working Tree", content["content"])
self.assertNotIn("Hello", content["content"])
def test_read_untracked_file_raises(self) -> None:
(self.repo / "untracked.txt").write_text("new", encoding="utf-8")
with self.assertRaises(ValueError):
git_state.read_file(self.repo, "untracked.txt")
def test_read_missing_file_raises(self) -> None:
with self.assertRaises(ValueError):
git_state.read_file(self.repo, "nope.txt")
def test_read_tracked_binary_file_raises_gitstateerror(self) -> None:
# A TRACKED binary file (e.g. a committed PNG) must raise GitStateError
# ("binary file is not supported" / UTF-8), never an unhandled
# UnicodeDecodeError that escapes as a 500.
(self.repo / "image.png").write_bytes(b"\x89PNG\r\n\x1a\n\x00binary\xff\xfe")
_git(self.repo, "add", "image.png")
_git(self.repo, "commit", "-q", "-m", "add binary")
with self.assertRaises(git_state.GitStateError) as ctx:
git_state.read_file(self.repo, "image.png")
message = str(ctx.exception)
self.assertTrue("binary" in message or "UTF-8" in message)
def test_read_tracked_non_utf8_text_raises(self) -> None:
# A tracked, NUL-free but non-UTF-8 text file (Latin-1) must raise a
# clear GitStateError, not an unhandled UnicodeDecodeError.
(self.repo / "latin1.txt").write_bytes(b"caf\xe9 latin1")
_git(self.repo, "add", "latin1.txt")
_git(self.repo, "commit", "-q", "-m", "add latin1")
with self.assertRaises(git_state.GitStateError) as ctx:
git_state.read_file(self.repo, "latin1.txt")
self.assertIn("not valid UTF-8 text", str(ctx.exception))
def test_read_tracked_link_outside_repo_is_rejected(self) -> None:
if os.name == "nt":
outside = self.base / "outside"
outside.mkdir()
(outside / "secret.txt").write_text("secret", encoding="utf-8")
link = self.repo / "leak"
_link_directory(link, outside)
tracked_path = "leak/secret.txt"
else:
outside = self.base / "outside.txt"
outside.write_text("secret", encoding="utf-8")
(self.repo / "leak.txt").symlink_to(outside)
tracked_path = "leak.txt"
_git(self.repo, "add", tracked_path)
_git(self.repo, "commit", "-q", "-m", "track link")
with self.assertRaisesRegex(git_state.GitStateError, "escapes repository"):
git_state.read_file(self.repo, tracked_path)
def test_read_tracked_file_is_bounded_during_read(self) -> None:
(self.repo / "large.txt").write_text("x" * (git_state.MAX_FILE_BYTES + 100), encoding="utf-8")
_git(self.repo, "add", "large.txt")
_git(self.repo, "commit", "-q", "-m", "large")
result = git_state.read_file(self.repo, "large.txt")
self.assertTrue(result["truncated"])
self.assertEqual(git_state.MAX_FILE_BYTES, len(result["content"]))
class GitStateDocumentTests(unittest.TestCase):
def test_document_missing_base_notice_leaks_no_path(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
missing = Path(self._td.name) / "does-not-exist"
doc = git_state.build_git_document(missing)
notice = doc["pages"][0]["content"]["children"][0]
self.assertEqual("notice", notice["id"])
value = notice["text"]["value"]
# The document contract forbids filesystem paths: no "/" and no
# path-like substring (e.g. the tmp dir name).
self.assertNotIn("/", value)
self.assertNotIn(self._td.name, value)
class GitStateSecurityTests(unittest.TestCase):
def setUp(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
self.base = Path(self._td.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "sec-repo")
def test_path_traversal_rejected(self) -> None:
for bad in ("../outside", "/etc/passwd", "a/../../b", "..%2Fescape"):
with self.subTest(path=bad):
with self.assertRaises(ValueError):
git_state.resolve_repo_path(self.repo, bad)
def test_remote_urls_scrubbed_of_userinfo(self) -> None:
_add_remote(self.repo, "https://user:secret@example.com/org/repo.git", "https")
_add_remote(self.repo, "ssh://git@example.com:2222/org/repo.git", "ssh")
_add_remote(self.repo, "git@example.com:org/repo.git", "scp")
remotes = git_state.repo_remotes(self.repo)
self.assertEqual(3, len(remotes))
for remote in remotes:
self.assertNotIn("secret", remote["url"])
self.assertNotIn("user:", remote["url"])
self.assertNotIn("git@", remote["url"])
def test_git_error_text_scrubs_embedded_remote_credentials(self) -> None:
message = git_state._safe_git_error(
"fatal: unable to access 'https://user:secret@example.com/repo.git'"
)
self.assertNotIn("user", message)
self.assertNotIn("secret", message)
def test_allowlist_accepts_only_scanned_repos(self) -> None:
scanned = git_state.scan_repos(self.base)
ids = {r["id"] for r in scanned}
self.assertIn(git_state.repo_id(self.repo), ids)
self.assertNotIn("bogus-id", ids)
def test_git_output_over_cap_fails_closed(self) -> None:
for index in range(20):
(self.repo / f"long-untracked-name-{index}.txt").write_text("x", encoding="utf-8")
with patch.object(git_state, "MAX_GIT_OUTPUT_BYTES", 32):
with self.assertRaisesRegex(git_state.GitStateError, "output exceeded"):
git_state.repo_status(self.repo)
if __name__ == "__main__":
unittest.main()
+269
View File
@@ -0,0 +1,269 @@
"""Tests for the Phase 3 extras surface of git_state.
Covers:
- ``commit_message`` / ``commit_message_selected``: staged-diff → LLM → a
conventional-style message suggestion. The model client is MONKEYPATCHED
(never a real API call); empty staged diff must skip the LLM entirely; a
missing/failing model degrades to an empty message + notice, never a 500.
- ``stash_checkout``: dirty tree → auto-stash + switch (stash list entry
present); clean tree → plain checkout; unknown ref → error.
Fixtures build REAL throwaway git repos in tmp_path. git itself is never
mocked.
"""
from __future__ import annotations
import asyncio
import os
import subprocess
import unittest
from pathlib import Path
from unittest.mock import AsyncMock, MagicMock, patch
from plugin import git_state
def _run(cmd: list[str], cwd: Path) -> str:
return subprocess.run(
cmd, cwd=cwd, capture_output=True, text=True, check=True
).stdout.strip()
def _git(repo: Path, *args: str) -> str:
return _run(["git", "-C", str(repo), *args], repo)
def _init_repo(root: Path, name: str) -> Path:
repo = root / name
repo.mkdir(parents=True)
_run(["git", "init", "-q", "-b", "main"], repo)
_run(["git", "config", "user.email", "test@example.com"], repo)
_run(["git", "config", "user.name", "Test User"], repo)
(repo / "README.md").write_text("# Hello\n", encoding="utf-8")
_git(repo, "add", "README.md")
_git(repo, "commit", "-q", "-m", "initial commit")
return repo
class _ExtrasBase(unittest.TestCase):
def setUp(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
self.base = Path(self._td.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "extras-repo")
def _staged_change(self, path: str, content: str) -> None:
(self.repo / path).write_text(content, encoding="utf-8")
_git(self.repo, "add", path)
def _branch(self, name: str) -> None:
_git(self.repo, "checkout", "-q", "-b", name)
_git(self.repo, "checkout", "-q", "main")
def _patch_llm(self, *, text: str = "", exc: Exception | None = None):
"""Inject a fake agent.auxiliary_client chain into git_state.
``_llm_call`` is the async client; ``_llm_extract`` turns its return
into text. The failure path raises ``exc`` from the client.
"""
client = AsyncMock(side_effect=exc) if exc else AsyncMock(return_value="resp")
extractor = MagicMock(return_value=text)
return patch.object(git_state, "_llm_call", client), client, extractor, patch.object(
git_state, "_llm_extract", extractor
)
class CommitMessageTests(_ExtrasBase):
def test_commit_message_returns_suggestion_from_staged_diff(self) -> None:
self._staged_change("feature.txt", "new feature body\n")
llm_patch, client, extractor, extract_patch = self._patch_llm(
text="feat: add new feature\n\nBrings a new feature."
)
with llm_patch, extract_patch:
result = asyncio.run(git_state.commit_message(self.repo))
# The generated message is the LLM text (subject + optional body) so it
# can flow into the commit dialog and be edited.
self.assertEqual(
{"message": "feat: add new feature\n\nBrings a new feature.", "notice": ""},
result,
)
# The client was called with a messages list containing the staged diff.
_, kwargs = client.call_args
self.assertIn("messages", kwargs)
payload = " ".join(str(m) for m in kwargs["messages"])
self.assertIn("new feature", payload)
extractor.assert_called_once_with("resp")
def test_commit_message_empty_staged_diff_skips_llm(self) -> None:
# Clean tree: nothing staged → no LLM call.
p = patch.object(git_state, "_llm_call", AsyncMock())
with p as client:
result = asyncio.run(git_state.commit_message(self.repo))
self.assertEqual({"message": "", "notice": "nothing staged"}, result)
client.assert_not_called()
def test_commit_message_skips_llm_when_staged_diff_is_empty(self) -> None:
# A tracked file modified but NOT staged must never be sent.
(self.repo / "README.md").write_text("# Hello v2\n", encoding="utf-8")
p = patch.object(git_state, "_llm_call", AsyncMock())
with p as client:
result = asyncio.run(git_state.commit_message(self.repo))
self.assertEqual({"message": "", "notice": "nothing staged"}, result)
client.assert_not_called()
def test_commit_message_degrades_when_model_fails(self) -> None:
self._staged_change("feature.txt", "boom\n")
p, _, _, _ = self._patch_llm(exc=RuntimeError("no provider configured"))
with p:
result = asyncio.run(git_state.commit_message(self.repo))
self.assertEqual("", result["message"])
self.assertIn("model", result["notice"].lower())
def test_commit_message_degrades_when_model_unavailable(self) -> None:
self._staged_change("feature.txt", "x\n")
# Resolver itself fails (e.g. `agent` not installed).
with patch.object(git_state, "_resolve_llm", side_effect=ImportError("no agent")):
result = asyncio.run(git_state.commit_message(self.repo))
self.assertEqual("", result["message"])
self.assertIn("model", result["notice"].lower())
def test_commit_message_bounds_staged_diff(self) -> None:
# A large staged diff is truncated to MAX_DIFF_BYTES and flagged.
big = "x" * (git_state.MAX_DIFF_BYTES + 10)
self._staged_change("big.txt", big)
p, client, extractor, ep = self._patch_llm(text="add big")
with p, ep:
result = asyncio.run(git_state.commit_message(self.repo))
self.assertEqual("add big", result["message"])
_, kwargs = client.call_args
payload = "".join(str(m) for m in kwargs["messages"])
self.assertLessEqual(len(payload), git_state.MAX_DIFF_BYTES + 2048)
self.assertNotIn("nothing staged", result.get("notice", ""))
class CommitMessageSelectedTests(_ExtrasBase):
def test_commit_message_selected_honors_only_given_paths(self) -> None:
self._staged_change("kept.txt", "kept content\n")
self._staged_change("skip.txt", "skip content\n")
p, client, extractor, extract_p = self._patch_llm(text="add kept")
with p, extract_p:
result = asyncio.run(
git_state.commit_message_selected(self.repo, ["kept.txt"])
)
self.assertEqual("add kept", result["message"])
_, kwargs = client.call_args
payload = "".join(str(m) for m in kwargs["messages"])
self.assertIn("kept content", payload)
self.assertNotIn("skip content", payload)
def test_commit_message_selected_skips_llm_when_none_selected_staged(self) -> None:
self._staged_change("kept.txt", "kept\n")
# A path with no staged content → nothing staged → no call.
(self.repo / "other.txt").write_text("other\n", encoding="utf-8")
_git(self.repo, "add", "other.txt")
# Stage only kept.txt, ask for other.txt's diff (not staged) → nothing.
p = patch.object(git_state, "_llm_call", AsyncMock())
with p as client:
# Ask for a path that has no STAGED diff: unstage other first.
_git(self.repo, "restore", "--staged", "other.txt")
result = asyncio.run(
git_state.commit_message_selected(self.repo, ["other.txt"])
)
self.assertEqual({"message": "", "notice": "nothing staged"}, result)
client.assert_not_called()
def test_commit_message_selected_rejects_traversal_path(self) -> None:
self._staged_change("kept.txt", "kept\n")
with self.assertRaises(git_state.GitStateError):
asyncio.run(
git_state.commit_message_selected(self.repo, ["../escape"])
)
class StashCheckoutTests(_ExtrasBase):
def test_dirty_tree_stashes_then_switches(self) -> None:
self._branch("feature")
(self.repo / "README.md").write_text("dirty change\n", encoding="utf-8")
result = git_state.stash_checkout(self.repo, "feature")
self.assertTrue(result["stashed"])
self.assertEqual("git-state: feature", result["stash_message"])
self.assertEqual("feature", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
stash_list = _git(self.repo, "stash", "list")
self.assertIn("git-state: feature", stash_list)
def test_clean_tree_plain_checkout_no_stash(self) -> None:
self._branch("feature")
result = git_state.stash_checkout(self.repo, "feature")
self.assertFalse(result["stashed"])
self.assertEqual("", result["stash_message"])
self.assertEqual("feature", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
self.assertEqual("", _git(self.repo, "stash", "list"))
def test_clean_tree_new_branch_switch(self) -> None:
result = git_state.stash_checkout(self.repo, "main", new_branch="exp")
self.assertFalse(result["stashed"])
self.assertEqual("exp", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
def test_stash_returns_fresh_status_and_branches(self) -> None:
self._branch("feature")
(self.repo / "README.md").write_text("dirty\n", encoding="utf-8")
result = git_state.stash_checkout(self.repo, "feature")
self.assertIn("status", result)
self.assertIn("branches", result)
self.assertIn("head", result)
def test_bad_ref_raises(self) -> None:
(self.repo / "README.md").write_text("still here\n", encoding="utf-8")
with self.assertRaises(git_state.GitStateError):
git_state.stash_checkout(self.repo, "no-such-branch")
self.assertEqual("still here\n", (self.repo / "README.md").read_text(encoding="utf-8"))
self.assertEqual("", _git(self.repo, "stash", "list"))
def test_existing_new_branch_is_rejected_before_stashing(self) -> None:
(self.repo / "README.md").write_text("still here\n", encoding="utf-8")
with self.assertRaisesRegex(git_state.GitError, "already exists"):
git_state.stash_checkout(self.repo, "main", new_branch="main")
self.assertEqual("still here\n", (self.repo / "README.md").read_text(encoding="utf-8"))
self.assertEqual("", _git(self.repo, "stash", "list"))
def test_checkout_failure_restores_tracked_staged_and_untracked_changes(self) -> None:
self._branch("feature")
(self.repo / "README.md").write_text("dirty\n", encoding="utf-8")
(self.repo / "staged.txt").write_text("staged\n", encoding="utf-8")
_git(self.repo, "add", "staged.txt")
(self.repo / "untracked.txt").write_text("untracked\n", encoding="utf-8")
original_mutate = git_state._mutate
def fail_checkout(repo: Path, args: list[str]) -> str:
if args[0] == "checkout":
raise git_state.GitError("forced checkout failure", code="conflict")
return original_mutate(repo, args)
with patch.object(git_state, "_mutate", side_effect=fail_checkout):
with self.assertRaisesRegex(git_state.GitError, "working changes were restored"):
git_state.stash_checkout(self.repo, "feature")
self.assertEqual("dirty\n", (self.repo / "README.md").read_text(encoding="utf-8"))
self.assertTrue((self.repo / "staged.txt").exists())
self.assertTrue((self.repo / "untracked.txt").exists())
self.assertIn("staged.txt", _git(self.repo, "diff", "--cached", "--name-only"))
self.assertIn("git-state: feature", _git(self.repo, "stash", "list"))
def test_new_branch_uses_requested_start_point(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
(self.repo / "feature-only.txt").write_text("feature", encoding="utf-8")
_git(self.repo, "add", "feature-only.txt")
_git(self.repo, "commit", "-q", "-m", "feature")
_git(self.repo, "checkout", "-q", "main")
git_state.stash_checkout(self.repo, "feature", new_branch="from-feature")
self.assertTrue((self.repo / "feature-only.txt").exists())
if __name__ == "__main__":
unittest.main()
+406
View File
@@ -0,0 +1,406 @@
"""Tests for the write (mutation) surface of git_state.
Security denials are tested FIRST: destructive mutations (discard, push, dirty
checkout) reject when their confirmation string is missing or wrong. Then happy
paths, then error branches. Fixtures build REAL throwaway git repos and bare
remotes in tmp_path — git itself is never mocked.
"""
from __future__ import annotations
import os
import subprocess
import unittest
from pathlib import Path
from plugin import git_state
def _run(cmd: list[str], cwd: Path) -> str:
result = subprocess.run(
cmd,
cwd=cwd,
capture_output=True,
text=True,
check=True,
)
return result.stdout.strip()
def _git(repo: Path, *args: str) -> str:
return _run(["git", "-C", str(repo), *args], repo)
def _init_repo(root: Path, name: str) -> Path:
repo = root / name
repo.mkdir(parents=True)
_run(["git", "init", "-q", "-b", "main"], repo)
_run(["git", "config", "user.email", "test@example.com"], repo)
_run(["git", "config", "user.name", "Test User"], repo)
(repo / "README.md").write_text("# Hello\n", encoding="utf-8")
_git(repo, "add", "README.md")
_git(repo, "commit", "-q", "-m", "initial commit")
return repo
def _init_bare_remote(root: Path, name: str) -> Path:
remote = root / name
remote.mkdir(parents=True, exist_ok=True)
_run(["git", "init", "-q", "--bare", "-b", "main"], remote)
return remote
class _MutationBase(unittest.TestCase):
def setUp(self) -> None:
import tempfile
self._td = tempfile.TemporaryDirectory()
self.addCleanup(self._td.cleanup)
self.base = Path(self._td.name) / "projects"
self.base.mkdir(parents=True)
self.repo = _init_repo(self.base, "write-repo")
def _make_change(self, path: str = "feature.txt", content: str = "hello") -> None:
(self.repo / path).write_text(content, encoding="utf-8")
_git(self.repo, "add", path)
def _head(self) -> str:
return _git(self.repo, "rev-parse", "HEAD")
class StageUnstageTests(_MutationBase):
def test_stage_moves_untracked_to_staged(self) -> None:
(self.repo / "new.txt").write_text("x", encoding="utf-8")
git_state.stage(self.repo, ["new.txt"])
status = git_state.repo_status(self.repo)
self.assertIn("new.txt", [e["path"] for e in status["staged"]])
self.assertNotIn("new.txt", [e["path"] for e in status["untracked"]])
def test_stage_accepts_multiple_paths(self) -> None:
(self.repo / "a.txt").write_text("a", encoding="utf-8")
(self.repo / "b.txt").write_text("b", encoding="utf-8")
git_state.stage(self.repo, ["a.txt", "b.txt"])
status = git_state.repo_status(self.repo)
staged = {e["path"] for e in status["staged"]}
self.assertTrue({"a.txt", "b.txt"} <= staged)
def test_unstage_returns_to_modified(self) -> None:
(self.repo / "tracked.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
git_state.unstage(self.repo, ["tracked.txt"])
status = git_state.repo_status(self.repo)
self.assertNotIn("tracked.txt", [e["path"] for e in status["staged"]])
self.assertIn("tracked.txt", [e["path"] for e in status["modified"]])
def test_stage_rejects_traversal_path(self) -> None:
with self.assertRaises(git_state.GitStateError):
git_state.stage(self.repo, ["../outside"])
class CommitTests(_MutationBase):
def test_commit_creates_a_real_commit(self) -> None:
before = self._head()
(self.repo / "feature.txt").write_text("feature", encoding="utf-8")
git_state.stage(self.repo, ["feature.txt"])
git_state.commit(self.repo, "add feature")
after = self._head()
self.assertNotEqual(before, after)
message = _git(self.repo, "log", "-1", "--format=%s")
self.assertEqual("add feature", message)
def test_commit_rejects_empty_message(self) -> None:
(self.repo / "feature.txt").write_text("feature", encoding="utf-8")
git_state.stage(self.repo, ["feature.txt"])
with self.assertRaises(git_state.GitStateError):
git_state.commit(self.repo, " ")
def test_commit_returns_fresh_status(self) -> None:
(self.repo / "feature.txt").write_text("feature", encoding="utf-8")
git_state.stage(self.repo, ["feature.txt"])
result = git_state.commit(self.repo, "add feature")
self.assertEqual(result["head"], self._head())
self.assertEqual(result["status"]["counts"]["staged"], 0)
self.assertEqual(result["status"]["counts"]["modified"], 0)
def test_commit_selected_commits_only_given_paths(self) -> None:
(self.repo / "kept.txt").write_text("keep", encoding="utf-8")
(self.repo / "skip.txt").write_text("skip", encoding="utf-8")
_git(self.repo, "add", "kept.txt", "skip.txt")
git_state.commit_selected(self.repo, "commit kept only", ["kept.txt"])
head_files = _git(self.repo, "ls-tree", "-r", "--name-only", "HEAD")
self.assertIn("kept.txt", head_files)
self.assertNotIn("skip.txt", head_files)
def test_commit_selected_returns_fresh_status(self) -> None:
(self.repo / "a.txt").write_text("a", encoding="utf-8")
git_state.stage(self.repo, ["a.txt"])
result = git_state.commit_selected(self.repo, "commit a", ["a.txt"])
self.assertEqual(result["head"], self._head())
self.assertEqual(result["status"]["counts"]["staged"], 0)
def test_commit_selected_rejects_empty_message(self) -> None:
(self.repo / "a.txt").write_text("a", encoding="utf-8")
git_state.stage(self.repo, ["a.txt"])
with self.assertRaises(git_state.GitError):
git_state.commit_selected(self.repo, "", ["a.txt"])
class DiscardConfirmationTests(_MutationBase):
def test_discard_requires_confirmation_string(self) -> None:
(self.repo / "tracked.txt").write_text("dirty", encoding="utf-8")
with self.assertRaises(git_state.GitError) as ctx:
git_state.discard(self.repo, ["tracked.txt"], confirmation="")
self.assertIn("confirmation", str(ctx.exception).lower())
def test_discard_rejects_wrong_confirmation(self) -> None:
(self.repo / "tracked.txt").write_text("dirty", encoding="utf-8")
with self.assertRaises(git_state.GitError):
git_state.discard(self.repo, ["tracked.txt"], confirmation="wrong")
def test_discard_with_confirmation_reverts_tracked_changes(self) -> None:
(self.repo / "tracked.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
git_state.discard(self.repo, ["tracked.txt"], confirmation=git_state.CONFIRM_DISCARD)
content = (self.repo / "tracked.txt").read_text(encoding="utf-8")
self.assertEqual("v1", content)
def test_discard_delete_untracked_removes_untracked(self) -> None:
(self.repo / "untracked.txt").write_text("new", encoding="utf-8")
git_state.discard(
self.repo,
["untracked.txt"],
confirmation=git_state.CONFIRM_DISCARD,
delete_untracked=True,
)
self.assertFalse((self.repo / "untracked.txt").exists())
def test_discard_returns_fresh_status(self) -> None:
(self.repo / "tracked.txt").write_text("v1", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
(self.repo / "tracked.txt").write_text("v2", encoding="utf-8")
result = git_state.discard(
self.repo,
["tracked.txt"],
confirmation=git_state.CONFIRM_DISCARD,
)
self.assertEqual(result["status"]["counts"]["modified"], 0)
class FetchPullPushTests(_MutationBase):
def setUp(self) -> None:
super().setUp()
self.remote = _init_bare_remote(self.base, "origin-bare")
_git(self.repo, "remote", "add", "origin", str(self.remote))
_git(self.repo, "push", "-q", "origin", "main")
_git(self.repo, "branch", "-q", "--set-upstream-to=origin/main", "main")
def test_fetch_rejects_unknown_and_option_like_remote(self) -> None:
for remote in ("https://example.invalid/repo.git", "--all", "missing"):
with self.subTest(remote=remote):
with self.assertRaisesRegex(git_state.GitError, "remote"):
git_state.fetch(self.repo, remote)
def test_pull_and_push_reject_option_like_branch(self) -> None:
with self.assertRaisesRegex(git_state.GitError, "branch"):
git_state.pull(self.repo, "origin", "--all")
with self.assertRaisesRegex(git_state.GitError, "branch"):
git_state.push(self.repo, "origin", "--mirror", git_state.CONFIRM_PUSH)
def test_fetch_updates_remote_refs(self) -> None:
# Advance the remote from a descendant clone (not an independent repo:
# an independent root has its own "initial commit" SHA, and when it
# lands in a different second than the remote's initial commit the push
# is rejected as non-fast-forward, flaking the test).
other = self.base / "other"
_run(["git", "clone", "-q", str(self.remote), str(other)], self.base)
_git(other, "config", "user.email", "test@example.com")
_git(other, "config", "user.name", "Test User")
(other / "remote.txt").write_text("remote change fetch", encoding="utf-8")
_git(other, "add", "remote.txt")
_git(other, "commit", "-q", "-m", "remote change fetch")
_git(other, "push", "-q", "origin", "main")
git_state.fetch(self.repo, "origin")
remote_main = _git(self.repo, "rev-parse", "origin/main")
self.assertNotEqual(remote_main, self._head())
def test_pull_brings_remote_commits(self) -> None:
other = self.base / "other"
_run(["git", "clone", "-q", str(self.remote), str(other)], self.base)
_git(other, "config", "user.email", "test@example.com")
_git(other, "config", "user.name", "Test User")
(other / "remote.txt").write_text("remote change pull", encoding="utf-8")
_git(other, "add", "remote.txt")
_git(other, "commit", "-q", "-m", "remote change pull")
_git(other, "push", "-q", "origin", "main")
git_state.pull(self.repo, "origin", "main")
self.assertIn("remote.txt", _git(self.repo, "ls-tree", "-r", "--name-only", "HEAD"))
def test_push_requires_confirmation(self) -> None:
(self.repo / "feature.txt").write_text("f", encoding="utf-8")
git_state.stage(self.repo, ["feature.txt"])
git_state.commit(self.repo, "feature")
with self.assertRaises(git_state.GitError) as ctx:
git_state.push(self.repo, "origin", "main", confirmation="")
self.assertIn("confirmation", str(ctx.exception).lower())
def test_push_rejects_wrong_confirmation(self) -> None:
(self.repo / "feature.txt").write_text("f", encoding="utf-8")
git_state.stage(self.repo, ["feature.txt"])
git_state.commit(self.repo, "feature")
with self.assertRaises(git_state.GitError):
git_state.push(self.repo, "origin", "main", confirmation="nope")
def test_push_with_confirmation_updates_remote(self) -> None:
(self.repo / "feature.txt").write_text("f", encoding="utf-8")
git_state.stage(self.repo, ["feature.txt"])
git_state.commit(self.repo, "feature")
git_state.push(self.repo, "origin", "main", confirmation=git_state.CONFIRM_PUSH)
remote_head = _run(["git", "ls-remote", str(self.remote), "refs/heads/main"], self.remote)
self.assertIn(self._head(), remote_head)
def test_pull_with_local_changes_yields_structured_dirty_error(self) -> None:
# Repo tracks a file, then the remote advances it. A local uncommitted
# edit to that file must never be clobbered by pull → structured dirty.
(self.repo / "tracked.txt").write_text("base", encoding="utf-8")
_git(self.repo, "add", "tracked.txt")
_git(self.repo, "commit", "-q", "-m", "add tracked")
_git(self.repo, "push", "-q", "origin", "main")
# Advance the remote from a clean clone whose history descends from it.
other = self.base / "other"
_run(["git", "clone", "-q", str(self.remote), str(other)], self.base)
_git(other, "config", "user.email", "test@example.com")
_git(other, "config", "user.name", "Test User")
(other / "tracked.txt").write_text("remote", encoding="utf-8")
_git(other, "add", "tracked.txt")
_git(other, "commit", "-q", "-m", "remote tracked")
_git(other, "push", "-q", "origin", "main")
# Local uncommitted change to tracked.txt → git refuses to clobber.
(self.repo / "tracked.txt").write_text("uncommitted", encoding="utf-8")
with self.assertRaises(git_state.GitError) as ctx:
git_state.pull(self.repo, "origin", "main")
self.assertEqual("dirty", ctx.exception.code)
def test_push_auth_failure_maps_to_auth_error(self) -> None:
(self.repo / "feature.txt").write_text("f", encoding="utf-8")
git_state.stage(self.repo, ["feature.txt"])
git_state.commit(self.repo, "feature")
# Point origin at a host that will reject credentials.
_git(self.repo, "remote", "set-url", "origin", "https://invalid.invalid/x.git")
with self.assertRaises(git_state.GitError) as ctx:
git_state.push(self.repo, "origin", "main", confirmation=git_state.CONFIRM_PUSH)
self.assertIn(ctx.exception.code, ("auth", "network"))
class CheckoutTests(_MutationBase):
def test_checkout_rejects_option_like_ref(self) -> None:
with self.assertRaisesRegex(git_state.GitError, "git option"):
git_state.checkout(self.repo, "--detach")
def test_checkout_switches_branch(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
git_state.checkout(self.repo, "feature", confirmation="")
self.assertEqual("feature", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
def test_checkout_new_branch_creates_branch(self) -> None:
git_state.checkout(
self.repo,
"main",
new_branch="exp",
confirmation="",
)
self.assertEqual("exp", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
def test_checkout_new_branch_uses_requested_start_point(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
(self.repo / "feature-only.txt").write_text("feature", encoding="utf-8")
_git(self.repo, "add", "feature-only.txt")
_git(self.repo, "commit", "-q", "-m", "feature")
_git(self.repo, "checkout", "-q", "main")
git_state.checkout(self.repo, "feature", new_branch="from-feature")
self.assertTrue((self.repo / "feature-only.txt").exists())
def test_checkout_clean_tree_needs_no_confirmation(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
git_state.checkout(self.repo, "feature", confirmation="")
self.assertEqual("feature", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
def test_checkout_dirty_tree_requires_confirmation(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
(self.repo / "tracked.txt").write_text("dirty", encoding="utf-8")
with self.assertRaises(git_state.GitError) as ctx:
git_state.checkout(self.repo, "feature", confirmation="")
self.assertIn("confirmation", str(ctx.exception).lower())
def test_checkout_dirty_tree_wrong_confirmation_rejected(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
(self.repo / "tracked.txt").write_text("dirty", encoding="utf-8")
with self.assertRaises(git_state.GitError):
git_state.checkout(self.repo, "feature", confirmation="wrong")
def test_checkout_dirty_tree_with_confirmation_switches(self) -> None:
_git(self.repo, "checkout", "-q", "-b", "feature")
_git(self.repo, "checkout", "-q", "main")
(self.repo / "tracked.txt").write_text("dirty", encoding="utf-8")
git_state.checkout(
self.repo,
"feature",
confirmation=git_state.CONFIRM_DIRTY_CHECKOUT,
)
self.assertEqual("feature", _git(self.repo, "symbolic-ref", "--short", "HEAD"))
def test_checkout_track_sets_upstream(self) -> None:
self.remote = _init_bare_remote(self.base, "remote-bare.git")
_git(self.repo, "remote", "add", "origin", str(self.remote))
_git(self.repo, "push", "-q", "origin", "main")
# Create origin/feature remotely via a second clone.
other = _init_repo(self.base, "other")
_git(other, "remote", "add", "origin", str(self.remote))
_git(other, "checkout", "-q", "-b", "feature")
(other / "feature.txt").write_text("f", encoding="utf-8")
_git(other, "add", "feature.txt")
_git(other, "commit", "-q", "-m", "feature")
_git(other, "push", "-q", "origin", "feature")
# Bring the remote-tracking ref into this repo, then track it.
git_state.fetch(self.repo, "origin")
git_state.checkout(
self.repo,
"origin/feature",
confirmation="",
track=True,
)
current = _git(self.repo, "symbolic-ref", "--short", "HEAD")
self.assertEqual("feature", current)
upstream = _git(self.repo, "rev-parse", "--abbrev-ref", "feature@{upstream}")
self.assertEqual("origin/feature", upstream)
class AllowlistTests(_MutationBase):
def test_mutations_reject_unknown_repo(self) -> None:
with self.assertRaises(git_state.GitStateError):
git_state.stage(Path("/nonexistent"), ["x.txt"])
with self.assertRaises(git_state.GitStateError):
git_state.discard(
Path("/nonexistent"),
["x.txt"],
confirmation=git_state.CONFIRM_DISCARD,
)
if __name__ == "__main__":
unittest.main()
+10 -2
View File
@@ -46,14 +46,17 @@ class MobilePluginStoreTests(unittest.TestCase):
manifest = self.store.manifest()
self.assertEqual("hermes-relay", manifest["id"])
contribution = manifest["contributions"][0]
contribution = next(c for c in manifest["contributions"] if c["id"] == "daily-brief")
self.assertEqual("Draft: Daily Brief", contribution["title"])
self.assertEqual("mobile/pages/daily-brief", contribution["document"]["path"])
self.assertEqual(_document(), self.store.get("daily-brief")["document"])
published = self.store.publish("daily-brief")
self.assertEqual("published", published["status"])
self.assertEqual("Daily Brief", self.store.manifest()["contributions"][0]["title"])
published_contribution = next(
c for c in self.store.manifest()["contributions"] if c["id"] == "daily-brief"
)
self.assertEqual("Daily Brief", published_contribution["title"])
self.assertEqual({"ok": True, "id": "daily-brief"}, self.store.remove("daily-brief"))
self.assertEqual([], self.store.list())
@@ -81,6 +84,11 @@ class MobilePluginStoreTests(unittest.TestCase):
document={"schemaVersion": 1, "pages": []},
)
def test_rejects_reserved_git_id(self) -> None:
with self.assertRaisesRegex(MobilePluginStoreError, "reserved"):
self.store.draft("git", title="Shadow", description="", document=_document())
self.assertEqual(["git"], [item["id"] for item in self.store.manifest()["contributions"]])
def test_listing_omits_document_payload(self) -> None:
self.store.draft("compact", title="Compact", description="", document=_document())
self.assertNotIn("document", self.store.list()[0])
+1
View File
@@ -250,6 +250,7 @@ export default defineConfig({
{ text: 'Token Tracking', link: '/features/tokens' },
{ text: 'Tool Progress', link: '/features/tools' },
{ text: 'Plugins', link: '/features/plugins' },
{ text: 'Git Workspace', link: '/features/git-workspace' },
{ text: 'Phone Control Tools', link: '/features/phone-control-tools' },
{ text: 'Dashboard Plugin', link: '/features/dashboard' },
],
+56
View File
@@ -0,0 +1,56 @@
# Git workspace
Hermes-Relay Android can review and operate a host repository through a native
Git workspace. The Android interface is first-party Compose UI; the optional
Hermes-Relay plugin supplies the authenticated, repository-scoped Git API.
![Native Git workspace](/git-workspace.png)
## Requirements
- The Hermes-Relay plugin must be installed and enabled on the selected Hermes
connection and profile.
- The Dashboard must expose the plugin's `git/*` API routes.
- Repositories must be below the host's configured Git discovery root.
- Write actions require the plugin's **Allow changes** grant.
If Android discovers the Git contribution but the live route is unavailable,
the workspace shows a retryable availability message instead of a raw server
response.
## Open the workspace
Use any of these entry points:
- Tap the branch indicator or change rail above the Chat composer.
- Open **Settings → Git workspace**.
- Open **Settings → Plugins → Hermes-Relay → Git**.
When the active chat session reports an exact repository root or working
directory, Android selects the matching repository. If several repositories
are possible, choose one from the repository picker.
## Chat controls
The compact Chat rail shows the current branch, unique changed-file count, and
tracked line additions/deletions. Open **Settings → Chat** and turn off **Show
Git workspace in Chat** to hide the Chat indicator and rail. This setting does
not disable the full Git workspace.
## Review and change files
The workspace groups staged, modified, and untracked files and provides filters,
tracked-file content, and staged or unstaged diffs. Binary and untracked files
do not expose arbitrary working-tree content through the preview route.
With **Allow changes** enabled, you can:
- stage modified or untracked files and unstage staged files;
- discard modified content or delete selected untracked files after confirmation;
- create and switch branches, including a recoverable stash-and-switch path;
- generate or enter a commit message and optionally push after committing;
- fetch, fast-forward pull, and push.
Discard, push, and dirty checkout each require a fresh confirmation. Requests
remain bound to the selected connection, profile, repository, and repository
generation so switching context cannot redirect an already-reviewed action.
+1
View File
@@ -22,6 +22,7 @@ A **<span class="track-badge track-badge--sideload">Sideload only</span>** badge
| [Token Tracking](/features/tokens) | Per-message usage and cost |
| [Tool Progress](/features/tools) | Configurable display — Off, Compact, or Detailed |
| [Plugins](/features/plugins) | Native reactive pages, including Relay-assisted agent-created previews |
| [Git workspace](/features/git-workspace) | Native repository status, diffs, branches, staging, commits, and remotes through the Relay plugin |
## Bridge Core
Binary file not shown.

After

Width:  |  Height:  |  Size: 127 KiB

+4
View File
@@ -14,6 +14,10 @@ const assets = [
source: resolve(repoRoot, 'assets/screenshots/07_connections.png'),
destination: resolve(docsRoot, 'public/connections-demo.png'),
},
{
source: resolve(repoRoot, 'assets/screenshots/supplemental/15_git_workspace.png'),
destination: resolve(docsRoot, 'public/git-workspace.png'),
},
]
const desktopManifest = JSON.parse(
+1 -1
View File
@@ -32,7 +32,7 @@ No analytics or third-party tracking scripts are included.
## Product screenshots
Chat, Voice, and Manage imagery comes from the repository's canonical,
Chat, Voice, Manage, and Git workspace imagery comes from the repository's canonical,
deterministically rendered Android scenes in `../assets/screenshots/`. The
mapping is read from `../docs/media/screenshots.json`; files under
`public/product/` are deployment copies, not an independent source of truth.
Binary file not shown.

After

Width:  |  Height:  |  Size: 16 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 36 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 127 KiB

+1
View File
@@ -12,6 +12,7 @@ const productAssets = [
{ sceneId: '03_voice', destination: 'voice.png' },
{ sceneId: '01_voice_conversation', destination: 'voice-conversation.png' },
{ sceneId: '06_manage', destination: 'manage.png' },
{ sceneId: '15_git_workspace', destination: 'git-workspace.png' },
];
const mode = process.argv[2] ?? 'check';
+2
View File
@@ -15,6 +15,8 @@ const variants = [
{ source: 'voice-conversation.png', destination: 'voice-conversation-720.webp', width: 720 },
{ source: 'manage.png', destination: 'manage-360.webp', width: 360 },
{ source: 'manage.png', destination: 'manage-720.webp', width: 720 },
{ source: 'git-workspace.png', destination: 'git-workspace-360.webp', width: 360 },
{ source: 'git-workspace.png', destination: 'git-workspace-720.webp', width: 720 },
];
if (!['check', 'sync'].includes(mode)) {
+7
View File
@@ -25,6 +25,7 @@ type Copy = {
surfaces: {
kicker: string; title: string; lede: string; androidTitle: string; androidLede: string;
chatDescription: string; voiceDescription: string; manageDescription: string; additional: string;
gitCaption: string; gitAlt: string;
cliTitle: string; cliLede: string; terminal: string; consentTitle: string; consentBody: string;
capabilities: string; sessionsTitle: string; sessionsBody: string; daemonTitle: string; daemonBody: string;
auditTitle: string; auditBody: string; uiTitle: string; uiBody: string; meetCli: string;
@@ -84,6 +85,7 @@ export const translations: Record<Locale, Copy> = {
androidLede: 'Take conversations on the go, speak naturally, and manage the Hermes you already run.',
chatDescription: 'Streaming conversations and live agent work.', voiceDescription: 'Speak naturally, interrupt, and keep moving.',
manageDescription: 'Profiles, skills, models, and automations.', additional: 'Additional Android surfaces',
gitCaption: 'Git workspace · Relay', gitAlt: 'Hermes-Relay native Git workspace with changes, inline diff, and staging controls',
cliTitle: 'Consent-gated access on your machine.', cliLede: 'Give Hermes hands on the machine — only when you allow it.',
terminal: 'Hermes-Relay command line preview', consentTitle: 'Consent is explicit and local.',
consentBody: 'You decide when Hermes can run commands, read files, or make changes.', capabilities: 'CLI capabilities',
@@ -166,6 +168,7 @@ export const translations: Record<Locale, Copy> = {
androidLede: 'Setze Gespräche unterwegs fort, sprich natürlich und verwalte den Hermes, den du bereits betreibst.',
chatDescription: 'Streaming-Gespräche und laufende Agentenarbeit.', voiceDescription: 'Sprich natürlich, unterbrich und bleib in Bewegung.',
manageDescription: 'Profile, Skills, Modelle und Automatisierungen.', additional: 'Weitere Android-Oberflächen',
gitCaption: 'Git-Arbeitsbereich · Relay', gitAlt: 'Nativer Git-Arbeitsbereich von Hermes-Relay mit Änderungen, Inline-Diff und Staging-Steuerung',
cliTitle: 'Zustimmungspflichtiger Zugriff auf deinen Rechner.', cliLede: 'Gib Hermes Hände auf dem Rechner — nur wenn du es erlaubst.',
terminal: 'Hermes-Relay Kommandozeilenvorschau', consentTitle: 'Zustimmung ist ausdrücklich und lokal.',
consentBody: 'Du entscheidest, wann Hermes Befehle ausführen, Dateien lesen oder Änderungen vornehmen darf.', capabilities: 'CLI-Funktionen',
@@ -248,6 +251,7 @@ export const translations: Record<Locale, Copy> = {
androidLede: 'Continúa conversaciones, habla con naturalidad y administra el Hermes que ya utilizas.',
chatDescription: 'Conversaciones en streaming y trabajo del agente en vivo.', voiceDescription: 'Habla con naturalidad, interrumpe y sigue en movimiento.',
manageDescription: 'Perfiles, skills, modelos y automatizaciones.', additional: 'Otras superficies de Android',
gitCaption: 'Espacio de Git · Relay', gitAlt: 'Espacio de Git nativo de Hermes-Relay con cambios, diff en línea y controles de staging',
cliTitle: 'Acceso a tu equipo sujeto a consentimiento.', cliLede: 'Dale manos a Hermes en el equipo, solo cuando tú lo permitas.',
terminal: 'Vista previa de la línea de comandos de Hermes-Relay', consentTitle: 'El consentimiento es explícito y local.',
consentBody: 'Tú decides cuándo Hermes puede ejecutar comandos, leer archivos o realizar cambios.', capabilities: 'Funciones de la CLI',
@@ -330,6 +334,7 @@ export const translations: Record<Locale, Copy> = {
androidLede: '外出先でも会話を続け、自然に話し、すでに動かしている Hermes を管理できます。',
chatDescription: '会話と Agent の作業をリアルタイムにストリーミング。', voiceDescription: '自然に話し、割り込み、そのまま行動できます。',
manageDescription: 'プロファイル、Skills、モデル、自動化を管理。', additional: 'その他の Android 画面',
gitCaption: 'Git ワークスペース · Relay', gitAlt: '変更、インライン差分、ステージ操作を表示する Hermes-Relay のネイティブ Git ワークスペース',
cliTitle: '同意で保護されたマシンアクセス。', cliLede: '許可したときだけ、Hermes にマシンを操作する手を与えます。',
terminal: 'Hermes-Relay コマンドラインのプレビュー', consentTitle: '同意は明示的かつローカルです。',
consentBody: 'Hermes がコマンドを実行し、ファイルを読み、変更できるタイミングはあなたが決めます。', capabilities: 'CLI の機能',
@@ -412,6 +417,7 @@ export const translations: Record<Locale, Copy> = {
androidLede: 'Continue conversas em qualquer lugar, fale naturalmente e gerencie o Hermes que você já executa.',
chatDescription: 'Conversas por streaming e trabalho do agente em tempo real.', voiceDescription: 'Fale naturalmente, interrompa e continue em movimento.',
manageDescription: 'Perfis, skills, modelos e automações.', additional: 'Outras interfaces Android',
gitCaption: 'Espaço de trabalho Git · Relay', gitAlt: 'Espaço de trabalho Git nativo do Hermes-Relay com alterações, diff em linha e controles de staging',
cliTitle: 'Acesso à sua máquina controlado por consentimento.', cliLede: 'Dê mãos ao Hermes na máquina — somente quando você permitir.',
terminal: 'Prévia da linha de comando do Hermes-Relay', consentTitle: 'O consentimento é explícito e local.',
consentBody: 'Você decide quando o Hermes pode executar comandos, ler arquivos ou fazer alterações.', capabilities: 'Recursos da CLI',
@@ -494,6 +500,7 @@ export const translations: Record<Locale, Copy> = {
androidLede: '随时继续对话,自然交谈,并管理您已在运行的 Hermes。',
chatDescription: '流式对话和实时 Agent 工作。', voiceDescription: '自然交谈、随时打断,并保持移动。',
manageDescription: '管理配置文件、Skills、模型和自动化。', additional: '其他 Android 界面',
gitCaption: 'Git 工作区 · Relay', gitAlt: 'Hermes-Relay 原生 Git 工作区,显示更改、内联差异和暂存控件',
cliTitle: '通过同意控制计算机访问。', cliLede: '只有在您允许时,才让 Hermes 操作计算机。',
terminal: 'Hermes-Relay 命令行预览', consentTitle: '同意是明确且本地的。',
consentBody: '由您决定 Hermes 何时可以运行命令、读取文件或进行更改。', capabilities: 'CLI 功能',
+13
View File
@@ -366,6 +366,19 @@ const structuredData = {
/>
<figcaption>Manage</figcaption>
</figure>
<figure>
<img
src="/product/git-workspace.png"
srcset="/product/git-workspace-360.webp 360w, /product/git-workspace-720.webp 720w, /product/git-workspace.png 1080w"
sizes="(max-width: 720px) 45vw, (max-width: 980px) 38vw, 260px"
width="1080"
height="2160"
alt={copy.surfaces.gitAlt}
loading="lazy"
decoding="async"
/>
<figcaption>{copy.surfaces.gitCaption}</figcaption>
</figure>
</div>
</div>
</article>
+2 -1
View File
@@ -730,7 +730,7 @@ img {
.screen-strip {
display: grid;
grid-template-columns: repeat(3, minmax(0, 1fr));
grid-template-columns: repeat(4, minmax(0, 1fr));
gap: 20px;
width: 100%;
max-width: none;
@@ -1701,6 +1701,7 @@ img {
.screen-strip {
margin-left: 0;
grid-template-columns: repeat(2, minmax(0, 1fr));
}
.desktop-ui-inline {